Commit Graph

108 Commits

Author SHA1 Message Date
github-actions[bot] e6f3fb8575 Version Packages (next) 2022-03-29 08:42:22 +00:00
Joe Porpeglia e43290ce96 Rename permission backend request and response types
Signed-off-by: Joe Porpeglia <josephp@spotify.com>
2022-03-25 10:02:46 -04:00
MT Lewis 9da18e4715 search: throw error for unexpected non-resource permissions when authorizing result-by-result
We only reach this point in the code for types where the initial
authorization returned CONDITIONAL -- ALLOWs return early immediately
above, and types where the decision was DENY get filtered out entirely
when querying.

This means the call to isResourcePermission here is mostly about
narrowing the types, since the only way for it to be false is if the
PermissionPolicy returned a CONDITIONAL decision for a non-resource
permission, which can't happen - it would throw an error during
validation in the permission-backend.

Signed-off-by: MT Lewis <mtlewis@users.noreply.github.com>
2022-03-23 15:58:42 -04:00
Mike Lewis 30f9884359 search: check for non-resource permissions when authorizing results
Now that we can differentiate between ResourcePermissions and other
kinds of permissions, we can skip authorizing result-by-result
when the permission for a given document type is not a
ResourcePermission.

Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2022-03-23 15:58:42 -04:00
Mike Lewis 9cbb270aef permissions: add a discriminator type to Permission
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2022-03-22 14:32:38 -04:00
github-actions[bot] ad955c1b1b Version Packages (next) 2022-03-22 12:28:03 +00:00
Mike Lewis 94ccd772d4 search-backend: filter out authorization property in api responses
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2022-03-17 12:39:42 +00:00
Mike Lewis a0fbae7aeb search-backend: use new IndexableResultSet type as return type of engine#query
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2022-03-17 12:39:42 +00:00
github-actions[bot] 0bc1611d6e Version Packages 2022-03-17 09:02:30 +00:00
github-actions[bot] b6d947b67f Version Packages 2022-03-10 11:30:23 +00:00
github-actions[bot] 1693f2dc74 Version Packages (next) 2022-03-09 16:09:04 +00:00
Patrik Oldsberg 1f87e8a376 Merge pull request #10037 from backstage/rugvip/role-lint
cli: introduce role-based lint configuration setup
2022-03-08 09:27:19 +01:00
Patrik Oldsberg 09b37063f2 packages,plugins: migrate to new lint config
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2022-03-07 14:53:43 +01:00
blam bf231ecc7f chore: updating api-report
Signed-off-by: blam <ben@blam.sh>
2022-03-07 10:15:54 +00:00
Eric Peterson 3e54f6c436 Use @backstage/plugin-search-common instead of @backstage/search-common
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-03-04 18:47:55 +01:00
github-actions[bot] 3c8bb2854d Version Packages 2022-03-03 15:23:53 +00:00
Eric Peterson 37b9ff3b19 Update AuthorizedSearchEngine for stream-based indexing.
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-03-02 17:29:18 +01:00
Eric Peterson 804c7906cf Update core search types to be stream-based
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-03-02 17:26:56 +01:00
github-actions[bot] c9da151d84 Version Packages 2022-02-24 13:54:37 +00:00
Patrik Oldsberg ba68ea4450 apply 0.68.1 fixes to master
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2022-02-18 11:30:15 +01:00
github-actions[bot] 408b0300cb Version Packages 2022-02-17 10:38:59 +00:00
Patrik Oldsberg 9892d74326 cli: renamed script commands to package
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2022-02-15 21:27:12 +01:00
Patrik Oldsberg 8f82d80adf migrate all package scripts
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2022-02-14 21:50:07 +01:00
Patrik Oldsberg bb5fcc3209 update all plugin package roles
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2022-02-14 21:50:05 +01:00
Patrik Oldsberg b521c1b83b detect all package roles
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2022-02-14 21:50:03 +01:00
github-actions[bot] e4791789d1 Version Packages 2022-02-10 11:06:33 +00:00
Fredrik Adelöw b3f3e42036 move IdentityClient.getBearerToken
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2022-02-09 10:38:12 +01:00
github-actions[bot] e74f416a00 Version Packages (next) 2022-02-08 19:38:17 +00:00
github-actions[bot] a12bb7b065 Version Packages 2022-02-03 09:42:25 +00:00
github-actions[bot] 51eecb3f03 Version Packages (next) 2022-02-02 14:28:47 +00:00
github-actions[bot] e1580cf73a Version Packages (next) 2022-02-01 08:53:29 +00:00
github-actions[bot] 406848efee Version Packages 2022-01-27 11:07:27 +00:00
MT Lewis af4864b462 search-backend: deduplicate authorize calls
Signed-off-by: MT Lewis <mtlewis@users.noreply.github.com>
2022-01-26 19:38:01 +00:00
Vincenzo Scamporlino 9f394b231c Remove unused type
Signed-off-by: Vincenzo Scamporlino <me@vinzscam.dev>
2022-01-25 16:31:29 +01:00
Vincenzo Scamporlino 074f36cc43 Import DocumentTypeInfo from common
Signed-off-by: Vincenzo Scamporlino <me@vinzscam.dev>
2022-01-25 16:27:02 +01:00
Vincenzo Scamporlino 43f9d00c1e Add result-by-result filtering pagination test
Signed-off-by: Vincenzo Scamporlino <me@vinzscam.dev>
2022-01-25 16:27:02 +01:00
Vincenzo Scamporlino 77cbb31883 Fix comments
Signed-off-by: Vincenzo Scamporlino <me@vinzscam.dev>
2022-01-25 16:27:02 +01:00
Vincenzo Scamporlino e73ad9c89a Add AuthorizedSearchEngine tests
Signed-off-by: Vincenzo Scamporlino <me@vinzscam.dev>
2022-01-25 16:27:02 +01:00
MT Lewis c7ce3076d9 search-backend: skip result-by-result filtering when possible
Signed-off-by: MT Lewis <mtlewis@users.noreply.github.com>
2022-01-25 14:35:37 +00:00
Vincenzo Scamporlino 12b9fb8b34 search-backend: initialize variable rather than declaring type
Signed-off-by: MT Lewis <mtlewis@users.noreply.github.com>
2022-01-25 13:01:41 +00:00
Vincenzo Scamporlino bdbacb3b9c search-backend: handle missing type configuration in AuthorizedSearchEngine
The search-backend router ensures that all requested types are
configured, but since we don't know how this search engine will
be used, it's good to properly handle the case where an
unconfigured type is supplied.

Signed-off-by: MT Lewis <mtlewis@users.noreply.github.com>
2022-01-25 13:01:41 +00:00
Vincenzo Scamporlino 32e4645930 search-backend: validate page cursor when decoding
Signed-off-by: MT Lewis <mtlewis@users.noreply.github.com>
2022-01-25 13:01:41 +00:00
MT Lewis 634abc1a41 search: move DocumentTypeInfo to search-common
Signed-off-by: MT Lewis <mtlewis@users.noreply.github.com>
2022-01-25 13:01:40 +00:00
MT Lewis bbfbc755aa [wip] search-backend: result-by-result authorization
To do:
- add tests for AuthorizedSearchEngine
- update router tests
- add diff to changeset

Signed-off-by: MT Lewis <mtlewis@users.noreply.github.com>
2022-01-25 13:01:39 +00:00
MT Lewis 7da1b7c42a search-backend: add optional latency budget for authorized search backend
Signed-off-by: MT Lewis <mtlewis@users.noreply.github.com>
2022-01-25 13:01:39 +00:00
github-actions[bot] 8b18d054f3 Version Packages 2022-01-20 10:33:31 +00:00
MT Lewis cd6854046e search-backend: validate query string
Ensures that known query params accepted by the search endpoint have
the correct type after parsing

Signed-off-by: MT Lewis <mtlewis@users.noreply.github.com>
2022-01-18 16:53:22 +00:00
github-actions[bot] a94a2b8b3f Version Packages (next) 2022-01-18 13:49:07 +00:00
github-actions[bot] b04011602b Version Packages 2022-01-13 14:23:13 +00:00
github-actions[bot] 3d68c45ef7 Version Packages 2021-12-23 12:23:34 +00:00