Commit Graph

737 Commits

Author SHA1 Message Date
blam 90f253aaf8 feat(catalog/star): Ability to star items in the catalog table 2020-06-09 15:20:38 +02:00
Fredrik Adelöw 709cc4004d feat(backend-common): add common code for service shell 2020-06-09 15:10:37 +02:00
Sebastian Qvarfordt 1b4327c9d6 Merge pull request #1213 from hooloovooo/move-edit-metadata-button
Moved edit button in catalog to actions menu
2020-06-09 14:58:19 +02:00
Patrik Oldsberg c53bafc5f9 v0.1.1-alpha.7 2020-06-09 14:24:56 +02:00
Sebastian Qvarfordt 40e95c06a8 Moved edit button in catalog to actions menu 2020-06-09 14:21:30 +02:00
Ben Lambert 00d33f93e4 Enable Filtering of the Catalog Page (#1143)
* feat(catalog/Filters): Add ability to render a React component as the count. Good for loading states and async data rendering for counts.

* chore(Catalog/filters): Updating the table so that we use loading states of the table rather than the panel

* chore(Catalog/filters): added some nice things for enabling the filtering with some nice count componeents

* feat(Catalog/filters): Fetch the correct data and added in enum types to make some nice resolvers

* chore(Catalog/filters): Use the new enum type here

* chore(Catalog/filters): Removing the unused import to fix lintig

* chore(Catalog/filters): Addressing some PR comments

* feat(catalog/filters): Making WebStorage return the same instance for the same bucket for subscriptions

* chore(core/Storage): fixing some issues with different instances of the storage and adding tests for it

* chore(catalog/filters): fixing some tests and trying to remove some of the act warnings in the tests
2020-06-09 13:28:40 +02:00
Fredrik Adelöw 4d7b28e89c Merge pull request #1199 from spotify/freben/unregister
Unbreak the unregister dialog after catalog changes
2020-06-09 10:33:15 +02:00
Fredrik Adelöw e2dc24d237 Remove final DOM nesting warning 2020-06-09 10:26:37 +02:00
Fredrik Adelöw 5f56f981b5 Unbreak the unregister dialog after catalog changes 2020-06-09 10:18:38 +02:00
Marcus Eide e9a2444c9a Documentation: Add guide for how to add an auth provider to the backend (#1145)
* Add guide for how to add a auth provider to the backend

* Move to new docs folder and small corrections

* Split oauth and non-oauth use-cases up and add more info about the verifyFunc

* Move summary to top and add note about non-oauth providers being experimental
2020-06-09 09:39:27 +02:00
Stefan Ålund 920f496a7f Use service theme (#1197)
* Use service theme

* Theme spacing

* breadcrumbs
2020-06-08 20:45:26 +02:00
Benjamin Rowell 056c794451 Make DismissibleBanner persistently dismissed #1153 (#1168)
* Enables DismissableBanner instance in localstorage

When dismissed, a string representation of the DismissableBanner
is sent to localstorage using the storageapi, to allow persistance in
a user session.

* Adds tests and cleans up DismissableBanner changes

DismissbleBanner now has an id prop. This prop is used when
adding a dismissed banner instance to web storage.

The namespace dismissed banners are added to is now set to
"notifications".

Removed refrences to old settings.

Added a test to check web storage functionality.

Updates CatalogPage to add id prop.

Updates CatalogPage test to ensure storageApiRef is valid.

* Updates DismissableBanner stories to include id.

* Adds ApiProvider to DismissableBanner stories.

* Trigger CI

* Removed jest calls and replaced with ErrorApi.

* Updates imports to @backstage/core
2020-06-08 20:16:51 +02:00
Patrik Oldsberg 076409a7b3 Merge pull request #1146 from spotify/rugvip/main
packages/cli: use publishConfig for publish config
2020-06-08 15:50:52 +02:00
Fredrik Adelöw 74ad89f8e3 Merge pull request #1158 from spotify/freben/location-processors-3
RFC: Improve the way that locations are read
2020-06-08 15:07:29 +02:00
Stefan Ålund 23c57bd1a3 Minor tweaks to catalog UI (#1176)
* Minor tweaks to catalog UI

* Review feedback

* Use styles instead
2020-06-08 11:58:44 +02:00
Patrik Oldsberg 9a1b363812 plugins/tech-radar: fix lint issue in RadarBubble 2020-06-08 11:12:15 +02:00
Sebastian Qvarfordt a6d44d18a4 Merge branch 'master' of github.com:spotify/backstage into catalog-edit-link 2020-06-08 09:51:31 +02:00
Nathan Calvank 42130988fe Issue 661 Tech Radar Typescript refactor (#1080)
* Refactor RadarFooter

* Refactor RadarLegend Pt 1

* Refactor RadarLegend Pt 2

Seeing some errors that I don't fully understand around the proptypes
assertions seemingly being treated as null | undefined values.

It looks like I'll need to type Segment, which is not explicitly
in-scope for this issue.

* Fix segments regression

I incorrectly added type safety to the original implementation, causing
the segments to no longer be populated here. This change fixes that
regression while retaining the type safety.

This is all necessary because qidx and ridx are apparently both
nullable.

* Resolve remaining RadarLegend warnings

* Refactor RadarEntry

* Forcibly skip hooks to revert migration prettify

* Refactor RadarGrid

* Refactor RadarPlot & Best effort with PropTypes

A global search looks like no other plugins use PropTypes. I'm about to
remove them in the next commit because shapes don't seem to cooperate
with TypeScript, making the PropTypes either so vague that they're
mostly useless or specific enough to fail the build.

With that said, I wanted to get this version committed in case I need to
roll back to here. I wouldn't want to redo this work.

* Remove PropTypes from refactored components

The build now passes.

* Refactor RadarBubble

* Refactor Radar

* Move Radar functions out of component file

I could see these being split into separate files, but I think this is
enough for now.

* Small function signature change

* Align types

I'm not confident in this change. I'm very unclear about the reasoning
behind the type definitions in api.ts as they don't reflect the shape of
the values that I see when I print `data.entries` in the console.

The value of data.entries reflects a fully-populated Entry[], not a
RadarEntry[].

As such, I'm also not sure about the sample data. I would be more
hesitant to updated it, but the fact that the rest of the components
seem to be expecting that data makes it seem fairly clear that it must
be required to be in the updated shape.
2020-06-08 09:13:03 +02:00
Fredrik Adelöw 9f02cf4a30 LocationProcessorSink -> LocationProcessorEmit 2020-06-08 07:14:16 +02:00
blam fada5ab4b0 chore(react-router-v6): Tidying up some more components and moving across to the new API 2020-06-07 14:54:34 +02:00
blam 13f8846889 chore(react-router-v6): Fixing some more subrouting in the catalog page 2020-06-07 14:27:39 +02:00
blam 4fdb1def39 chore(react-router-v6): starting to move things to react-router-v6 2020-06-07 03:07:46 +02:00
Fredrik Adelöw e19a93ee55 Get rid of the generators 2020-06-06 23:50:09 +02:00
Fredrik Adelöw 61a02be0f4 Add logging and fix last bug 2020-06-06 22:11:42 +02:00
Fredrik Adelöw d68e4f2bd0 Switch to using generators 2020-06-06 22:11:42 +02:00
Fredrik Adelöw fe16d8ee8d chore(catalog-backend): make LocationReader, that runs a chain of processors 2020-06-06 22:09:32 +02:00
Stefan Ålund ec4aa3d59f Change example component names (#1165) 2020-06-06 17:03:52 +02:00
blam 40b07d521b chore(Catalog/Tabs): remove extraneous file from otber branch 2020-06-06 15:07:41 +02:00
blam b08c5919f4 Merge branch 'master' of github.com:spotify/backstage into sebastianq/component-navigation
* 'master' of github.com:spotify/backstage:
  packages/cli: avoid duplicate dependency warning in E2E test
  build(deps): [security] bump websocket-extensions from 0.1.3 to 0.1.4
  fix: import from package
  fix: type checking
  fix: tests
  Ran yarn install
  fix: show list of components in removal dialog
  fix: github actions
  fix: make locations fetching work
  feature: extract getLocationById method, wrap location fetching in useAsync
2020-06-06 14:54:24 +02:00
blam 72a7c73e9f feat(Catalog/tabs): added some sample tabs for now 2020-06-05 17:40:24 +02:00
Sebastian Qvarfordt 8742e85eb7 Added HeaderTabs to ComponentPage 2020-06-05 16:54:36 +02:00
Nikita Nek Dudnik 2744a98ac5 fix: import from package 2020-06-05 16:40:27 +02:00
Nikita Nek Dudnik a4f08e3fcc fix: type checking 2020-06-05 16:29:46 +02:00
Nikita Nek Dudnik 48a71d6300 fix: tests 2020-06-05 16:22:44 +02:00
Nikita Nek Dudnik e2c6864055 Merge remote-tracking branch 'origin' into ndudnik/unregister-component 2020-06-05 14:57:16 +02:00
Nikita Nek Dudnik ed3a404de0 fix: show list of components in removal dialog 2020-06-05 14:23:44 +02:00
Nikita Nek Dudnik 10980727a7 fix: github actions 2020-06-05 14:14:07 +02:00
blam 241dc49797 chore(Catalog/Navigation): Added some basic tabs to the subheader grid area 2020-06-05 14:05:01 +02:00
Sebastian Qvarfordt bcb50c9325 Different edit links depending on type. Only github for now though. 2020-06-05 12:53:16 +02:00
Ivan Shmidt 2ba33db74d Fix tests 2020-06-05 12:22:07 +02:00
Sebastian Qvarfordt c655a133a3 Slightly more robust edit link creation 2020-06-05 12:09:07 +02:00
Ivan Shmidt 63b1193cb8 /catalog/:namespace?/:kind/:name/ 2020-06-05 12:04:07 +02:00
Nikita Nek Dudnik 29f7f1c333 fix: make locations fetching work 2020-06-05 11:55:08 +02:00
Patrik Oldsberg e396996792 Merge pull request #1140 from spotify/auth-frontend-state
Auth frontend state
2020-06-05 11:48:16 +02:00
Nikita Nek Dudnik e1477fa635 feature: extract getLocationById method, wrap location fetching in useAsync 2020-06-05 11:36:52 +02:00
Sebastian Qvarfordt 78f5e50761 Merge branch 'master' of github.com:spotify/backstage into catalog-edit-link 2020-06-05 11:08:03 +02:00
Sebastian Qvarfordt 2f474224b0 Replace blob with edit in link 2020-06-05 11:03:30 +02:00
Patrik Oldsberg 0d1655c65b packages,plugins: use publishConfig to configure published entrypoints 2020-06-04 18:01:15 +02:00
Ivan Shmidt f0a95a9762 Fix types 2020-06-04 17:15:58 +02:00
Ivan Shmidt 82143b1d10 Merge branch 'master' of github.com:spotify/backstage into mob/register-unregister-components 2020-06-04 17:09:15 +02:00