Commit Graph

1293 Commits

Author SHA1 Message Date
Govindarajan Nagarajan 3e5dfbc5f6 Refactor: move encoding state parameters into a separate function 2020-08-03 17:42:48 +02:00
Govindarajan Nagarajan 081fe60453 Refactor: parse state query param to read nonce
The `state` was modified to be an encoded object of `nonce` and `env`.
When verifying the Nonce value in the callback from the authorization
server, parse the state parameter string to read the right value of
nonce
2020-08-03 15:53:22 +02:00
Govindarajan Nagarajan 685f76d913 Encode env in OAuth flow into the state parameter. refs #1775
`Env` passed as a separate parameter in the request might break the flow
of the authorization flow. Spotify considers the `env` as a first class
abstraction and use it across their application stack.
To ensure both the existing flow and newer flows are supported, use the
`state` parameter to encode an object, consisting of the `nonce` and the
`env` which is then passed to the authorization server. This parameter
is returned to the application in the callbackURL
2020-08-03 15:33:32 +02:00
Patrik Oldsberg 650830cf4f plugins/graphql: fix schema packaging 2020-08-02 19:29:21 +02:00
Patrik Oldsberg d4a50e82c5 Merge pull request #1762 from spotify/shmidt-i/github-actions-widget-redone
feat(github-actions): widget inside catalog
2020-07-31 09:33:21 +02:00
Sebastian Qvarfordt fe4430907a Merge pull request #1787 from DavidJSykes/Fix-TechDocs-missing
Fix tech docs missing #1750
2020-07-30 19:32:45 +02:00
Patrik Oldsberg e68e174c3b plugins/graphql: fix main field in publish config 2020-07-30 18:24:35 +02:00
David J Sykes cc905069d1 Changed optional parameter name to allow for more generic uses 2020-07-30 16:57:38 +01:00
Patrik Oldsberg f1b96fe8ef Merge pull request #1783 from AmericanAirlines/ghe
Add configuration for github enterprise
2020-07-30 17:19:38 +02:00
Patrik Oldsberg 64239b9bb3 Merge pull request #1789 from GoWind/remove-scope-check
(auth-backend) Bugfix: Do not throw Exception if scopes dont exist. Refs #1786
2020-07-30 17:17:16 +02:00
Paul Pacheco b625b19978 use cammel case 2020-07-30 09:50:08 -05:00
Sebastian Qvarfordt eea54c55b0 Merge pull request #1782 from twishasaraiya/techdocs/docs-header
techdocs: modify documentation header
2020-07-30 16:48:18 +02:00
Paul Pacheco 5cde7069cf Pass github enterprise base url, derive urls for authentication 2020-07-30 09:33:12 -05:00
Govindarajan Nagarajan 448767712b (auth-backend) Bugfix: Do not throw Exception if scopes dont exist. Refs #1786
Currently, the OAuthProvider library in `auth-backend` throws an
Exception if scopes are missing in the `start` (initial) request
in the Authorization flow. Scopes are an optional parameter as per the
spec, so if scopes are empty, simply forward the empty scopes instead of
throwing an Exception
2020-07-30 15:16:54 +02:00
Patrik Oldsberg 54610c9ba4 auth-backend: set SameSite=Lax for oauth flow cookies 2020-07-30 12:37:02 +02:00
David Sykes 58fa8ce5fb Updated test 2020-07-30 11:35:01 +01:00
David Sykes 4f54f062fe Updated test 2020-07-30 11:31:26 +01:00
David Sykes ea57820c62 Removed a div that was no longer needed 2020-07-30 11:30:01 +01:00
David Sykes fa708d6572 TechDocsNotFound now uses ErrorPage from core with an optional docPath parameter 2020-07-30 11:19:12 +01:00
Paul Pacheco c0feeecc29 Add documentation 2020-07-30 04:53:35 -05:00
Paul Pacheco c485f7375e Add configuration for github enterprise 2020-07-30 04:43:02 -05:00
Twisha Saraiya 5749c98e3f techdocs: modify documentation header 2020-07-30 14:45:21 +05:30
Patrik Oldsberg dc6d2db444 catalog-backend: move template mock-data call to scaffolder-backend 2020-07-29 16:22:30 +02:00
Ivan Shmidt 7248e9a581 feat(github-actions): widget inside catalog 2020-07-28 11:29:27 +02:00
Nikita Dudnik 6b062a753e Merge branch 'master' into ndudnik/github-actions-annotation 2020-07-28 09:35:15 +02:00
Nikita Nek Dudnik f7ecc32765 fix: annotation name 2020-07-28 09:28:57 +02:00
Patrik Oldsberg c94dc3dca0 Merge pull request #1757 from spotify/rugvip/typefix
yarn.lock,cli: bump failing type deps + run tsc after plugin creation in e2e test
2020-07-27 17:24:36 +02:00
Patrik Oldsberg 6a50e6c103 Merge pull request #1732 from spotify/dependabot/npm_and_yarn/types/jest-26.0.7
chore(deps-dev): bump @types/jest from 25.2.3 to 26.0.7
2020-07-27 16:23:07 +02:00
Ivan Shmidt 6edbb0c732 Merge pull request #1726 from spotify/shmidt-i/create-app-backend
Create app backend with PG support & E2E Test
2020-07-27 16:22:06 +02:00
Patrik Oldsberg 1baccd1304 deps: bump ts, express + friends and fix type issue 2020-07-27 16:06:11 +02:00
Marcus Eide d3541f292e Merge pull request #1723 from Fox32/url-reader-processor
feat: add UrlReaderProcessor to consume entities from a simple URL
2020-07-27 15:19:57 +02:00
Ivan Shmidt 3f046ed0e3 Merge branch 'master' of github.com:spotify/backstage into shmidt-i/create-app-backend 2020-07-27 14:40:57 +02:00
Raghunandan Balachandran 63dbc49f3e Merge pull request #1680 from spotify/configurable-auth-providers
Read auth providers from app-config yaml
2020-07-27 13:33:40 +02:00
Marcus Eide 6b4ef4c1ce Merge pull request #1721 from forrestwaters/gitlab_private
Add ingestor for private gitlab repositories
2020-07-27 13:32:27 +02:00
ellieseastream f38a35d6ba Merge pull request #1720 from spotify/sebastianq/techdocs-in-entity
TechDocs in entitiy model example
2020-07-27 13:27:25 +02:00
Nikita Dudnik 79859a6a88 Merge pull request #1696 from spotify/ndudnik/github-actions-build-details
feat: github actions details view
2020-07-27 12:41:09 +02:00
Nikita Nek Dudnik 504358df5a docs: add documentation 2020-07-27 11:42:23 +02:00
Nikita Nek Dudnik ab6dfa3aa2 feat: add github icon and more descriptive text 2020-07-27 10:42:06 +02:00
blam 1222db0e1b Merge branch 'master' of github.com:spotify/backstage into blam/gql
* 'master' of github.com:spotify/backstage:
  fix(techdocs-not-found): bug fix
  images have extension jpg or jpeg, not jpe (#1742)
2020-07-27 10:13:24 +02:00
Emma Indal 166998b6d9 fix(techdocs-not-found): bug fix 2020-07-27 09:17:00 +02:00
Raghunandan 19071023cd fix type issues 2020-07-27 09:07:27 +02:00
Raghunandan 60d3ecc695 Read auth providers in backend and frontend from app-config yaml 2020-07-27 09:07:25 +02:00
Ben Lambert 8777cb95ed Update package.json 2020-07-26 03:37:52 +02:00
Ben Lambert 1009c4e05d Merge branch 'master' into blam/gql 2020-07-26 03:36:48 +02:00
Nikita Nek Dudnik b94a1b3cff fix: add missing files 2020-07-24 16:19:48 +02:00
Nikita Nek Dudnik c31b0e9049 chore: remove obsolete library 2020-07-24 15:57:32 +02:00
Nikita Nek Dudnik c82c045ee8 feat(github-actions): add a separate data mock 2020-07-24 15:56:48 +02:00
Nikita Nek Dudnik 25e41d2274 feat: use annotation to get project name 2020-07-24 14:10:21 +02:00
Nikita Nek Dudnik 9bdb010432 Merge 2020-07-24 14:10:21 +02:00
Nikita Nek Dudnik b4e8a798b6 fix: PR comments 2020-07-24 14:09:23 +02:00