Commit Graph

259 Commits

Author SHA1 Message Date
Himanshu Mishra 380dd626fb Safe nullish check with git-url-parse library responses 2021-01-18 23:04:31 +01:00
Himanshu Mishra baeed36324 Convert NotModifiedError to 304 HTTP status code 2021-01-18 22:59:36 +01:00
Himanshu Mishra 8565ad2279 1. Use etag over sha for the identifier
2. Re-combine Resonse types into one
2021-01-18 22:52:45 +01:00
Himanshu Mishra 79f9a97428 backend-common: UrlReader/Azure implement SHA based caching 2021-01-18 21:55:55 +01:00
Himanshu Mishra 7078d35e0a backend-common: UrlReader/Bitbucket implement SHA based caching
Default branch detection was already implemented
2021-01-18 21:55:54 +01:00
Himanshu Mishra f9ca2a3769 backend-common: UrlReader/GitLab implement Sha based caching
Also use API to fetch archive.zip
2021-01-18 21:54:48 +01:00
Himanshu Mishra 2305296073 backend-common: Support SHA based caching in URL Reader's readTree
readTree now takes a SHA in options, and throws a NotModifiedError if the SHA matches with the latest commit SHA on the tree. readTree response now contains a new 'sha' parameter.

Also, the default branch will now be used if no branch is provided in the url's target
2021-01-18 21:53:49 +01:00
Patrik Oldsberg 4211198c30 Merge pull request #4128 from backstage/rugvip/fetch
backend-common: lock down UrlReader to only read from allowed URLs
2021-01-18 18:53:19 +01:00
Patrik Oldsberg 6458dfeb14 Merge pull request #3886 from backstage/rugvip/nohttps
backend-common: remove deprecated HTTPS config
2021-01-18 17:47:04 +01:00
Fredrik Adelöw ba59fb6e1d Merge pull request #4100 from backstage/freben/parseGitUrl
chore: consistent naming of parseGitUrl
2021-01-18 14:34:34 +01:00
Patrik Oldsberg a283dcc43b backend-common: include port in url reader allow list check 2021-01-18 14:21:34 +01:00
Patrik Oldsberg 5345a1f983 backend-common: lock down UrlReader to only read from allowed URLs 2021-01-18 14:17:04 +01:00
Fredrik Adelöw 0b4b755b91 chore: consistent naming of parseGitUrl 2021-01-18 13:37:47 +01:00
Johan Haals 5618ffa733 Merge pull request #4058 from backstage/mob/github-app-manager
Add GithubCredentialsProvider for start of GitHub Apps support
2021-01-18 08:10:26 +01:00
Johan Haals ed82e83a84 Add GitHubUrlReader test using CredentialsProvider
Co-authored-by: blam <ben@blam.sh>
2021-01-14 14:42:48 +01:00
github-actions[bot] be332e13ea Version Packages 2021-01-14 13:05:31 +00:00
Johan Haals 04ad29ca4e Make GithubUrlReader use GithubCredentialsProvider
Co-authored-by: Fredrik Adelöw <freben@users.noreply.github.com>
2021-01-14 13:53:47 +01:00
github-actions[bot] 28d7f319f4 Version Packages 2021-01-07 10:31:20 +00:00
Oliver Sand 49d3aa1622 Remove unnecessary dev dependencies 2021-01-06 16:13:54 +01:00
Patrik Oldsberg fb745571bc Merge pull request #3902 from backstage/rugvip/optional
backend-common: fix for backend.https being required
2021-01-04 11:49:18 +01:00
Patrik Oldsberg 5640f1cd9d backend-common: fix for backend.https being required 2021-01-04 11:35:13 +01:00
dependabot[bot] 78f201c796 chore(deps-dev): bump @types/archiver from 3.1.1 to 5.1.0
Bumps [@types/archiver](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/archiver) from 3.1.1 to 5.1.0.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/archiver)

Signed-off-by: dependabot[bot] <support@github.com>
2020-12-31 04:47:57 +00:00
Patrik Oldsberg 09a3704264 backend-common: remove deprecated HTTPS config 2020-12-30 13:52:48 +01:00
Patrik Oldsberg 9db9bc878f backend-common: cache generated HTTPS certificates 2020-12-30 12:57:29 +01:00
Patrik Oldsberg 751f58ff7c backend-common: replace generated cert params with a simple bool switch, and fix certificate generation 2020-12-30 12:57:29 +01:00
Omer Farooq 3f7bfe7b11 remove url check to support on-prem ADO 2020-12-30 13:11:35 +13:00
Ben Lambert 2c36df1ee7 Merge pull request #3805 from backstage/blam/isomorphic-git
Remove the NodeGit Dependency in favour of isomorphic-git
2020-12-29 14:46:35 +01:00
blam 28bdc0328c chore: rework types slightly for string or undefined instead of void 2020-12-29 14:26:28 +01:00
blam 82469a5d5a chore: explicitly set the types returned from the functions 2020-12-29 14:13:07 +01:00
blam 8bccc6bec0 chore: refactor variable names for isomorphic git. 2020-12-29 13:32:24 +01:00
blam 610b3a205a chore: try to fix the alignment 2020-12-29 11:54:30 +01:00
Patrik Oldsberg 0829ff1269 backend-common: include extra fields on dev log formatter 2020-12-29 11:52:46 +01:00
blam ba6f2b8a40 chore: reworking the API exports and fixing the logging to be a little less verbose 2020-12-29 11:46:36 +01:00
blam 5118cb472f test(backend-common/git): Adding tests for all the git helpers in backend common 2020-12-28 16:16:18 +01:00
Himanshu Mishra cb28e1a6a0 chore(git): Need author and commiter for doing git merge 2020-12-23 00:34:12 +01:00
Himanshu Mishra 9ca586e579 techdocs: Replace nodegit with isomorphic-git
TechDocs needs 4 functions from the git library
1. To clone 2. To get the commit timestamp for HEAD 3. To fetch 4. To merge two branches

Created necessary commands in the new SCM client and reordered them alphabetically for convenience
2020-12-23 00:12:20 +01:00
blam 3727e3b367 feat: update all preparers to use isomorphic git 2020-12-22 13:00:36 +01:00
blam ff0f7f89a2 Merge branch 'master' of github.com:backstage/backstage into blam/isomorphic-git
* 'master' of github.com:backstage/backstage: (269 commits)
  address comments
  catalog-backend: flesh out and tweak the config schema
  Update chilled-pigs-destroy.md
  catalog-backend: start warning about usage of deprecated location types
  scripts: add script for migrating away from deprecated location types
  chore: fixing changeset prettyness
  Create good-hairs-sniff.md
  Update IconLinkVertical.tsx
  Update violet-sloths-reply.md
  Delete fuzzy-windows-cry.md
  Create violet-sloths-reply.md
  Added changeset
  build(deps): bump archiver from 5.0.2 to 5.1.0
  build(deps): bump typescript-json-schema from 0.45.0 to 0.45.1
  docs: Update lighthouse docs
  fix(app): listen to app.listen.host
  scaffolder-backend: clarify type detection error message
  docs: Update techdocs architecture features status
  scaffolder-backend: gitlab preparer uses integrations token
  core-api: ensure that routable extension components are discovered at boot
  ...
2020-12-21 16:31:15 +01:00
blam 54a19d4444 feat: move all publishers over to the backend common way to interact with git scm 2020-12-21 16:05:24 +01:00
blam d0a972eb63 chore: reworking how we deal with exporting things from the main package 2020-12-21 16:05:10 +01:00
blam 70ceab3db4 feat: adding in all the functions needed for isomorphic git feature 2020-12-21 15:38:53 +01:00
Fredrik Adelöw e3dc3e40cf Merge pull request #3767 from backstage/bug/csp
Updating CSP for unsafe eval
2020-12-18 13:58:49 +01:00
github-actions[bot] 6e9f4d4a15 Version Packages 2020-12-17 10:16:33 +00:00
blam e2beaf5940 chore: create scm from auth 2020-12-17 10:18:52 +01:00
blam 90f22cc2db chore: when serving with app-backend, the frontend needs unsafe-eval for the patterns in react-jsonschema-form or ajv validation 2020-12-17 01:29:51 +01:00
mateiidavid 47930a36f7 Implement readTree for GitlabReader (#3547)
* This change adds an implementation for the readTree method in GitlabReader.
The implementation is similar to the readTree method in GithubReader
with the exception of the 'path' variable used for subpaths in the
archive. To facilitate this, GitlabIntegrationConfig now has an apiUrl
field which was missing for Gitlab but was present for Bitbucket & GH.

* As part of this change, there are also new tests added to GitlabReader
to mirror what has been done with the GH reader. For now the archive
format chosen is 'zip', follow-up action includes having a look at
whether tar.gz is preferable.

Signed-off-by: Matei David <madavid@expediagroup.com>
2020-12-16 14:13:54 +00:00
Patrik Oldsberg 1da7d2c657 plugins,packages: replace usages of ConfigReader.from 2020-12-15 19:04:50 +01:00
blam 3546862399 chore: update git-url-parse dependency 2020-12-15 13:22:17 +01:00
Kim S. Ly bbd0e354ff Implement readTree on BitBucketUrlReader - Add getBitbucketDefaultBranch 2020-12-15 01:04:16 -05:00
Kim S. Ly 58b3bbe4e8 Implement readTree on BitBucketUrlReader - Implement getBitbucketDownloadUrl and remove hash for Bitbucket Server 2020-12-15 01:01:56 -05:00