Commit Graph

3803 Commits

Author SHA1 Message Date
ebarrios 36a4ede275 Change error message in the publish func for when the credentials provider can not get a token 2021-02-16 19:56:18 +01:00
ebarrios cc2c047f15 Reverted change to preparer function to use Git.fromAuth({ logger }) when the credentials provider can not get a token 2021-02-16 19:50:56 +01:00
ebarrios fdd33af1cf Added githubApp authentication for the scaffolder prepare stage 2021-02-16 15:10:00 +01:00
ebarrios 3fc738a55c modify change set to path, simplify to one expresion the check for config.token and config.apps and deconstructed the response fron the credentialProvider.getCredentials function 2021-02-16 12:58:15 +01:00
ebarrios 3a15d2941e Addresed all coments from Rugvip to remove all mutable objects from the fromConfig function 2021-02-16 10:18:14 +01:00
Esteban Barrios bff1b1c4ad Merge branch 'master' into added-githubapp-authentication-to-scaffolder 2021-02-15 23:25:38 +01:00
Patrik Oldsberg 49299a1faf Merge pull request #4541 from backstage/rugvip/gh-auth
integrations: switch to using x-access-token for github git auth
2021-02-15 21:16:02 +01:00
Patrik Oldsberg fb28da2123 integrations: switch to using x-access-token for github git auth 2021-02-15 20:27:26 +01:00
Patrik Oldsberg d31228eb42 Merge pull request #4531 from backstage/rugvip/authref
auth-backend: refactor providers to accept options, and delay profile transforms
2021-02-15 19:44:13 +01:00
Patrik Oldsberg 2046701e96 auth-backend: fix a camel 2021-02-15 17:26:51 +01:00
Patrik Oldsberg f781754643 auth-backend: move @types/passport to deps 2021-02-15 17:26:24 +01:00
ebarrios 18ed99c0e5 Used credentialsProvider as to determine which kind of authentication is going to be used instead of adding an accessType top the GitHubIntegrationConfig 2021-02-15 14:45:40 +01:00
Patrik Oldsberg 3ec9c76ce2 Merge pull request #4530 from backstage/rugvip/datefix
auth-backend: fix key timestamp parsing with sqlite
2021-02-15 13:13:37 +01:00
ebarrios 7a4d468d97 Used GithubCredentialsProvider as requested by benjdlambert in the pr comments 2021-02-15 11:53:38 +01:00
Oliver Sand 32a9504095 Hide the kind of the owner if it's the default kind for the ownedBy relationship (group).
I guess I missed this one. In the catalog table & co we already hide it.

Signed-off-by: Oliver Sand oliver.sand@sda-se.com
2021-02-15 11:34:51 +01:00
Patrik Oldsberg d9687c524f auth-backend: fix key timestamp parsing with sqlite 2021-02-14 20:00:21 +01:00
Patrik Oldsberg 65fa16dee4 auth-backend: refactor profile transform to happen within handlers instead of verify callback 2021-02-14 17:38:07 +01:00
Patrik Oldsberg b9709efff8 auth-backend: refactor user profile fetch to transform profile outside 2021-02-13 17:42:14 +01:00
blam 3957c024f5 chore: renaming to use targetPath rather than templatePath like the rest of the preparers 2021-02-12 22:54:20 +01:00
blam d84df12d3b bug: fixing the input path to the FilePreparer, and fixing the destination directory for the preparer to template 2021-02-12 22:48:57 +01:00
ebarrios 808153c0f7 Added GithubApp authentication to the scaffolder plugin 2021-02-12 16:18:30 +01:00
Esteban Barrios 8f53351a32 Rebase from master (#19)
* Fix client reference

* Fix CatalogClient reference in create-app too

* Move catalog-client dep to create-app

* Add catalog-client dep again..

* Use RequestOptions

* tsc

* Backwards compatible scaffolder

* Fix test

* Avoid importing core

* Use request options

* Increase code coverage

* Type those variables

* use the second mock

* Trying to make tests work on Github too

* Get clean yarn from master

* Only add authorization header if token exists

* Use request options

* Forward authorization header token

* Refactor to use context argument

* Allow the registration of optional locations via the catalog-client

* Make EntityRefLink a React.forwardRef in order to use it as root component in other components like ListItem

* Rework the user flow of the catalog-import plugin

* Update the create-app template

* Add luxon and remove moment

* Port moment to luxon

* Add change set

* Split the step label and content to be able to refactor the stepper from vertical to horizontal in the future

* Fix tsc, prettier and import issues

* Update .changeset/strange-olives-unite.md

Co-authored-by: Himanshu Mishra <himanshu@orkohunter.net>

* Update plugins/auth-backend/src/identity/TokenFactory.ts

Co-authored-by: Himanshu Mishra <himanshu@orkohunter.net>

* Change from minor to patch

* Update DatabaseKeyStore.ts

* feat: added a test for running a simple cypress server

* Add luxon and remove moment

* Port from moment to Luxon

* Add changeset

* Fixes following CR

* Rebased and reinstalled yarn.lock

* Changed to fromSQL

* Fix prettier formatting

* chore: reworking the lock file for the cypress deps

* chore: adding cypress.config

* chore: reworking some more examples

* chore: added some more simple stuff for e2e tests with cypress

* chore: reworking again

* chore: making cypress nice

* chore: added a sample test that works

* chore: reworking tests to use he cypress github-action instead

* chore: reconfigure Cypress run

* chore: don't install - we have deps

* chore: dump video recordings too

* chore: slimming down install script a little

* chore: make pretty

* chore: fixing syntax

* chore: fixing syntax again

* Align card elements with list

* Align card elements with List

* Add changeset

* Removed unused import

* chore: archive video footage with the correct path

* chore: fix lint warnings

* chore: fix prettier again

* chore: move files around for ease

* Added pattern for component name

* Add changeset

* stash: push to stash

* Return AboutCard title to group name

* Refactor children to use shared function

* TechDocs: Add visbility to migrate away from basic setup

* bugfix: [3310] Favoriting a component resets interface to your owned components

update changeset

remove unused import

fix changeset message

fix vale errors?

* Create utc DateTime object directly

* integration: update the gitlab config mandatory fields to match reality

* Resolve review comments

* Remove shadowed variables

* generateEntityDefinitions should return a PartialEntity

* Update roadmap with Backstage Community Sessions

* Make sure that SidebarItems are also active when on sub route

* Add whitespace around variable

* Add changeset

* Add word to dictionary

* Smater duration display

* Add changeset

* chore(deps-dev): bump @graphql-codegen/typescript from 1.18.1 to 1.20.2

Bumps [@graphql-codegen/typescript](https://github.com/dotansimha/graphql-code-generator/tree/HEAD/packages/plugins/typescript/typescript) from 1.18.1 to 1.20.2.
- [Release notes](https://github.com/dotansimha/graphql-code-generator/releases)
- [Changelog](https://github.com/dotansimha/graphql-code-generator/blob/master/packages/plugins/typescript/typescript/CHANGELOG.md)
- [Commits](https://github.com/dotansimha/graphql-code-generator/commits/@graphql-codegen/typescript@1.20.2/packages/plugins/typescript/typescript)

Signed-off-by: dependabot[bot] <support@github.com>

* chore: reworking folder structure to move cypress outside of the project

* chore: updating workflow to point at the right folder now

* chore: fixing cypress build

* microsite: Fix color contrast for pre tags

* Add package name to lockfile.ts error

* Create new-mangos-tap.md

* Changed changeset bump to be patch

* Pass registered Logger in ServiceBuilderImpl to requestLoggingHandler

`requestLoggingHandler` takes an optional `logger` parameter that it can use
to log incoming requests. The `ServiceBuilderImpl` was not passing  on this logger, if
set, to `requestLoggingHandler` middleware

* Add indices on columns referring location(id)

* Add changeset

* Catch catalog errors

* Add changeset

* Fixed parseUrl to output catalogPaths beginning with '/'

* Add configurable OAuth 2.0 scopes

- Add oauth2 config for optional scopes
- Document oauth2 config keys
- Add OAuth2 to demo app list of identity providers

* incorrectly added callbackUrl

* chore: added a simple readme to run some simple tests against a backstage instance

* chore(deps): bump @svgr/plugin-jsx from 5.4.0 to 5.5.0

Bumps [@svgr/plugin-jsx](https://github.com/gregberge/svgr) from 5.4.0 to 5.5.0.
- [Release notes](https://github.com/gregberge/svgr/releases)
- [Changelog](https://github.com/gregberge/svgr/blob/main/CHANGELOG.md)
- [Commits](https://github.com/gregberge/svgr/compare/v5.4.0...v5.5.0)

Signed-off-by: dependabot[bot] <support@github.com>

* chore(deps): bump @types/cors from 2.8.6 to 2.8.9

Bumps [@types/cors](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/cors) from 2.8.6 to 2.8.9.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/cors)

Signed-off-by: dependabot[bot] <support@github.com>

* fix: removing test e2e-test tsconfig.json file

* TechDocs: Preparers will take and return an etag for cache invalidation

* TechDocs: Implement etag based caching for url preparer

Signed-off-by: Himanshu Mishra <himanshu@orkohunter.net>

* TechDocs: Implement etag based caching for git preparer

Signed-off-by: Himanshu Mishra <himanshu@orkohunter.net>

* TechDocs: Warn when using legacy git preparer and dir preparer in backstage.io/techdocs-ref

Context: https://github.com/backstage/backstage/issues/4409

* TechDocs: Update tests for proper url preparer caching

* TechDocs: Deduplicate git clone for cache check

Signed-off-by: Himanshu Mishra <himanshu@orkohunter.net>

* TechDocs: Add changesets for deprecation and proper caching

* TechDocs: Implement caching for dir preparer

* Update the changesets

* scaffolder-backend: remove auth-backend dependency

* catalog-client: rename ApiContext to CatalogRequestOptions + avoid export

* refactor existing usage of ApiContext

* techdocs: don't swallow errors other than NotModifiedError

* catalog-import: removed bonus code

* techdocs: meaningful logs when readTree starts

* Flatten the options of the CatalogImportPage

* inline optional id token auth headers

* Define relationship to software catalog and loose coupling by convention.

* Clarify intentions around bulk vs. incremental index management.

* Break apart backend plugins & clarify indexer/plugin relationship.

* update changeset bump levels

* [Search] documentation update (#4459)

* delete link to issue as it is closed

* replace usage of easy as its very subjective

* Update docs/features/search/architecture.md

Co-authored-by: Adam Harvey <adam.harvey@dxc.com>

* prettier....:

Co-authored-by: Adam Harvey <adam.harvey@dxc.com>

* Own it.

* scaffolder: include backstage identity token in requests

* review feedback tweaks

* docs/apis: update to use named plugin var

* sentry: update plugin instance export name

* clear other field when toggling reason

* changeset

* fix(pagerduty): use the luxon date library

* Don't pass default as a scope to OIDC providers

* docs(TechDocs): Add GitHub Actions CI example with AWS S3

* tech-radar: migrated to new composability API

* cost-insights: migrate to new composability API

* Changeset

* Fix line endings

* Prettier

* Remove unnecessary scopes from OIDC defaultApi

* Bump plugin-auth-backend to a minor change,
add documentation for fixing it

* Fix md syntax error

* Fix Vale spelling error

* Remove defaultScopes from OIDC api

* [ImgBot] Optimize images

/plugins/catalog-import/docs/catalog-import-screenshot.png -- 613.39kb -> 356.48kb (41.88%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>

* github/workflows: use lax config checks

* Use commented-out example value for scope

* feat(pagerduty): add changeset

* Apply suggestions from code review

Co-authored-by: Rémi Doreau <32459935+ayshiff@users.noreply.github.com>

* feat(catalog): add entity links card component

* update entity links changeset

* Fix prettier

* chore(deps-dev): bump @types/http-proxy from 1.17.4 to 1.17.5

Bumps [@types/http-proxy](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/http-proxy) from 1.17.4 to 1.17.5.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/http-proxy)

Signed-off-by: dependabot[bot] <support@github.com>

* Revert "Merge pull request #3953 from ayshiff/feature/techdocs-aws-sdkv3"

This reverts commit 1c7771871e, reversing
changes made to 65d5c8e6fe.

* Revert "Merge pull request #4035 from ayshiff/feature/catalog-backend-aws-sdk-v3"

This reverts commit 1df9134648, reversing
changes made to d45a510069.

* Add changeset

* feat: support custom app icons

* backend-common: implement UrlReader.search for the other providers too

* Remove changeset

* docs(TechDocs): Improvements to the CI example

Signed-off-by: Himanshu Mishra <himanshu@orkohunter.net>

* fix(catalog): entity links incorrect wrapping

* Remove unused functions and luxon

* Removed old imports

* Fix broken links in documentation (#4418)

* Update IdentityApi.md

* Update docs/reference/utility-apis/IdentityApi.md

* Update docs/reference/utility-apis/IdentityApi.md

* ran yarn docgen

* Use JS Date instead of Datetime

* Add line

* Prettier fix

* Move parseDate function

* Version Packages

* chore: fix the create-app version

* Limit the props that are forwarded to the Link component in the EntityRefLink

* Use routed tabs to link to every settings page

* fix up yarn after release

* chore: add lockfile to words

* catalog-info: add links

* Export Select component from core

I saw the Select component on storybook and went
to use it but it seems it's not exported. Any chance
it could be exported?

* bug: filepath can be returned as undefined from `git-url-parse` let's default to empty

* chore: might as well do this for all parsing

* chore: changeset

* Add changeset for fixing requestLoggingHandler

* chore(deps-dev): bump @storybook/addon-actions from 6.1.11 to 6.1.17

Bumps [@storybook/addon-actions](https://github.com/storybookjs/storybook/tree/HEAD/addons/actions) from 6.1.11 to 6.1.17.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v6.1.17/addons/actions)

Signed-off-by: dependabot[bot] <support@github.com>

* Port AboutCard

* Fix tests

* Revert EntityPage changes

* docs: Merge auth glossary with main glossary

* Remove the "Move repository" menu entry from the catalog page, as it's just a placeholder

It will be easy to bring it back later, but for now it just confuses users that it's not doing anything. It's also hard to remove for integrators.

* make the template cards conform to mui standard

Co-authored-by: Erik Larsson <erik.larsson@schibsted.com>
Co-authored-by: Dominik Henneke <dominik.henneke@sda-se.com>
Co-authored-by: Nils Streijffert <nstreijffert@spotify.com>
Co-authored-by: Nils Streijffert <nils.streijffert@gmail.com>
Co-authored-by: Himanshu Mishra <himanshu@orkohunter.net>
Co-authored-by: blam <ben@blam.sh>
Co-authored-by: Nir Gazit <nir.gzt@gmail.com>
Co-authored-by: Adam Harvey <adam.harvey@dxc.com>
Co-authored-by: NHI TRAN <nhid@ntran.io>
Co-authored-by: Fredrik Adelöw <freben@gmail.com>
Co-authored-by: Oliver Sand <oliver.sand@sda-se.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Debajyoti Halder <rondebajyoti@gmail.com>
Co-authored-by: Patrik Oldsberg <poldsberg@gmail.com>
Co-authored-by: Gowind <petrovgovind@gmail.com>
Co-authored-by: Alan Crosswell <alan@columbia.edu>
Co-authored-by: Eric Peterson <ericpeterson@spotify.com>
Co-authored-by: Emma Indal <emma.indahl@gmail.com>
Co-authored-by: Ryan Vazquez <ryanv@spotify.com>
Co-authored-by: Ryan Vazquez <ryanmvazquez@gmail.com>
Co-authored-by: Remi <remi.d45@gmail.com>
Co-authored-by: Ryan Manny <rmanny@apptio.com>
Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>
Co-authored-by: Rémi Doreau <32459935+ayshiff@users.noreply.github.com>
Co-authored-by: Andrew Thauer <6507159+andrewthauer@users.noreply.github.com>
Co-authored-by: Joel Low <joel@joelsplace.sg>
Co-authored-by: Eric Peterson <iamEAP@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Iain Billett <iain@roadie.io>
2021-02-12 16:08:46 +01:00
Ben Lambert e58cc939a4 Merge pull request #4510 from SDA-SE/feat/move-repository
Remove the "Move repository" menu entry from the catalog page, as it's just a placeholder
2021-02-12 15:25:53 +01:00
Fredrik Adelöw 6c4a76c595 make the template cards conform to mui standard 2021-02-12 14:39:29 +01:00
Patrik Oldsberg 10e59af4d0 auth-backend: refactor provider factories to accept options 2021-02-12 14:36:46 +01:00
Oliver Sand 914c89b131 Remove the "Move repository" menu entry from the catalog page, as it's just a placeholder
It will be easy to bring it back later, but for now it just confuses users that it's not doing anything. It's also hard to remove for integrators.
2021-02-12 12:36:45 +01:00
Andrew Thauer 536dd3f9ce Merge pull request #4483 from andrewthauer/feat/custom-icons
feat(core-api): support custom app icons
2021-02-12 06:04:44 -05:00
Oliver Sand 83feefb996 Fix tests 2021-02-12 09:23:46 +01:00
Oliver Sand 53b69236dd Port AboutCard 2021-02-12 09:23:46 +01:00
blam c6a67b100e chore: might as well do this for all parsing 2021-02-11 20:10:20 +01:00
blam c1164fb6a8 bug: filepath can be returned as undefined from git-url-parse let's default to empty 2021-02-11 20:09:24 +01:00
Oliver Sand 1b38e38094 Merge pull request #4491 from SDA-SE/feat/settings-routes
Use routed tabs to link to every settings page
2021-02-11 16:56:09 +01:00
Oliver Sand d872f662df Use routed tabs to link to every settings page 2021-02-11 14:24:28 +01:00
Nils Streijffert cba94afe17 Merge pull request #4386 from backstage/auth-backend-port-to-luxon
Auth backend port to Luxon
2021-02-11 14:22:30 +01:00
Dominik Henneke 6258b7aa7b Merge pull request #4485 from SDA-SE/feat/entity-link
Limit the props that are forwarded to the Link component in the EntityRefLink
2021-02-11 12:41:32 +01:00
Dominik Henneke d34d26125b Limit the props that are forwarded to the Link component in the EntityRefLink 2021-02-11 11:47:13 +01:00
github-actions[bot] aa49ca2284 Version Packages 2021-02-11 10:15:47 +00:00
Patrik Oldsberg 190c709473 Merge pull request #4478 from ayshiff/fix/pagerduty-plugin-luxon
Pagerduty plugin: use the Luxon library
2021-02-11 11:10:56 +01:00
Patrik Oldsberg cd13b03bc6 Merge pull request #4434 from lowjoel/aws-sdk-downgrade
Downgrade the AWS SDK to v2
2021-02-11 11:02:11 +01:00
Patrik Oldsberg f89138f6c7 Merge pull request #4412 from nhidtran/bugfix/3310
bugfix: [3310] Favoriting a component resets interface to your owned components
2021-02-11 11:00:56 +01:00
Nils Streijffert 072a960518 Move parseDate function 2021-02-11 10:37:58 +01:00
Nils Streijffert 01700ceccd Prettier fix 2021-02-11 10:30:48 +01:00
Nils Streijffert a107018191 Add line 2021-02-11 10:22:34 +01:00
Nils Streijffert 636c70ac91 Use JS Date instead of Datetime 2021-02-11 10:16:34 +01:00
Patrik Oldsberg 66fd809921 Merge pull request #4389 from backstage/catalog-port-to-luxon
Port catalog plugin to Luxon
2021-02-11 09:52:24 +01:00
Andrew Thauer bf5c0c82c2 Merge pull request #4484 from andrewthauer/fix/entity-links-card-sizing
fix(catalog): entity links incorrect wrapping
2021-02-11 03:44:03 -05:00
Nils Streijffert f2a17ac890 Removed old imports 2021-02-11 09:34:55 +01:00
Nils Streijffert 3b54bf8e64 Remove unused functions and luxon 2021-02-11 09:33:17 +01:00
Andrew Thauer 72cd867060 fix(catalog): entity links incorrect wrapping 2021-02-11 03:29:53 -05:00
Nils Streijffert 2d194bfc87 Merge pull request #4400 from backstage/add-component-name-warning
Scaffolder: Add component name warning
2021-02-11 09:29:36 +01:00