Commit Graph

9668 Commits

Author SHA1 Message Date
Fredrik Adelöw 35280f66b3 stop using EntityRef in tech-insights-backend
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2022-02-23 12:01:27 +01:00
Fredrik Adelöw 7d82685c9d stop using EntityRef in jenkins
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2022-02-23 12:01:27 +01:00
Fredrik Adelöw 184366af8b stop using EntityRef in jenkins-backend
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2022-02-23 12:01:27 +01:00
Fredrik Adelöw 19521af045 stop using EntityRef in code-coverage-backend
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2022-02-23 12:01:27 +01:00
Fredrik Adelöw 410e592552 stop using EntityRef in bazaar
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2022-02-23 12:01:27 +01:00
Fredrik Adelöw 3f480db963 stop using EntityRef in scaffolder-backend
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2022-02-23 12:01:27 +01:00
Fredrik Adelöw ce6abe1699 Merge pull request #9459 from HqOapp/fmc100/codeclimate-plugin
[Plugin] Code Climate
2022-02-23 10:33:08 +01:00
Frank Cycan e621d9658b [Plugin] Code Climate
Signed-off-by: Frank Cycan <frank@hqo.co>
2022-02-22 11:53:56 -05:00
Ben Lambert 4e709aaecd Merge pull request #9727 from backstage/blam/migrations/scaffolder-backend/last
🧹 More Deprecations and Breaking Changes to `plugin-scaffolder-backend`
2022-02-22 16:31:56 +01:00
Fredrik Adelöw 022ea70506 Merge pull request #9726 from backstage/freben/airbrake-again
further airbrake fix
2022-02-22 16:24:19 +01:00
Johan Haals 17ac7a9869 Merge pull request #9720 from backstage/jhaals/remove-EntityContext
catalog-react: Remove EntityContext
2022-02-22 16:23:54 +01:00
blam 4165cc0ce4 chore: the last of the migrations
Signed-off-by: blam <ben@blam.sh>
2022-02-22 16:09:44 +01:00
Fredrik Adelöw c1069d2c40 further airbrake fix
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2022-02-22 15:53:04 +01:00
blam b5a65f9946 chore: rebuild api-reports
Signed-off-by: blam <ben@blam.sh>
2022-02-22 14:33:42 +01:00
blam 67771d2b21 chore: remove the observe method in favour of an observable
Signed-off-by: blam <ben@blam.sh>
2022-02-22 14:31:20 +01:00
Ben Lambert 53dbebbcde Merge pull request #9701 from backstage/blam/deprecations/octokit
deprecations: Deprecate the `OctokitProvider` export from `scaffolder-backend`
2022-02-22 13:38:32 +01:00
blam dbe239808d chore: encodeURIComponent
Signed-off-by: blam <ben@blam.sh>
diff --git c/plugins/scaffolder-backend/src/scaffolder/actions/builtin/publish/githubPullRequest.ts i/plugins/scaffolder-backend/src/scaffolder/actions/builtin/publish/githubPullRequest.ts
index ca70084ef5..9efc11210a 100644
--- c/plugins/scaffolder-backend/src/scaffolder/actions/builtin/publish/githubPullRequest.ts
+++ i/plugins/scaffolder-backend/src/scaffolder/actions/builtin/publish/githubPullRequest.ts
@@ -65,10 +65,14 @@ export const defaultClientFactory = async ({
   host = 'github.com',
   token: providedToken,
 }: ClientFactoryInput): Promise<PullRequestCreator> => {
+  const [encodedHost, encodedOwner, encodedRepo] = [host, owner, repo].map(
+    encodeURIComponent,
+  );
+
   const octokitOptions = await getOctokitOptions({
     integrations,
     credentialsProvider: githubCredentialsProvider,
-    repoUrl: `https://${host}/${owner}/${repo}`,
+    repoUrl: `https://${encodedHost}/${encodedOwner}/${encodedRepo}`,
     token: providedToken,
   });
2022-02-22 13:10:39 +01:00
blam 1bb1022908 chore: removing the rexports
Signed-off-by: blam <ben@blam.sh>
2022-02-22 12:45:56 +01:00
blam 48c0316f3e chore: add type option for emitLogEvent
Signed-off-by: blam <ben@blam.sh>
2022-02-22 12:28:19 +01:00
Fredrik Adelöw 0045270527 airbrake: fix config to be optional, unbreak local dev startup
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2022-02-22 11:31:05 +01:00
blam 8142c09b3f chore: wth prettier
Signed-off-by: blam <ben@blam.sh>
2022-02-22 11:29:35 +01:00
Johan Haals 3334ad47d4 catalog-react: Remove EntityContext
Signed-off-by: Johan Haals <johan.haals@gmail.com>
2022-02-22 10:22:38 +01:00
Fredrik Adelöw d788fa8495 Merge pull request #9665 from djamaile/feature-flag-scaffolding
feat(scaffolder): remove sections or fields based on a feature flag
2022-02-21 21:53:40 +01:00
blam 5b7079a696 chore review comments
Signed-off-by: blam <ben@blam.sh>

Signed-off-by: blam <ben@blam.sh>
2022-02-21 20:52:27 +01:00
djamaile 04d4829cf4 refactor: respond to comments #2
Signed-off-by: djamaile <rdjamaile@gmail.com>
2022-02-21 20:26:54 +01:00
Fredrik Adelöw b212bed480 Merge pull request #9605 from moltenice-forks/airbrake-connect
Make the Airbrake plugin useable
2022-02-21 19:49:03 +01:00
Eric Peterson 78e31e6b68 Merge pull request #9244 from jonathan-ash/techdocs-reader-custom-error-page
Added the option to supply a custom error page to TechDocsPage
2022-02-21 17:50:03 +01:00
Eric Peterson 3675e7120c Minor feedback
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-02-21 17:12:50 +01:00
Fredrik Adelöw 1b7d5e5bea Merge pull request #9686 from backstage/dependabot/npm_and_yarn/graphql-modules-2.0.0
chore(deps): bump graphql-modules from 1.4.4 to 2.0.0
2022-02-21 16:59:39 +01:00
Karan Shah 96e8c9fd59 Refactor to not need core-app-api
Signed-off-by: Karan Shah <karan.shah@simplybusiness.co.uk>
2022-02-21 15:38:07 +00:00
djamaile 5c5362137a refactor: respond to comments
Signed-off-by: djamaile <rdjamaile@gmail.com>
2022-02-21 16:30:04 +01:00
Johan Haals ac27092211 Merge pull request #9698 from backstage/jhaals/cleanup-catalog-backend
catalog-backend: Cleanup API report
2022-02-21 16:14:31 +01:00
blam 5042a822f6 chore: fix auth provided
Signed-off-by: blam <ben@blam.sh>
2022-02-21 16:08:16 +01:00
blam 1a864a3b68 chore: updating the api report
Signed-off-by: blam <ben@blam.sh>
2022-02-21 15:57:18 +01:00
blam 9553964f28 chore: providing a new helper for generating octokit credentialsProvider
Signed-off-by: blam <ben@blam.sh>
2022-02-21 15:41:30 +01:00
blam afee525a36 chore: deprecating the OctokitProvider
Signed-off-by: blam <ben@blam.sh>
2022-02-21 15:40:38 +01:00
Karan Shah f62ce97a15 This is needed
https://github.com/backstage/backstage/runs/5275475872?check_suite_focus=true
Signed-off-by: Karan Shah <karan.shah@simplybusiness.co.uk>
2022-02-21 14:33:09 +00:00
Karan Shah 4abc806f23 Remove unnecessary dependency
Signed-off-by: Karan Shah <karan.shah@simplybusiness.co.uk>
2022-02-21 14:15:23 +00:00
Ben Lambert 416032660b Merge pull request #9670 from backstage/blam/deprecations/3
deprecations: More small type fixes and deprecations for `scaffolder-backend`
2022-02-21 15:01:12 +01:00
Fredrik Adelöw c503e588b5 Merge pull request #9673 from backstage/server-permission-client-error
[Permissions] Improve error message for backend-to-backend authn setup
2022-02-21 14:59:01 +01:00
Johan Haals 750f7dffdb Merge pull request #9695 from backstage/jhaals/deprecate-useEntityListProvider
catalog-react: Rename useEntityListProvider hook to useEntityList
2022-02-21 14:57:49 +01:00
Fredrik Adelöw 7c4a51ae0e Merge pull request #9640 from backstage/dependabot/npm_and_yarn/asyncapi/react-component-1.0.0-next.33
chore(deps): bump @asyncapi/react-component from 1.0.0-next.32 to 1.0.0-next.33
2022-02-21 14:56:05 +01:00
Johan Haals 6d994fd9da catalog-backend: Cleanup API report
Signed-off-by: Johan Haals <johan.haals@gmail.com>
2022-02-21 14:55:34 +01:00
Emma Indal 0cbeaf04ce Merge pull request #9697 from backstage/emmaindal/techdocs-backend-api-report
[TechDocs] clean up techdocs backend api report
2022-02-21 14:20:09 +01:00
Johan Haals b776ce5aab catalog-react: Rename useEntityListProvider hook to useEntityList
Signed-off-by: Johan Haals <johan.haals@gmail.com>
2022-02-21 13:32:37 +01:00
Johan Haals 1482bb9349 Merge pull request #9690 from backstage/jhaals/deprecate-useEntityKinds
catalog-react: deprecate useEntityKinds
2022-02-21 13:25:36 +01:00
Emma Indal 68abf6e837 Update plugins/techdocs-backend/src/search/DefaultTechDocsCollator.ts
Signed-off-by: Emma Indal <emma.indahl@gmail.com>

Co-authored-by: Eric Peterson <iamEAP@users.noreply.github.com>
2022-02-21 13:24:56 +01:00
Emma Indal e60175e87a clean up deprecated code
Signed-off-by: Emma Indal <emma.indahl@gmail.com>
2022-02-21 12:06:43 +01:00
Emma Indal 81b6d0fabe clean up api report
Signed-off-by: Emma Indal <emma.indahl@gmail.com>
2022-02-21 12:02:50 +01:00
Camila Belo 8651981680 Merge pull request #9569 from backstage/bump-mkdocs-material
[TechDocs] Adjust theme styles
2022-02-21 11:38:07 +01:00