Commit Graph

91 Commits

Author SHA1 Message Date
Renan Mendes Carvalho dd7dfaa922 test(search): Move expectations inside waitFor
Signed-off-by: Renan Mendes Carvalho <aitherios@gmail.com>
2023-06-27 13:56:51 +02:00
Camila Belo ae6ee0093e test(search): optimize search bar suite
Signed-off-by: Camila Belo <camilaibs@gmail.com>
2023-06-27 13:56:51 +02:00
siddhant1 af03e92192 Fix tabindex
Signed-off-by: siddhant1 <sidhant.manchanda@gmail.com>
2023-06-09 16:58:59 +02:00
Patrik Oldsberg bbdd277e73 search-react: fix SearchResultPager useSearch mock to allow rerender
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2023-06-06 12:48:16 +02:00
Oleg S 74b216ee4e set PropsWithChildren as explicit type on components
Signed-off-by: Oleg S <97077423+RobotSail@users.noreply.github.com>
2023-05-24 12:47:27 +02:00
Camila Belo ba261f9dcd fix(search): input base styles
Signed-off-by: Camila Belo <camilaibs@gmail.com>
2023-05-19 11:03:49 -05:00
Carlos Esteban Lopez 2f660eb573 fix(search): Fix SearchBar styles & update StoryBook stories for custom styles for notchedOutline class
Signed-off-by: Carlos Esteban Lopez <lcarlosesteb@vmware.com>
2023-05-19 11:03:49 -05:00
Gabriel Testault 76153fa9e9 fix(plugin-search-react): add regression test
Signed-off-by: Gabriel Testault <gabriel.testault@goto.com>
2023-05-11 11:39:57 +02:00
Gabriel Testault f9114941c9 fix(plugin-search-react): reset page cursor when page limit changes
Signed-off-by: Gabriel Testault <gabriel.testault@goto.com>
2023-05-11 11:39:57 +02:00
Gabriel Testault 6ca4123ce6 fix(plugin-search-react): hide unexposed prop from SearchPaginationBaseProps
Signed-off-by: Gabriel Testault <gabriel.testault@goto.com>
2023-05-11 11:39:57 +02:00
Renan Mendes Carvalho 1ce7f84b2e feature(plugin-search-react): Extend InputProps on <SearchBar/>
In the current implementation of <SearchBar/> it is possible to
overwrite the default <TextField/> InputProps by passing a prop of the
same name. But sometimes is necessary to extend only, for example when
one is interested on changing the clear button only.
The clear button is supplied in the endAdornment, part of the
InputProps, but at the same time the startAdornment is also on it.
To be able to replace the clear button implementation without affecting
the rest, this patch proposes a change where `InputProps` is exposed in
the same manner as `inputProps` (notice the change from capital I to i).
Where the received object may overwrite keys using the spread operator.

Signed-off-by: Renan Mendes Carvalho <aitherios@gmail.com>
2023-05-08 14:13:33 +02:00
Renan Mendes Carvalho 326cdb42da lint(plugin-search-react): Fix prettier issues
Signed-off-by: Renan Mendes Carvalho <aitherios@gmail.com>
2023-05-03 15:00:51 +02:00
Renan Mendes Carvalho 48181827dc fix(plugin-search-react): Fix tsc errors and use classes prop
This patch intends to fix the tsc errors in the build and change the usage of FormControlLabel to use the classes property to inject the new styles.

Signed-off-by: Renan Mendes Carvalho <aitherios@gmail.com>
2023-05-03 15:00:51 +02:00
Kenny Johnson 603ed96a25 Fix Lifecyce text-overlow issue in SearchFilter component.
Signed-off-by: Kenny Johnson <105308787+papercircuit@users.noreply.github.com>
2023-05-03 15:00:51 +02:00
Carlos Esteban Lopez 9b644e5603 tests(search): Revert autocomplete test changes
Signed-off-by: Carlos Esteban Lopez <lcarlosesteb@vmware.com>
2023-04-19 18:55:24 -05:00
Carlos Esteban Lopez a87f98b385 fix(search): Revert placeholder & sync label & aria-label
Signed-off-by: Carlos Esteban Lopez <lcarlosesteb@vmware.com>
2023-04-19 18:52:03 -05:00
Carlos Esteban Lopez 9e0f486ac2 fix(search): Fix broken tests
Signed-off-by: Carlos Esteban Lopez <lcarlosesteb@vmware.com>
2023-04-19 13:14:47 -05:00
Carlos Esteban Lopez 87efd07490 fix(search): Address Github PR comments
Signed-off-by: Carlos Esteban Lopez <lcarlosesteb@vmware.com>
2023-04-19 13:14:47 -05:00
Carlos Esteban Lopez 46310ee03f fix(search): Stop clear enter propagation
Signed-off-by: Carlos Esteban Lopez <lcarlosesteb@vmware.com>
2023-04-19 13:14:47 -05:00
Carlos Esteban Lopez cba74e9f9d fix(search): Remove unused bar class & swap clear icon for clear text in search bar
Signed-off-by: Carlos Esteban Lopez <lcarlosesteb@vmware.com>
2023-04-19 13:14:47 -05:00
Carlos Esteban Lopez b9db68aba2 fix(storybook): Fix styles of SearcBar Paper in StoryBook
Signed-off-by: Carlos Esteban Lopez <lcarlosesteb@vmware.com>
2023-04-19 13:14:47 -05:00
Carlos Esteban Lopez 718ef60638 tests(search): Fix tests broken by change from placeholder to label
Signed-off-by: Carlos Esteban Lopez <lcarlosesteb@vmware.com>
2023-04-19 13:14:47 -05:00
Carlos Esteban Lopez e22f74f421 feat(search): Improve search dialog's & page's bar UI
Signed-off-by: Carlos Esteban Lopez <lcarlosesteb@vmware.com>
2023-04-19 13:14:47 -05:00
Sudeep Sinha b2e182cdfa Fix font size and color in search result item
Signed-off-by: Sudeep Sinha <ssinha@squarespace.com>
2023-03-08 14:08:47 -05:00
Emma Indal 905141aa08 Merge pull request #16576 from kuangp/fix/searchPagination
fix(SearchPagination): disable next button on last page
2023-03-03 11:28:02 +01:00
Fredrik Adelöw 65454876fb unpack props inside component bodies
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2023-02-27 15:31:15 +01:00
Phil Kuang 553f3c9501 fix(SearchPagination): disable next button on last page
Signed-off-by: Phil Kuang <pkuang@factset.com>
2023-02-23 15:53:30 -05:00
Fredrik Adelöw c10384a923 Get rid of usages of the old Button
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2023-02-22 14:29:31 +01:00
Emma Indal ce1220a4b8 support custom list item props on search extensions
Co-authored-by: Camila Belo <camilaibs@gmail.com>
Signed-off-by: Emma Indal <emma.indahl@gmail.com>
2023-02-02 09:36:30 +01:00
Emma Indal c3798fd6bd update api reports
Signed-off-by: Emma Indal <emma.indahl@gmail.com>
2023-02-01 15:40:21 +01:00
Emma Indal f7e698636a updates based on result list items extension changes
Signed-off-by: Emma Indal <emma.indahl@gmail.com>
2023-02-01 15:40:21 +01:00
Emma Indal a0619a5b49 make sure result list is structured with list elements only
Signed-off-by: Emma Indal <emma.indahl@gmail.com>
2023-02-01 15:40:21 +01:00
Camila Belo 6aba9d113d fix(search): result extension stories
Signed-off-by: Camila Belo <camilaibs@gmail.com>
2023-01-28 11:06:01 +01:00
Camila Belo 2f91e1684e feat(search): create catalog, explore, tools, and search extensions
Signed-off-by: Camila Belo <camilaibs@gmail.com>
2023-01-28 10:05:15 +01:00
Camila Belo a7ec5e7d78 feat(search): create result item hook and components
Signed-off-by: Camila Belo <camilaibs@gmail.com>
2023-01-28 10:05:15 +01:00
Camila Belo 098cf0f8c0 feat(search): create search result list item extensions
Signed-off-by: Camila Belo <camilaibs@gmail.com>
2023-01-28 10:05:14 +01:00
Carlos Esteban Lopez 1daac71e74 fix: Apply linter <span> rule
Signed-off-by: Carlos Esteban Lopez <lcarlosesteb@vmware.com>
2023-01-10 16:07:40 -05:00
Rutuja Marathe 6d9a93def8 feat(search-react): customize <SearchResult/> no result state
Signed-off-by: Rutuja Marathe <rutujasudam.marathe@factset.com>
2023-01-04 13:50:10 -05:00
Patrik Oldsberg 2e701b3796 refactor react-router -> react-router-dom
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2022-12-10 15:17:53 +01:00
Eric Peterson 9467500482 Merge pull request #14794 from philberryman/feat/analytics-number-of-search-results
add number of searches
2022-11-30 12:09:14 +01:00
Phil Berryman 38f46e6d5c chore: remove addition of numberOfResults from PgSearchEngine
Signed-off-by: Phil Berryman <phil@berryman.org.uk>
2022-11-28 14:50:22 -08:00
Phil Berryman 29ebc43a0b feat: add number of searches
Signed-off-by: Phil Berryman <phil@berryman.org.uk>
2022-11-25 00:13:05 -08:00
Jonathan Sundquist 81e945d052 move link outside of ternary
Signed-off-by: Jonathan Sundquist <jonathan.sundquist@factset.com>
2022-11-15 09:24:28 -06:00
Jonathan Sundquist a19cffbeed fix(search): update to only link title in search results
Signed-off-by: Jonathan Sundquist <jonathan.sundquist@factset.com>
2022-11-14 10:16:44 -06:00
Camila Belo 098f487e59 refactor: add results total prop
Signed-off-by: Camila Belo <camilaibs@gmail.com>
2022-10-11 09:15:14 +02:00
Camila Belo 270ee83613 refactor: change default page limit text
Signed-off-by: Camila Belo <camilaibs@gmail.com>
2022-10-10 12:08:16 +02:00
Camila Belo c9198c9fce refactor(search-react): use mui table pagination component
Signed-off-by: Camila Belo <camilaibs@gmail.com>
2022-10-08 21:35:20 +02:00
Camila Belo 5eb598babb refactor(search-react): restrict range of valid options type
Signed-off-by: Camila Belo <camilaibs@gmail.com>
2022-10-07 18:31:34 +02:00
Camila Belo 3de4bd4f19 Create a page limit component
Signed-off-by: Camila Belo <camilaibs@gmail.com>
2022-10-06 09:00:59 +02:00
Camila Belo d7200e4d91 Add page limit to search context and state
Signed-off-by: Camila Belo <camilaibs@gmail.com>
2022-10-04 10:54:09 +02:00