Commit Graph

150 Commits

Author SHA1 Message Date
Ben Lambert 5af48e77af feat(scaffolder): Migrate scaffolder to use permissions registry (#33740)
* feat(scaffolder-node): add PermissionResourceRef definitions for scaffolder resource types

Signed-off-by: benjdlambert <ben@blam.sh>

* feat(scaffolder-backend): migrate to PermissionsRegistryService with fallback

Signed-off-by: benjdlambert <ben@blam.sh>

* feat(scaffolder-backend): wire permissionsRegistry in ScaffolderPlugin

Signed-off-by: benjdlambert <ben@blam.sh>

* test(scaffolder-backend): verify permissions metadata endpoint returns all scaffolder permissions

Signed-off-by: benjdlambert <ben@blam.sh>

* chore: add changesets for scaffolder permissions registry migration

Signed-off-by: benjdlambert <ben@blam.sh>

* chore: format scaffolder-node alpha exports

Signed-off-by: benjdlambert <ben@blam.sh>

* fix: correct scaffolder-node changeset to patch for sub-1.0 package

Signed-off-by: benjdlambert <ben@blam.sh>

* refactor(scaffolder-backend): simplify by removing fallback path and making permissionsRegistry required

Signed-off-by: benjdlambert <ben@blam.sh>

* chore: update scaffolder-node API report

Signed-off-by: benjdlambert <ben@blam.sh>

---------

Signed-off-by: benjdlambert <ben@blam.sh>
2026-04-06 19:10:43 +02:00
Gabriel Dugny 49171c9de4 chore: Update all imports to zod/v3
Signed-off-by: Gabriel Dugny <gabriel.dugny@believe.com>
2026-03-17 16:48:42 +01:00
Sander van Delden cd0ecc50b1 feat(plugin-scaffolder-node/githelpers): add function to stage files for removal
Signed-off-by: Sander van Delden <38953576+SanderDelden@users.noreply.github.com>
2026-03-09 17:20:05 +01:00
Andre Wanlin 527cf88a90 Integration - Removed long deprecated code
Signed-off-by: Andre Wanlin <awanlin@spotify.com>

Fixed lock file

Signed-off-by: Andre Wanlin <awanlin@spotify.com>

Improve changesets

Signed-off-by: Andre Wanlin <awanlin@spotify.com>

Removed link

Signed-off-by: Andre Wanlin <awanlin@spotify.com>

Update .changeset/sharp-ravens-shop.md

Co-authored-by: Aramis Sennyey <159921952+aramissennyeydd@users.noreply.github.com>
Signed-off-by: Andre Wanlin <67169551+awanlin@users.noreply.github.com>

Update .changeset/six-trees-carry.md

Co-authored-by: Aramis Sennyey <159921952+aramissennyeydd@users.noreply.github.com>
Signed-off-by: Andre Wanlin <67169551+awanlin@users.noreply.github.com>

Update .changeset/tiny-zoos-smash.md

Co-authored-by: Aramis Sennyey <159921952+aramissennyeydd@users.noreply.github.com>
Signed-off-by: Andre Wanlin <67169551+awanlin@users.noreply.github.com>

Corrected gerrit changes based on feedback

Signed-off-by: Andre Wanlin <awanlin@spotify.com>

Updated API report

Signed-off-by: Andre Wanlin <awanlin@spotify.com>

Fixed some tests

Signed-off-by: Andre Wanlin <awanlin@spotify.com>

Fixed test

Signed-off-by: Andre Wanlin <awanlin@spotify.com>

Fixed another test

Signed-off-by: Andre Wanlin <awanlin@spotify.com>

Removed parseGerritGitilesUrl

Signed-off-by: Andre Wanlin <awanlin@spotify.com>

Table clean up

Signed-off-by: Andre Wanlin <awanlin@spotify.com>

Remove from changeset

Signed-off-by: Andre Wanlin <awanlin@spotify.com>

Changes based on feedback

Signed-off-by: Andre Wanlin <awanlin@spotify.com>
2026-02-27 12:50:00 -06:00
Ben Lambert f598909f0f feat(scaffolder): implement scaffolderServiceRef for credentials aware communication (#33044)
* add scaffolderServiceRef to scaffolder-node

Signed-off-by: benjdlambert <ben@blam.sh>

* make ScaffolderApi methods required, add tests

Signed-off-by: benjdlambert <ben@blam.sh>

* use request objects for single-string params in ScaffolderService

Signed-off-by: benjdlambert <ben@blam.sh>

* add scaffolderServiceMock test utility

Signed-off-by: benjdlambert <ben@blam.sh>

* adjust review comments

Signed-off-by: benjdlambert <ben@blam.sh>

* add scaffolderApiMock test utility to scaffolder-react

Signed-off-by: benjdlambert <ben@blam.sh>

* use items/totalItems response shape for listTasks

Signed-off-by: benjdlambert <ben@blam.sh>

* pass credentials through for autocomplete

Signed-off-by: benjdlambert <ben@blam.sh>

---------

Signed-off-by: benjdlambert <ben@blam.sh>
2026-02-27 16:24:49 +00:00
Fredrik Adelöw 7455dae884 require the use of node prefix on native imports
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2026-01-26 13:22:53 +01:00
Fredrik Adelöw 4fc7bf037a upgrade to tar v7
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2026-01-22 12:58:08 +01:00
Ben Lambert 27f9061d24 Merge commit from fork
* chore: ensure redirects are validated against the reading config

* address comments

Signed-off-by: Fredrik Adelöw <freben@gmail.com>

---------

Signed-off-by: Fredrik Adelöw <freben@gmail.com>
Co-authored-by: Fredrik Adelöw <freben@gmail.com>
2026-01-20 16:28:29 +01:00
Ben Lambert c641c147ab Merge commit from fork 2026-01-20 16:05:28 +01:00
Paul Schultz 05f60e1e0a refactor: convert constructor parameter properties for erasableSyntaxOnly compatibility
Signed-off-by: Paul Schultz <pschultz@pobox.com>
2025-10-14 08:29:21 -05:00
benjdlambert c8aa21077c chore: last bits
Signed-off-by: benjdlambert <ben@blam.sh>
2025-09-23 16:38:54 +02:00
benjdlambert 6e2bda78bd chore: moar deprecations
Signed-off-by: benjdlambert <ben@blam.sh>
2025-09-23 16:15:36 +02:00
benjdlambert 6ea23c9c6d chore: remove deprecated types and making breaking changes
Signed-off-by: benjdlambert <ben@blam.sh>
2025-09-23 15:49:58 +02:00
Ben Lambert 1315a825cf Merge pull request #27771 from solimant/23819_scaffolder_openapi
Move Scaffolder API to OpenAPI
2025-07-29 14:36:47 +02:00
solimant d2da49c568 Deprecate and re-export
Signed-off-by: solimant <solimant@users.noreply.github.com>
2025-07-28 20:59:34 +00:00
Stephen Glass 812485cfd3 Add step info to scaffolder action context
Signed-off-by: Stephen Glass <stephen@stephen.glass>
2025-07-16 22:39:59 -04:00
Ben Lambert d95621b1ee Merge pull request #29202 from 04kash/scaffolder-task-granular-permissions
Scaffolder task granular permissions
2025-07-08 12:54:43 +02:00
Kashish Mittal e161cf1043 enforce values as string[] instead of any
Signed-off-by: Kashish Mittal <kmittal@redhat.com>
2025-06-18 16:24:02 -04:00
Kashish Mittal d2b8e6e461 address review comments
Signed-off-by: Kashish Mittal <kmittal@redhat.com>
2025-06-18 16:24:01 -04:00
Kashish Mittal 63a8d8e171 add a getTasks method to get multiple tasks through 1 DB query
Signed-off-by: Kashish Mittal <kmittal@redhat.com>
2025-06-18 16:19:53 -04:00
Kashish Mittal fe85d897d5 Remove hasTemplateEntityRefs and only keep hasCreatedBy
Signed-off-by: Kashish Mittal <kmittal@redhat.com>
2025-06-18 16:19:53 -04:00
Kashish Mittal c1ce3164ae added files related to db queries, api-reports and changeset
Signed-off-by: Kashish Mittal <kmittal@redhat.com>
2025-06-18 16:19:11 -04:00
benjdlambert f63877526a chore: cleanup the types a little bit
Signed-off-by: benjdlambert <ben@blam.sh>

Signed-off-by: benjdlambert <ben@blam.sh>
2025-06-16 13:39:06 +02:00
benjdlambert 77f713137e chore: fixing issues with typescript
Signed-off-by: benjdlambert <ben@blam.sh>
2025-06-16 11:41:51 +02:00
Kurt King 04106ae76e refactor to alpha exports
Signed-off-by: Kurt King <kurtaking@gmail.com>
2025-06-16 11:15:16 +02:00
Kurt King dbde1805b6 clean up types some
Signed-off-by: Kurt King <kurtaking@gmail.com>
2025-06-16 11:14:47 +02:00
Kurt King 919a616673 move types to node package
Signed-off-by: Kurt King <kurtaking@gmail.com>
2025-06-16 11:12:54 +02:00
benjdlambert f845abe12e chore: fix weirdness of assertions
Signed-off-by: benjdlambert <ben@blam.sh>
2025-06-05 14:06:02 +02:00
benjdlambert ddb0939b4a breaking: remove old action format design
Signed-off-by: benjdlambert <ben@blam.sh>
2025-06-04 10:59:56 +02:00
benjdlambert e89d7b664c chore: migrating azure actions to use new format
Signed-off-by: benjdlambert <ben@blam.sh>
2025-06-03 10:58:36 +02:00
mbruhin d33b552049 update name
Signed-off-by: mbruhin <47482924+mbruhin@users.noreply.github.com>
2025-05-20 11:18:35 -06:00
mbruhin 898a4ef8c7 update filter and consolidate logic
Signed-off-by: mbruhin <47482924+mbruhin@users.noreply.github.com>
2025-05-14 10:22:08 -06:00
Ben Lambert 0ab0a454aa Merge pull request #29890 from mbenson/repoUrlHardening
trim leading and trailing slashes from parseRepoUrl query parameters
2025-05-09 11:46:41 +02:00
Bogdan Nechyporenko ec42f8ed8e Fix issue 29505: Retries with EXPERIMENTAL_strategy doesn't handle authentication properly
Signed-off-by: Bogdan Nechyporenko <bnechyporenko@bol.com>
2025-05-09 07:31:25 +02:00
Matt Benson 16e2e9c1db trim leading and trailing slashes from parseRepoUrl query parameters
Signed-off-by: Matt Benson <gudnabrsam@gmail.com>
2025-05-08 17:55:06 -05:00
Matt Benson a51855db73 add unit tests for parseRepoUrl
Signed-off-by: Matt Benson <gudnabrsam@gmail.com>
2025-05-08 17:55:05 -05:00
Gabriel Dugny 72d019d663 chore(typos): Fix low-impact typos
Signed-off-by: Gabriel Dugny <gabriel.dugny@believe.com>
2025-04-23 17:56:22 +02:00
benjdlambert 3cfc7f06d1 feat: small refactor to move some logic out of the index files and move to using .args() and .returns() as it's cleaner
Signed-off-by: benjdlambert <ben@blam.sh>
2025-03-21 11:07:00 +01:00
benjdlambert d48525c9f8 chore: fix type inference with different ways to define functions
Signed-off-by: benjdlambert <ben@blam.sh>
2025-03-19 08:41:50 +01:00
Matt Benson 7f56c442aa improve return types of createTemplateFilter() and createTemplateGlobalFunction();
accommodate in ScaffolderTemplatingExtensionPoint

Signed-off-by: Matt Benson <gudnabrsam@gmail.com>
2025-03-18 13:15:57 -05:00
Ben Lambert 790331bd6e Merge pull request #28798 from backstage/blam/zod-types
Deprecate `createTemplateAction` with old `JSONSchema` and `zod` declarations
2025-03-11 11:41:10 +01:00
benjdlambert a5ddf1d2cb chore: use the original schema type intead
Signed-off-by: benjdlambert <ben@blam.sh>
2025-03-11 10:56:45 +01:00
benjdlambert 965046fdd5 feat: some rework
Signed-off-by: benjdlambert <ben@blam.sh>

Signed-off-by: benjdlambert <ben@blam.sh>
2025-03-11 10:56:43 +01:00
benjdlambert 6d0b7a9ce0 chore: nearly there, just not matching the overload
Signed-off-by: benjdlambert <ben@blam.sh>
2025-03-11 10:56:35 +01:00
blam 3ece40f8c4 chore: wip
Signed-off-by: blam <ben@blam.sh>

Signed-off-by: benjdlambert <ben@blam.sh>
2025-03-11 10:56:35 +01:00
blam c6ae5b2e33 chore: refactor a little bit and fix tests
Signed-off-by: blam <ben@blam.sh>
2025-03-11 10:56:35 +01:00
blam 08efed9160 chore: fix changesets
Signed-off-by: blam <ben@blam.sh>
t p
2025-03-11 10:56:35 +01:00
blam cb6cee1e2f chore: refactor the types a little bit
Signed-off-by: blam <ben@blam.sh>
2025-03-11 10:56:34 +01:00
blam 4abd0747cb chore: build api-reports
Signed-off-by: blam <ben@blam.sh>
2025-03-11 10:56:23 +01:00
blam e2d82fc3d8 chore: flatten the optional properties from zod
Signed-off-by: blam <ben@blam.sh>
2025-03-11 10:55:51 +01:00