74233 Commits

Author SHA1 Message Date
nikek 235007d295 Collapsible sidebar item for auth providers 2020-06-08 14:06:35 +02:00
Patrik Oldsberg 6567f241b5 packages/core-api: make ApiProvider forward APIs from parent context 2020-06-08 12:06:24 +02:00
Stefan Ålund 23c57bd1a3 Minor tweaks to catalog UI (#1176)
* Minor tweaks to catalog UI

* Review feedback

* Use styles instead
2020-06-08 11:58:44 +02:00
Patrik Oldsberg 36773f612d Merge pull request #1190 from spotify/rugvip/radarfix
plugins/tech-radar: fix lint issue in RadarBubble
2020-06-08 11:19:21 +02:00
Patrik Oldsberg 9a1b363812 plugins/tech-radar: fix lint issue in RadarBubble 2020-06-08 11:12:15 +02:00
Stefan Ålund bea471e74c Fix backend startup instructions (#1188)
* Fix backend startup instructions

* Update README.md
2020-06-08 10:28:09 +02:00
Sebastian Qvarfordt 5b6b85a222 Merge pull request #1157 from hooloovooo/catalog-edit-link
Slightly more robust edit link creation
2020-06-08 10:11:22 +02:00
Patrik Oldsberg 24a11590cd Merge pull request #1186 from spotify/stefanalund-patch-1
Changed order of backend install instructions
2020-06-08 10:01:13 +02:00
Stefan Ålund 5726b40ee3 Changed order of backend install instructions 2020-06-08 09:53:14 +02:00
Sebastian Qvarfordt a6d44d18a4 Merge branch 'master' of github.com:spotify/backstage into catalog-edit-link 2020-06-08 09:51:31 +02:00
Nathan Calvank 42130988fe Issue 661 Tech Radar Typescript refactor (#1080)
* Refactor RadarFooter

* Refactor RadarLegend Pt 1

* Refactor RadarLegend Pt 2

Seeing some errors that I don't fully understand around the proptypes
assertions seemingly being treated as null | undefined values.

It looks like I'll need to type Segment, which is not explicitly
in-scope for this issue.

* Fix segments regression

I incorrectly added type safety to the original implementation, causing
the segments to no longer be populated here. This change fixes that
regression while retaining the type safety.

This is all necessary because qidx and ridx are apparently both
nullable.

* Resolve remaining RadarLegend warnings

* Refactor RadarEntry

* Forcibly skip hooks to revert migration prettify

* Refactor RadarGrid

* Refactor RadarPlot & Best effort with PropTypes

A global search looks like no other plugins use PropTypes. I'm about to
remove them in the next commit because shapes don't seem to cooperate
with TypeScript, making the PropTypes either so vague that they're
mostly useless or specific enough to fail the build.

With that said, I wanted to get this version committed in case I need to
roll back to here. I wouldn't want to redo this work.

* Remove PropTypes from refactored components

The build now passes.

* Refactor RadarBubble

* Refactor Radar

* Move Radar functions out of component file

I could see these being split into separate files, but I think this is
enough for now.

* Small function signature change

* Align types

I'm not confident in this change. I'm very unclear about the reasoning
behind the type definitions in api.ts as they don't reflect the shape of
the values that I see when I print `data.entries` in the console.

The value of data.entries reflects a fully-populated Entry[], not a
RadarEntry[].

As such, I'm also not sure about the sample data. I would be more
hesitant to updated it, but the fact that the rest of the components
seem to be expecting that data makes it seem fairly clear that it must
be required to be in the updated shape.
2020-06-08 09:13:03 +02:00
dependabot-preview[bot] fb8e834b15 build(deps-dev): bump eslint-plugin-cypress from 2.10.3 to 2.11.1 (#1184)
Bumps [eslint-plugin-cypress](https://github.com/cypress-io/eslint-plugin-cypress) from 2.10.3 to 2.11.1.
- [Release notes](https://github.com/cypress-io/eslint-plugin-cypress/releases)
- [Commits](https://github.com/cypress-io/eslint-plugin-cypress/compare/v2.10.3...v2.11.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-06-08 09:11:06 +02:00
dependabot-preview[bot] bf5b537697 build(deps): bump eslint-plugin-import from 2.20.2 to 2.21.1 (#1183)
Bumps [eslint-plugin-import](https://github.com/benmosher/eslint-plugin-import) from 2.20.2 to 2.21.1.
- [Release notes](https://github.com/benmosher/eslint-plugin-import/releases)
- [Changelog](https://github.com/benmosher/eslint-plugin-import/blob/master/CHANGELOG.md)
- [Commits](https://github.com/benmosher/eslint-plugin-import/compare/v2.20.2...v2.21.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-06-08 09:10:32 +02:00
Stefan Ålund 6682c9fb76 Fix backend not starting (#1185)
Fixes https://github.com/spotify/backstage/issues/1177
2020-06-08 09:10:00 +02:00
Burhanuddin Udaipurwala 66db572355 fix page reload when clicking on logo (#1178) 2020-06-08 09:00:45 +02:00
dependabot-preview[bot] 074aa670fe build(deps): bump @rollup/plugin-commonjs from 12.0.0 to 13.0.0
Bumps [@rollup/plugin-commonjs](https://github.com/rollup/plugins) from 12.0.0 to 13.0.0.
- [Release notes](https://github.com/rollup/plugins/releases)
- [Commits](https://github.com/rollup/plugins/compare/commonjs-v12.0.0...commonjs-v13.0.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-06-08 06:15:24 +00:00
Fredrik Adelöw 9f02cf4a30 LocationProcessorSink -> LocationProcessorEmit 2020-06-08 07:14:16 +02:00
Stefan Ålund cd5590a21b Add background color for tabs (#1170)
* Add background color for tabs

* Use BackstageTheme

* Use paper instead

* Use standard theme
2020-06-07 20:30:50 +02:00
Ben Lambert c7ab517652 chore(navigation/tabs): fixing prop type validation (#1173) 2020-06-07 16:15:09 +02:00
blam e18a60cffa chore(react-router-v6): Fixing issues with isActive for now 2020-06-07 14:58:16 +02:00
blam fada5ab4b0 chore(react-router-v6): Tidying up some more components and moving across to the new API 2020-06-07 14:54:34 +02:00
Patrik Oldsberg fe2d04ae3b docker: add runtime config injection from env 2020-06-07 14:43:20 +02:00
blam cef099c5f7 chore(react-router-v6): fixing some of the formatting for hbs 2020-06-07 14:31:39 +02:00
blam 13f8846889 chore(react-router-v6): Fixing some more subrouting in the catalog page 2020-06-07 14:27:39 +02:00
blam 4fdb1def39 chore(react-router-v6): starting to move things to react-router-v6 2020-06-07 03:07:46 +02:00
Fredrik Adelöw e19a93ee55 Get rid of the generators 2020-06-06 23:50:09 +02:00
Fredrik Adelöw 61a02be0f4 Add logging and fix last bug 2020-06-06 22:11:42 +02:00
Fredrik Adelöw d68e4f2bd0 Switch to using generators 2020-06-06 22:11:42 +02:00
Fredrik Adelöw fe16d8ee8d chore(catalog-backend): make LocationReader, that runs a chain of processors 2020-06-06 22:09:32 +02:00
Rémi DOREAU cec47d421b fix(core): lint error 2020-06-06 18:04:08 +02:00
Rémi DOREAU f1dbf5a9fa refactor(core): update tabs 2020-06-06 17:56:39 +02:00
Patrik Oldsberg 650779412c packages/config-loader: add build- and dev-time config through env + tests 2020-06-06 17:06:47 +02:00
Patrik Oldsberg c40a2a5e61 packages/core-api: move router component inside app and configure it with base path 2020-06-06 17:06:18 +02:00
Stefan Ålund ec4aa3d59f Change example component names (#1165) 2020-06-06 17:03:52 +02:00
Ben Lambert 8e528f0bcb Merge pull request #1161 from spotify/sebastianq/component-navigation
Added Sub Tabs on Component Page and Catalog Page
2020-06-06 16:50:56 +02:00
Patrik Oldsberg 2edcd94793 packages/cli: open browser at correct path when serving bundle 2020-06-06 15:54:48 +02:00
blam 40b07d521b chore(Catalog/Tabs): remove extraneous file from otber branch 2020-06-06 15:07:41 +02:00
blam b08c5919f4 Merge branch 'master' of github.com:spotify/backstage into sebastianq/component-navigation
* 'master' of github.com:spotify/backstage:
  packages/cli: avoid duplicate dependency warning in E2E test
  build(deps): [security] bump websocket-extensions from 0.1.3 to 0.1.4
  fix: import from package
  fix: type checking
  fix: tests
  Ran yarn install
  fix: show list of components in removal dialog
  fix: github actions
  fix: make locations fetching work
  feature: extract getLocationById method, wrap location fetching in useAsync
2020-06-06 14:54:24 +02:00
Patrik Oldsberg f5ed538789 Merge pull request #1164 from spotify/rugvip/nowarn
packages/cli: avoid duplicate dependency warning in E2E test
2020-06-06 12:53:51 +02:00
Patrik Oldsberg 18c1eb3835 packages/cli: avoid duplicate dependency warning in E2E test 2020-06-06 12:37:28 +02:00
Jordi Polo 6207cf47c6 Initial version of a json schema for the service specification 2020-06-05 17:47:44 -07:00
Nikita Dudnik a0ff18b12e Merge pull request #1160 from spotify/ndudnik/unregister-component
Unregister component: front-end
2020-06-05 23:05:29 +02:00
Fredrik Adelöw 31bec057f1 Merge pull request #1162 from spotify/dependabot/npm_and_yarn/websocket-extensions-0.1.4
build(deps): [security] bump websocket-extensions from 0.1.3 to 0.1.4
2020-06-05 22:42:31 +02:00
dependabot-preview[bot] f7c9e3677a build(deps): [security] bump websocket-extensions from 0.1.3 to 0.1.4
Bumps [websocket-extensions](https://github.com/faye/websocket-extensions-node) from 0.1.3 to 0.1.4. **This update includes a security fix.**
- [Release notes](https://github.com/faye/websocket-extensions-node/releases)
- [Changelog](https://github.com/faye/websocket-extensions-node/blob/master/CHANGELOG.md)
- [Commits](https://github.com/faye/websocket-extensions-node/compare/0.1.3...0.1.4)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-06-05 20:25:18 +00:00
blam 72a7c73e9f feat(Catalog/tabs): added some sample tabs for now 2020-06-05 17:40:24 +02:00
Sebastian Qvarfordt 8742e85eb7 Added HeaderTabs to ComponentPage 2020-06-05 16:54:36 +02:00
Nikita Nek Dudnik 2744a98ac5 fix: import from package 2020-06-05 16:40:27 +02:00
Nikita Nek Dudnik a4f08e3fcc fix: type checking 2020-06-05 16:29:46 +02:00
Nikita Nek Dudnik 48a71d6300 fix: tests 2020-06-05 16:22:44 +02:00
Fredrik Adelöw a9ea32e57d Merge pull request #1159 from spotify/freben/yarnlock
Ran yarn install
2020-06-05 16:14:25 +02:00