19202 Commits

Author SHA1 Message Date
Fredrik Adelöw 9361965db9 Fix runCheck to ignore stdio of spawned process
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Fredrik Adelöw <freben@spotify.com>
2026-03-04 17:33:29 +01:00
Charles de Dreuille db927510dc Add new Interactive card
Signed-off-by: Charles de Dreuille <charles.dedreuille@gmail.com>
2026-03-04 15:24:23 +00:00
Ambrish R 400175a09d Update packages/ui/src/components/RangeSlider/definition.ts
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Ambrish R <ambrish.r@infosys.com>
2026-03-04 19:53:49 +05:30
AmbrishRamachandiran fd4708212d Fix review comments
Signed-off-by: AmbrishRamachandiran <ambrish.r@infosys.com>
2026-03-04 19:40:59 +05:30
AmbrishRamachandiran e62d94387f Fix review comments
Signed-off-by: AmbrishRamachandiran <ambrish.r@infosys.com>
2026-03-04 19:19:57 +05:30
AmbrishRamachandiran 6676b0e137 Fix review comments
Signed-off-by: AmbrishRamachandiran <ambrish.r@infosys.com>
2026-03-04 19:08:25 +05:30
AmbrishRamachandiran 6fd571914d Fix review comments
Signed-off-by: AmbrishRamachandiran <ambrish.r@infosys.com>
2026-03-04 18:49:57 +05:30
AmbrishRamachandiran cb9b307d44 Fix review comments
Signed-off-by: AmbrishRamachandiran <ambrish.r@infosys.com>
2026-03-04 18:28:27 +05:30
AmbrishRamachandiran d32f8282a5 Fix review comments
Signed-off-by: AmbrishRamachandiran <ambrish.r@infosys.com>
2026-03-04 18:14:28 +05:30
AmbrishRamachandiran 445fc101ac Fix review comments
Signed-off-by: AmbrishRamachandiran <ambrish.r@infosys.com>
2026-03-04 17:53:35 +05:30
AmbrishRamachandiran aeb2b53276 Fix review comments
Signed-off-by: AmbrishRamachandiran <ambrish.r@infosys.com>
2026-03-04 17:18:57 +05:30
AmbrishRamachandiran 5f5dcf9fea Fix review comments
Signed-off-by: AmbrishRamachandiran <ambrish.r@infosys.com>
2026-03-04 16:58:56 +05:30
AmbrishRamachandiran 53b2334152 Fix review comments
Signed-off-by: AmbrishRamachandiran <ambrish.r@infosys.com>
2026-03-04 16:43:21 +05:30
AmbrishRamachandiran 8d79835cc0 BUI - Add new range slider component
Signed-off-by: AmbrishRamachandiran <ambrish.r@infosys.com>
2026-03-04 16:21:26 +05:30
Patrik Oldsberg d757071651 Merge pull request #33082 from backstage/bui-migrate-catalog-entity-cards
feat(catalog,org): migrate entity cards from MUI/InfoCard to BUI
2026-03-04 11:50:41 +01:00
Patrik Oldsberg 80f1779980 Fix buildWorkspace flag normalization for =value forms
Handle --alwaysPack=value and --alwaysYarnPack=value variants in the
legacy flag normalization, not just the bare flag forms.

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Made-with: Cursor
2026-03-04 10:13:57 +01:00
Patrik Oldsberg e8173b3012 Address review feedback: role.ts, repo start params, test coverage
- Remove unnecessary optional chaining on getRoleInfo().role since it
  throws for unknown roles.
- Add parameters declaration to repo start so [packages...] shows in
  help output.
- Add tests verifying cleye strips Backstage flags from args before
  forwarding to Jest, including legacy camelCase flag support.

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Made-with: Cursor
2026-03-04 10:10:31 +01:00
Charles de Dreuille a5ff77fcbe Merge pull request #33102 from backstage/bui-select
bui(ui): improve Select trigger bg and focus ring
2026-03-04 08:15:21 +00:00
Ben Lambert 1513a0b132 Merge commit from fork
* Reject path traversal in SCM URL filepath parsing

* Harden parseGitUrlSafe against encoding bypass variants
2026-03-04 07:28:36 +01:00
Carl-Erik Bergström 545557a928 feat(backend-app-api): attribute registration errors to plugins/modules (#33029)
* feat(backend-app-api): attribute registration errors to plugins/modules

Signed-off-by: Carl-Erik Bergström <cbergstrom@spotify.com>
2026-03-03 19:12:44 +01:00
Charles de Dreuille bb66b8617b Improve Select style
Signed-off-by: Charles de Dreuille <charles.dedreuille@gmail.com>
2026-03-03 17:57:26 +00:00
Charles de Dreuille 95fecdf617 Merge pull request #33081 from backstage/ui/searchfield-textfield-bg-focus
feat(ui): bg-context support and focus ring for SearchField and TextField
2026-03-03 15:56:01 +00:00
Charles de Dreuille 62d674c3de Merge branch 'master' into ui/searchfield-textfield-bg-focus
# Conflicts:
#	packages/ui/src/components/PluginHeader/PluginHeader.module.css
#	packages/ui/src/components/PluginHeader/PluginHeader.tsx
#	packages/ui/src/components/PluginHeader/PluginHeaderToolbar.tsx
2026-03-03 14:16:54 +00:00
github-actions[bot] db0d171511 Version Packages (next) 2026-03-03 14:16:49 +00:00
Johan Persson 8211dc0f70 chore(ui): remove inline style from Button in Card story
Signed-off-by: Johan Persson <johanopersson@gmail.com>
2026-03-03 15:11:28 +01:00
Johan Persson 36987dbdfd chore(ui): add changesets and update API report
Signed-off-by: Johan Persson <johanopersson@gmail.com>
2026-03-03 15:11:28 +01:00
Johan Persson bfd121436b fix(ui): extend FieldLabelProps with native div element props
FieldLabel renders a div and spreads restProps onto it, but
FieldLabelProps didn't extend native div props. This meant
attributes like aria-*, data-*, role, etc. couldn't be
passed with type safety.

Signed-off-by: Johan Persson <johanopersson@gmail.com>
2026-03-03 15:11:28 +01:00
Johan Persson 8236a3d7c3 fix(ui): extend ContainerProps with native div element props
Container renders a div and spreads restProps onto it, but
ContainerProps didn't extend native div props. This meant
attributes like aria-*, data-*, role, etc. couldn't be
passed with type safety.

Signed-off-by: Johan Persson <johanopersson@gmail.com>
2026-03-03 15:11:28 +01:00
Johan Persson 68e0cc1468 fix(ui): extend AlertProps with native div element props
Alert renders a div and spreads restProps onto it, but
AlertProps didn't extend native div props. This meant
attributes like aria-*, data-*, role, etc. couldn't be
passed with type safety.

Signed-off-by: Johan Persson <johanopersson@gmail.com>
2026-03-03 15:11:28 +01:00
Johan Persson 6edae0e959 fix(ui): remove unused style prop from ButtonLinkOwnProps
The style prop was defined in ButtonLinkOwnProps but never
destructured or applied in the component, causing it to be
silently dropped. Removing it lets style flow through to the
underlying RAC Link via restProps instead.

Signed-off-by: Johan Persson <johanopersson@gmail.com>
2026-03-03 15:11:28 +01:00
Johan Persson 00bf7c7e42 fix(ui): remove unused style prop from ButtonOwnProps
The style prop was defined in ButtonOwnProps but never
destructured or applied in the component, causing it to be
silently dropped. Removing it lets style flow through to the
underlying RAC Button via restProps instead.

Signed-off-by: Johan Persson <johanopersson@gmail.com>
2026-03-03 15:11:28 +01:00
Johan Persson bd671414bb fix(ui): remove unused style prop from ButtonIconOwnProps
The style prop was defined in ButtonIconOwnProps but never
destructured or applied in the component, causing it to be
silently dropped. Removing it lets style flow through to the
underlying RAC Button via restProps instead.

Signed-off-by: Johan Persson <johanopersson@gmail.com>
2026-03-03 15:11:28 +01:00
Johan Persson 8d40a035dc fix(ui): extend DialogBodyProps with native div element props
DialogBodyProps previously only extended DialogBodyOwnProps,
meaning native HTML attributes like aria-*, data-*, etc.
could not be passed to the underlying div element.

Signed-off-by: Johan Persson <johanopersson@gmail.com>
2026-03-03 15:11:28 +01:00
Charles de Dreuille e8c8e0fe30 Merge pull request #33085 from backstage/cdedreuille/merge-plugin-header-toolbar
Style improvements on PluginHeader
2026-03-03 14:01:27 +00:00
Andre Wanlin 21d8beec83 Merge pull request #33083 from backstage/visibility
Update Azure integration config visibility
2026-03-03 06:49:36 -06:00
Johan Persson 20cb5117e1 fix: remove variant prop from create-app template for migrated cards
The E2E tests scaffold a new app from the create-app template,
which still passed variant="gridItem" to EntityAboutCard,
EntityUserProfileCard, and EntityGroupProfileCard after the prop
was removed.

Signed-off-by: Johan Persson <johanopersson@gmail.com>
2026-03-03 12:17:35 +01:00
Johan Persson c4832a18d1 refactor: Remove obsolete variant prop from Entity card components.
Signed-off-by: Johan Persson <johanopersson@gmail.com>
2026-03-03 12:17:34 +01:00
Patrik Oldsberg 629e9f5558 Add deprecation warnings for old camelCase flag names
Instead of a hard breaking change, the old camelCase flag names
(--baseVersion, --successCache, --successCacheDir, --alwaysPack) still
work via type-flag's built-in camelCase/kebab-case mapping, but now
print a deprecation warning pointing to the new kebab-case spelling.

Downgrades the changeset from minor (breaking) to patch.

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Made-with: Cursor
2026-03-03 11:11:26 +01:00
Patrik Oldsberg b45ee80104 Keep boolean | string for inspect types, map in command handlers
Move the empty-string-to-boolean conversion from cleye's String type
into the command handlers so that startPackage/runBackend keep their
existing boolean | string interface.

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Made-with: Cursor
2026-03-03 11:11:26 +01:00
Patrik Oldsberg 2946e8e4c6 Remove custom inspect flag handling, switch repo test to cleye
- Use cleye's `type: String` for --inspect/--inspect-brk instead of
  custom extractInspectFlags pre-processing in both package start and
  repo start commands.
- Switch repo test from node:util parseArgs to cleye so that --help
  shows Backstage-specific flags rather than dumping Jest's full help.
- Fix create-github-app help output to include <github-org> positional.
- Update downstream inspect types from `boolean | string` to `string`.

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Made-with: Cursor
2026-03-03 11:11:26 +01:00
Patrik Oldsberg 18d09fe581 Address Copilot review feedback
- Handle --inspect/--inspect-brk optional host value by extracting
  them from raw args before passing to cleye (supports both bare
  --inspect and --inspect=host:port forms)
- Change require flag from [String] to String in package start since
  downstream only accepts a single value
- Preserve legacy --alwaysYarnPack alias in build-workspace command
- Update changeset to mention camelCase → kebab-case flag changes

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2026-03-03 11:11:26 +01:00
Patrik Oldsberg f01dbf301e Use shell-quote for script argument parsing
Replace custom splitShellArgs with shell-quote's parse() for proper
shell argument tokenization in createScriptOptionsParser.

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2026-03-03 11:11:26 +01:00
Patrik Oldsberg eb73feac15 Address review feedback and regenerate API reports
- Handle quoted arguments in createScriptOptionsParser using a proper
  shell-like splitter instead of naive whitespace splitting
- Pass CommandContext directly in bump tests instead of using a helper
- Regenerate cli-report.md

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2026-03-03 11:11:26 +01:00
Patrik Oldsberg ff4a45ac01 Migrate remaining CLI commands from commander to cleye
All command handlers in the CLI now use cleye or node:util.parseArgs
for argument parsing instead of commander. The top-level command
registration in CliInitializer still uses commander, but all individual
command implementations are now independent of it.

Modules migrated: build, lint, test, maintenance, migrate, new, and
create-github-app. Also replaced createScriptOptionsParser in both
build and lint modules to use node:util.parseArgs instead of commander.

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2026-03-03 11:11:26 +01:00
Patrik Oldsberg 11764eff33 cli: remove stale lib/lazy.ts from previous stash
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Made-with: Cursor
2026-03-02 20:50:26 +01:00
Patrik Oldsberg e8a5a20f7d cli: split pack.ts into prepack.ts and postpack.ts
Each file now has a default export matching the CommandExecuteFn
pattern, removing the need for import wrapping in the loader.

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Made-with: Cursor
2026-03-02 20:49:56 +01:00
James Brooks d73ac23f1e Merge branch 'master' into visibility 2026-03-02 19:08:00 +00:00
Charles de Dreuille 4105a78f98 Style improvements on PluginHeader
Signed-off-by: Charles de Dreuille <charles.dedreuille@gmail.com>
2026-03-02 19:07:03 +00:00
Charles de Dreuille 077674b93b Update report.api.md
Signed-off-by: Charles de Dreuille <charles.dedreuille@gmail.com>
2026-03-02 17:44:25 +00:00
Charles de Dreuille eee3c14329 Fix SearchField styles
Signed-off-by: Charles de Dreuille <charles.dedreuille@gmail.com>
2026-03-02 17:31:53 +00:00