refactor: apply review suggestions

Co-authored-by: Patrik Oldsberg <poldsberg@gmail.com>
Signed-off-by: Camila Belo <camilaibs@gmail.com>

packages/backend-plugin-api/api-report.md

@@ -325,13 +325,11 @@ export interface HttpAuthService {
   issueUserCookie(
     res: Response_2,
     options?: {
-      credentials?: BackstageCredentials<BackstageUserPrincipal>;
+      credentials?: BackstageCredentials;
     },
   ): Promise<{
     expiresAt: Date;
   }>;
-  // (undocumented)
-  removeUserCookie(res: Response_2): void;
 }
 
 // @public (undocumented)

packages/backend-plugin-api/src/services/definitions/HttpAuthService.ts

@@ -15,11 +15,7 @@
  */
 
 import { Request, Response } from 'express';
-import {
-  BackstageCredentials,
-  BackstagePrincipalTypes,
-  BackstageUserPrincipal,
-} from './AuthService';
+import { BackstageCredentials, BackstagePrincipalTypes } from './AuthService';
 
 /** @public */
 export interface HttpAuthService {
@@ -34,9 +30,7 @@ export interface HttpAuthService {
   issueUserCookie(
     res: Response,
     options?: {
-      credentials?: BackstageCredentials<BackstageUserPrincipal>;
+      credentials?: BackstageCredentials;
     },
   ): Promise<{ expiresAt: Date }>;
-
-  removeUserCookie(res: Response): void;
 }