feat: pr review fixes + changeset

Signed-off-by: Kamil Wolny <mrwolny@gmail.com>
This commit is contained in:
Kamil Wolny
2022-08-02 10:35:51 +01:00
parent d51e5223d6
commit ffd5e47fb5
7 changed files with 23 additions and 86 deletions
+6 -2
View File
@@ -8,8 +8,6 @@
import { BackstagePlugin } from '@backstage/core-plugin-api';
import { RouteRef } from '@backstage/core-plugin-api';
// Warning: (ae-forgotten-export) The symbol "GitHubIssuesProps" needs to be exported by the entry point index.d.ts
//
// @public (undocumented)
export const GitHubIssuesCard: ({
itemsPerPage,
@@ -31,5 +29,11 @@ export const gitHubIssuesPlugin: BackstagePlugin<
{}
>;
// @public (undocumented)
export type GitHubIssuesProps = {
itemsPerPage?: number;
itemsPerRepo?: number;
};
// (No @packageDocumentation comment for this package)
```
+2 -2
View File
@@ -32,9 +32,9 @@
"@material-ui/core": "^4.12.4",
"@material-ui/icons": "^4.9.1",
"@material-ui/lab": "^4.0.0-alpha.61",
"@octokit/rest": "^18.12.0",
"@types/react": "^16.13.1 || ^17.0.0",
"luxon": "^2.4.0",
"octokit": "^2.0.4",
"react-use": "^17.2.4"
},
"peerDependencies": {
@@ -52,7 +52,7 @@
"@types/jest": "*",
"@types/node": "*",
"cross-fetch": "^3.1.5",
"msw": "^0.42.0",
"msw": "^0.44.0",
"prettier": "^2.7.1"
},
"files": [
@@ -28,15 +28,17 @@ import {
import { IssueList } from './IssuesList';
import { NoRepositoriesInfo } from './NoRepositoriesInfo';
/**
* @public
*/
export type GitHubIssuesProps = {
itemsPerPage?: number;
itemsPerRepo?: number;
};
export const GitHubIssues = ({
itemsPerPage = 10,
itemsPerRepo = 40,
}: GitHubIssuesProps) => {
export const GitHubIssues = (props: GitHubIssuesProps) => {
const { itemsPerPage = 10, itemsPerRepo = 40 } = props;
const [isLoading, setIsLoading] = React.useState(true);
const [issuesByRepository, setIssuesByRepository] =
@@ -13,7 +13,7 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
import { Octokit } from '@octokit/rest';
import { Octokit } from 'octokit';
import {
useApi,
githubAuthApiRef,
+2
View File
@@ -18,3 +18,5 @@ export {
GitHubIssuesPage,
GitHubIssuesCard,
} from './plugin';
export type { GitHubIssuesProps } from './components/GitHubIssues';