From ff59698e4e6910739eab7d42150d27bd8d144402 Mon Sep 17 00:00:00 2001 From: Johan Haals Date: Tue, 19 Jan 2021 15:33:39 +0100 Subject: [PATCH] Remove old comments --- .../scaffolder/stages/prepare/preparers.ts | 19 +++---------------- 1 file changed, 3 insertions(+), 16 deletions(-) diff --git a/plugins/scaffolder-backend/src/scaffolder/stages/prepare/preparers.ts b/plugins/scaffolder-backend/src/scaffolder/stages/prepare/preparers.ts index b1d1edf00b..9a209f4860 100644 --- a/plugins/scaffolder-backend/src/scaffolder/stages/prepare/preparers.ts +++ b/plugins/scaffolder-backend/src/scaffolder/stages/prepare/preparers.ts @@ -21,13 +21,7 @@ import { GitlabPreparer } from './gitlab'; import { AzurePreparer } from './azure'; import { GithubPreparer } from './github'; import { BitbucketPreparer } from './bitbucket'; -import { - readAzureIntegrationConfigs, - readBitbucketIntegrationConfigs, - readGitHubIntegrationConfigs, - readGitLabIntegrationConfigs, - ScmIntegrations, -} from '@backstage/integration'; +import { ScmIntegrations } from '@backstage/integration'; export class Preparers implements PreparerBuilder { private preparerMap = new Map(); @@ -46,14 +40,7 @@ export class Preparers implements PreparerBuilder { return preparer; } - static async fromConfig( - config: Config, - // { logger }: { logger: Logger }, - ): Promise { - // TODO(blam/jhaals) - // iterate through the integration configs for each provider, and create the preparer - // register the preparer to hostname. - // if no preparer is returned for the hostname fromConfig, use the backup token credentials from scaffolder block and warn + static async fromConfig(config: Config): Promise { const preparers = new Preparers(); const scm = ScmIntegrations.fromConfig(config); for (const integration of scm.azure.list()) { @@ -73,7 +60,7 @@ export class Preparers implements PreparerBuilder { for (const integration of scm.gitlab.list()) { preparers.register( integration.config.host, - GitlabPreparer.fromConfig(integration), + GitlabPreparer.fromConfig(integration.config), ); }