From ff131b5fd33db84ae01d6067a996a50822223ba7 Mon Sep 17 00:00:00 2001
From: yousifalraheem <yousifalraheem@gmail.com>
Date: Mon, 4 Apr 2022 15:45:12 +0200
Subject: [PATCH] fix SettingsPage tests

Signed-off-by: Yousif Al-Raheem <yousifalraheem@gmail.com>
---
 .../src/components/SettingsPage.test.tsx      | 35 +++++--------------
 1 file changed, 8 insertions(+), 27 deletions(-)

diff --git a/plugins/user-settings/src/components/SettingsPage.test.tsx b/plugins/user-settings/src/components/SettingsPage.test.tsx
index 865d0918e7..01810bcc8e 100644
--- a/plugins/user-settings/src/components/SettingsPage.test.tsx
+++ b/plugins/user-settings/src/components/SettingsPage.test.tsx
@@ -27,6 +27,10 @@ jest.mock('react-router', () => ({
 import { useOutlet } from 'react-router';
 
 describe('<SettingsPage />', () => {
+  beforeEach(() => {
+    (useOutlet as jest.Mock).mockReset();
+  });
+
   it('should render the settings page with 3 tabs', async () => {
     const { container } = await renderWithEffects(
       wrapInTestApp(<SettingsPage />),
@@ -38,13 +42,11 @@ describe('<SettingsPage />', () => {
 
   it('should render the settings page with 4 tabs when extra tabs are provided', async () => {
     const advancedTabRoute = (
-      <>
-        <UserSettingsTab path="/advanced" title="Advanced">
-          <div>Advanced settings</div>
-        </UserSettingsTab>
-      </>
+      <UserSettingsTab path="/advanced" title="Advanced">
+        <div>Advanced settings</div>
+      </UserSettingsTab>
     );
-    (useOutlet as jest.Mock).mockReturnValueOnce(advancedTabRoute);
+    (useOutlet as jest.Mock).mockReturnValue(advancedTabRoute);
     const { container } = await renderWithEffects(
       wrapInTestApp(<SettingsPage />),
     );
@@ -53,25 +55,4 @@ describe('<SettingsPage />', () => {
     expect(tabs).toHaveLength(4);
     expect(tabs[3].textContent).toEqual('Advanced');
   });
-
-  it('should throw error if non compliant route is passed to settings routes', async () => {
-    const advancedTabRoute = (
-      <>
-        <UserSettingsTab path="/advanced" title="Advanced">
-          <div>Advanced settings</div>
-        </UserSettingsTab>
-        <div>Non compliant element</div>
-      </>
-    );
-    (useOutlet as jest.Mock).mockReturnValueOnce(advancedTabRoute);
-    let error: Error;
-    try {
-      await renderWithEffects(wrapInTestApp(<SettingsPage />));
-    } catch (err) {
-      error = err;
-    }
-    expect(error!.message).toEqual(
-      expect.stringContaining('Invalid element passed'),
-    );
-  });
 });