From feed6f73194c6dc6f8b163bf6f083d615c88a2c7 Mon Sep 17 00:00:00 2001
From: Alper Altay <alper.altay@lego.com>
Date: Mon, 18 Mar 2024 20:01:52 +0100
Subject: [PATCH] perf: added workspaces foreach instead of concurrently

Signed-off-by: Alper Altay <alper.altay@lego.com>
---
 package.json |  7 +++----
 yarn.lock    | 29 ++++-------------------------
 2 files changed, 7 insertions(+), 29 deletions(-)

diff --git a/package.json b/package.json
index 7c26d45577..3d62693aae 100644
--- a/package.json
+++ b/package.json
@@ -23,8 +23,8 @@
     "build:plugins-report": "node ./scripts/build-plugins-report",
     "clean": "backstage-cli repo clean",
     "create-plugin": "echo \"use 'yarn new' instead\"",
-    "dev": "concurrently 'yarn start' 'yarn start-backend'",
-    "dev:next": "concurrently 'yarn start:next' 'yarn start-backend:next'",
+    "dev": "yarn workspaces foreach -A --include example-backend --include example-app --parallel -v -i run start",
+    "dev:next": "yarn workspaces foreach -A --include example-backend-next --include example-app-next --parallel -v -i run start",
     "docker-build": "yarn tsc && yarn workspace example-backend build && yarn workspace example-backend build-image",
     "fix": "backstage-cli repo fix",
     "postinstall": "husky || true",
@@ -42,7 +42,7 @@
     "start": "yarn workspace example-app start",
     "start-backend": "yarn workspace example-backend start",
     "start-backend:next": "yarn workspace example-backend-next start",
-    "start:lighthouse": "concurrently 'yarn start' 'yarn start-backend:next'",
+    "start:lighthouse": "yarn workspaces foreach -A --include example-backend-next --include example-app --parallel -v -i run start",
     "start:microsite": "cd microsite/ && yarn start",
     "start:next": "yarn workspace example-app-next start",
     "storybook": "yarn ./storybook run start",
@@ -110,7 +110,6 @@
     "@types/node": "^18.17.8",
     "@types/webpack": "^5.28.0",
     "command-exists": "^1.2.9",
-    "concurrently": "^8.0.0",
     "cross-env": "^7.0.0",
     "e2e-test": "workspace:*",
     "eslint": "^8.6.0",
diff --git a/yarn.lock b/yarn.lock
index a0d94a3027..4afae36de0 100644
--- a/yarn.lock
+++ b/yarn.lock
@@ -24126,26 +24126,6 @@ __metadata:
   languageName: node
   linkType: hard
 
-"concurrently@npm:^8.0.0":
-  version: 8.2.2
-  resolution: "concurrently@npm:8.2.2"
-  dependencies:
-    chalk: ^4.1.2
-    date-fns: ^2.30.0
-    lodash: ^4.17.21
-    rxjs: ^7.8.1
-    shell-quote: ^1.8.1
-    spawn-command: 0.0.2
-    supports-color: ^8.1.1
-    tree-kill: ^1.2.2
-    yargs: ^17.7.2
-  bin:
-    conc: dist/bin/concurrently.js
-    concurrently: dist/bin/concurrently.js
-  checksum: 8ac774df06869773438f1bf91025180c52d5b53139bc86cf47659136c0d97461d0579c515d848d1e945d4e3e0cafe646b2ea18af8d74259b46abddcfe39b2c6c
-  languageName: node
-  linkType: hard
-
 "conf@npm:^10.2.0":
   version: 10.2.0
   resolution: "conf@npm:10.2.0"
@@ -25270,7 +25250,7 @@ __metadata:
   languageName: node
   linkType: hard
 
-"date-fns@npm:^2.16.1, date-fns@npm:^2.18.0, date-fns@npm:^2.30.0":
+"date-fns@npm:^2.16.1, date-fns@npm:^2.18.0":
   version: 2.30.0
   resolution: "date-fns@npm:2.30.0"
   dependencies:
@@ -41350,7 +41330,6 @@ __metadata:
     "@types/webpack": ^5.28.0
     "@useoptic/optic": ^0.50.10
     command-exists: ^1.2.9
-    concurrently: ^8.0.0
     cross-env: ^7.0.0
     e2e-test: "workspace:*"
     eslint: ^8.6.0
@@ -41446,7 +41425,7 @@ __metadata:
   languageName: node
   linkType: hard
 
-"rxjs@npm:7.8.1, rxjs@npm:^7.2.0, rxjs@npm:^7.5.5, rxjs@npm:^7.8.1":
+"rxjs@npm:7.8.1, rxjs@npm:^7.2.0, rxjs@npm:^7.5.5":
   version: 7.8.1
   resolution: "rxjs@npm:7.8.1"
   dependencies:
@@ -41982,7 +41961,7 @@ __metadata:
   languageName: node
   linkType: hard
 
-"shell-quote@npm:^1.7.3, shell-quote@npm:^1.8.1":
+"shell-quote@npm:^1.7.3":
   version: 1.8.1
   resolution: "shell-quote@npm:1.8.1"
   checksum: 5f01201f4ef504d4c6a9d0d283fa17075f6770bfbe4c5850b074974c68062f37929ca61700d95ad2ac8822e14e8c4b990ca0e6e9272e64befd74ce5e19f0736b
@@ -42409,7 +42388,7 @@ __metadata:
   languageName: node
   linkType: hard
 
-"spawn-command@npm:0.0.2, spawn-command@npm:^0.0.2-1":
+"spawn-command@npm:^0.0.2-1":
   version: 0.0.2
   resolution: "spawn-command@npm:0.0.2"
   checksum: e35c5d28177b4d461d33c88cc11f6f3a5079e2b132c11e1746453bbb7a0c0b8a634f07541a2a234fa4758239d88203b758def509161b651e81958894c0b4b64b