From 2a942cc9e93d40156a27bc66776d32b087822d68 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fredrik=20Adel=C3=B6w?= Date: Thu, 27 May 2021 15:50:30 +0200 Subject: [PATCH] invert logic for when to show type column MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Fredrik Adelöw --- .changeset/little-bobcats-explode.md | 5 +++++ plugins/catalog/src/components/CatalogTable/CatalogTable.tsx | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) create mode 100644 .changeset/little-bobcats-explode.md diff --git a/.changeset/little-bobcats-explode.md b/.changeset/little-bobcats-explode.md new file mode 100644 index 0000000000..c031fde505 --- /dev/null +++ b/.changeset/little-bobcats-explode.md @@ -0,0 +1,5 @@ +--- +'@backstage/plugin-catalog': patch +--- + +invert logic for when to show type column diff --git a/plugins/catalog/src/components/CatalogTable/CatalogTable.tsx b/plugins/catalog/src/components/CatalogTable/CatalogTable.tsx index 57b25455ba..b42dbe02b7 100644 --- a/plugins/catalog/src/components/CatalogTable/CatalogTable.tsx +++ b/plugins/catalog/src/components/CatalogTable/CatalogTable.tsx @@ -60,7 +60,7 @@ export const CatalogTable = ({ columns }: CatalogTableProps) => { const { isStarredEntity, toggleStarredEntity } = useStarredEntities(); const { loading, error, entities, filters } = useEntityListProvider(); - const showTypeColumn = filters.type !== undefined; + const showTypeColumn = filters.type === undefined; // TODO(timbonicus): we should show filter chips for all filters instead const titlePreamble = capitalize(filters.user?.value ?? 'all');