fix review comments

Signed-off-by: Fredrik Adelöw <freben@gmail.com>
This commit is contained in:
Fredrik Adelöw
2021-03-10 13:48:43 +01:00
parent 8686eb38cf
commit fda249ff6f
28 changed files with 511 additions and 296 deletions
@@ -116,7 +116,7 @@ describe('parseEntityYaml', () => {
});
it('should handle empty yaml documents', () => {
// This happens if the user accidentially adds a "---"
// This happens if the user accidentally adds a "---"
// at the end of a file
const results = Array.from(
parseEntityYaml(
@@ -205,7 +205,7 @@ describe('parseEntityYaml', () => {
it('must be an object at root', () => {
const results = Array.from(
parseEntityYaml(Buffer.from('imma-string', 'utf8'), testLoc),
parseEntityYaml(Buffer.from('i-am-a-string', 'utf8'), testLoc),
);
expect(results).toEqual([
@@ -15,12 +15,12 @@
*/
import { errorHandler } from '@backstage/backend-common';
import { NotFoundError } from '@backstage/errors';
import type { Entity } from '@backstage/catalog-model';
import {
analyzeLocationSchema,
locationSpecSchema,
} from '@backstage/catalog-model';
import { NotFoundError } from '@backstage/errors';
import express from 'express';
import Router from 'express-promise-router';
import { Logger } from 'winston';
@@ -20,12 +20,12 @@ import {
} from '@backstage/catalog-model';
import {
Content,
ErrorResponsePanel,
Header,
HeaderLabel,
Link,
Page,
Progress,
ResponseErrorPanel,
WarningPanel,
} from '@backstage/core';
import {
@@ -143,7 +143,7 @@ export const EntityPageLayout = ({ children }: PropsWithChildren<{}>) => {
{error && (
<Content>
<ErrorResponsePanel error={error} />
<ResponseErrorPanel error={error} />
</Content>
)}