diff --git a/packages/core/src/layout/Header/Header.stories.tsx b/packages/core/src/layout/Header/Header.stories.tsx
index b902a709cf..cc0276224a 100644
--- a/packages/core/src/layout/Header/Header.stories.tsx
+++ b/packages/core/src/layout/Header/Header.stories.tsx
@@ -41,11 +41,9 @@ export const Home = () => (
);
export const HomeWithSubtitle = () => (
-
-
-
+
);
export const Tool = () => (
diff --git a/packages/core/src/layout/Header/Header.test.tsx b/packages/core/src/layout/Header/Header.test.tsx
index 00c5bfa2bd..e5dc7fec4d 100644
--- a/packages/core/src/layout/Header/Header.test.tsx
+++ b/packages/core/src/layout/Header/Header.test.tsx
@@ -15,10 +15,8 @@
*/
import React from 'react';
-import { act, render, RenderResult } from '@testing-library/react';
+import { render } from '@testing-library/react';
import { wrapInTestApp } from '@backstage/test-utils';
-import { ThemeProvider } from '@material-ui/core';
-import { customPageTheme } from '@backstage/theme';
import { Header } from './Header';
jest.mock('react-helmet', () => {
@@ -27,73 +25,37 @@ jest.mock('react-helmet', () => {
};
});
-const ThemeProviderWrapper: React.FC = ({ children }) => (
-
- {children}
-
-);
-
describe('', () => {
it('should render with title', async () => {
- let rendered: RenderResult | undefined;
- await act(async () => {
- rendered = render(wrapInTestApp(), {
- wrapper: ThemeProviderWrapper,
- });
- });
- rendered?.getByText('Title');
+ const rendered = render(wrapInTestApp());
+ rendered.getByText('Title');
});
it('should set document title', async () => {
- let rendered: RenderResult | undefined;
- await act(async () => {
- rendered = render(wrapInTestApp(), {
- wrapper: ThemeProviderWrapper,
- });
- });
- rendered?.getByText('Title1');
- rendered?.getByText('defaultTitle: Title1 | Backstage');
+ const rendered = render(wrapInTestApp());
+ rendered.getByText('Title1');
+ rendered.getByText('defaultTitle: Title1 | Backstage');
});
it('should override document title', async () => {
- let rendered: RenderResult | undefined;
- await act(async () => {
- rendered = render(
- wrapInTestApp(),
- {
- wrapper: ThemeProviderWrapper,
- },
- );
- });
- rendered?.getByText('Title1');
- rendered?.getByText('defaultTitle: Title2 | Backstage');
+ const rendered = render(
+ wrapInTestApp(),
+ );
+ rendered.getByText('Title1');
+ rendered.getByText('defaultTitle: Title2 | Backstage');
});
it('should have subtitle', async () => {
- let rendered: RenderResult | undefined;
- await act(async () => {
- rendered = render(
- wrapInTestApp(),
- {
- wrapper: ThemeProviderWrapper,
- },
- );
- });
- rendered?.getByText('Subtitle');
+ const rendered = render(
+ wrapInTestApp(),
+ );
+ rendered.getByText('Subtitle');
});
it('should have type rendered', async () => {
- let rendered: RenderResult | undefined;
- await act(async () => {
- rendered = render(wrapInTestApp(), {
- wrapper: ThemeProviderWrapper,
- });
- });
- rendered?.getByText('tool');
+ const rendered = render(
+ wrapInTestApp(),
+ );
+ rendered.getByText('tool');
});
});
diff --git a/packages/core/src/layout/Header/Header.tsx b/packages/core/src/layout/Header/Header.tsx
index dc71fe333b..41840b6ff0 100644
--- a/packages/core/src/layout/Header/Header.tsx
+++ b/packages/core/src/layout/Header/Header.tsx
@@ -17,7 +17,11 @@
import React, { ReactNode, CSSProperties, FC } from 'react';
import { Helmet } from 'react-helmet';
import { Typography, Tooltip, makeStyles, useTheme } from '@material-ui/core';
-import { BackstageTheme, BackstagePageThemeConsumer } from '@backstage/theme';
+import {
+ BackstageTheme,
+ BackstagePageThemeConsumer,
+ customPageTheme,
+} from '@backstage/theme';
const useStyles = makeStyles(
theme => ({
@@ -163,7 +167,9 @@ export const Header: FC = ({
}) => {
const theme = useTheme();
const classes = useStyles({
- backgroundImage: theme.pageTheme.backgroundImage,
+ backgroundImage:
+ theme.pageTheme?.backgroundImage ??
+ customPageTheme.pageTheme.home.backgroundImage,
});
const documentTitle = pageTitleOverride || title;
const pageTitle = title || pageTitleOverride;