From fcee1ce391f6e21c86602ee24ff1da237a9a133d Mon Sep 17 00:00:00 2001
From: Vincenzo Scamporlino <vincenzos@spotify.com>
Date: Tue, 7 May 2024 15:04:54 +0200
Subject: [PATCH] techdocs-backend: fix build strategy tests

Signed-off-by: Vincenzo Scamporlino <vincenzos@spotify.com>
---
 .../service/DefaultDocsBuildStrategy.test.ts  | 46 ++++++++++---------
 1 file changed, 24 insertions(+), 22 deletions(-)

diff --git a/plugins/techdocs-backend/src/service/DefaultDocsBuildStrategy.test.ts b/plugins/techdocs-backend/src/service/DefaultDocsBuildStrategy.test.ts
index 7868135b08..714a3736a9 100644
--- a/plugins/techdocs-backend/src/service/DefaultDocsBuildStrategy.test.ts
+++ b/plugins/techdocs-backend/src/service/DefaultDocsBuildStrategy.test.ts
@@ -17,12 +17,6 @@
 import { DefaultDocsBuildStrategy } from './DefaultDocsBuildStrategy';
 import { ConfigReader } from '@backstage/config';
 
-const MockedConfigReader = ConfigReader as jest.MockedClass<
-  typeof ConfigReader
->;
-
-jest.mock('@backstage/config');
-
 describe('DefaultDocsBuildStrategy', () => {
   const entity = {
     apiVersion: 'backstage.io/v1alpha1',
@@ -33,32 +27,40 @@ describe('DefaultDocsBuildStrategy', () => {
     },
   };
 
-  const config = new ConfigReader({});
-
-  beforeEach(() => {
-    jest.resetAllMocks();
-  });
-
   describe('shouldBuild', () => {
-    it('should return true when techdocs.build is set to local', async () => {
-      const defaultDocsBuildStrategy =
-        DefaultDocsBuildStrategy.fromConfig(config);
-
-      MockedConfigReader.prototype.getString.mockReturnValue('local');
+    it('should return true when techdocs.builder is set to local', async () => {
+      const defaultDocsBuildStrategy = DefaultDocsBuildStrategy.fromConfig(
+        new ConfigReader({
+          techdocs: {
+            builder: 'local',
+          },
+        }),
+      );
 
       const result = await defaultDocsBuildStrategy.shouldBuild({ entity });
 
       expect(result).toBe(true);
     });
 
-    it('should return false when techdocs.build is set to external', async () => {
-      const defaultDocsBuildStrategy =
-        DefaultDocsBuildStrategy.fromConfig(config);
-
-      MockedConfigReader.prototype.getString.mockReturnValue('external');
+    it('should return true when techdocs.builder is not set', async () => {
+      const defaultDocsBuildStrategy = DefaultDocsBuildStrategy.fromConfig(
+        new ConfigReader({ techdocs: {} }),
+      );
 
       const result = await defaultDocsBuildStrategy.shouldBuild({ entity });
+      expect(result).toBe(true);
+    });
 
+    it('should return false when techdocs.builder is set to external', async () => {
+      const defaultDocsBuildStrategy = DefaultDocsBuildStrategy.fromConfig(
+        new ConfigReader({
+          techdocs: {
+            builder: 'external',
+          },
+        }),
+      );
+
+      const result = await defaultDocsBuildStrategy.shouldBuild({ entity });
       expect(result).toBe(false);
     });
   });