could it be?

Signed-off-by: Morgan Bentell <mbentell@spotify.com>
2023-03-16 18:46:39 +01:00
parent 68c7082188
commit fc1665944b
1 changed files with 10 additions and 4 deletions
@@ -123,7 +123,7 @@ export const TechDocsReaderPageProvider = memo(
      return techdocsApi.getEntityMetadata(entityRef);
    }, [entityRef]);

-    const metadata = useAsyncRetry(() => {
+    const metadata = useAsyncRetry(async () => {
      return techdocsApi.getTechDocsMetadata(entityRef);
    }, [entityRef]);

@@ -136,12 +136,18 @@ export const TechDocsReaderPageProvider = memo(
    );

    useEffect(() => {
-      if (shadowRoot && !metadata.loading && !metadata.value) {
+      if (shadowRoot && !metadata.value && !metadata.loading) {
        metadata.retry();
      }
-    }, [metadata, shadowRoot]);
+    }, [
+      metadata.value,
+      metadata.loading,
+      shadowRoot,
+      metadata.retry,
+      metadata,
+    ]);

-    const value = {
+    const value: TechDocsReaderPageValue = {
      metadata,
      entityRef: toLowercaseEntityRefMaybe(entityRef, config),
      entityMetadata,