diff --git a/packages/frontend-plugin-api/src/extensions/createApiExtension.test.ts b/packages/frontend-plugin-api/src/extensions/createApiExtension.test.ts index a3662e5ef1..b868fb235c 100644 --- a/packages/frontend-plugin-api/src/extensions/createApiExtension.test.ts +++ b/packages/frontend-plugin-api/src/extensions/createApiExtension.test.ts @@ -38,10 +38,13 @@ describe('createApiExtension', () => { configSchema: undefined, inputs: {}, output: { - api: { + api: expect.objectContaining({ $$type: 'extension-data', id: 'core.api.factory', - }, + config: { + optional: false, + }, + }), }, factory: expect.any(Function), }); @@ -71,10 +74,13 @@ describe('createApiExtension', () => { configSchema: undefined, inputs: {}, output: { - api: { + api: expect.objectContaining({ $$type: 'extension-data', id: 'core.api.factory', - }, + config: { + optional: false, + }, + }), }, factory: expect.any(Function), }); diff --git a/packages/frontend-plugin-api/src/extensions/createApiExtension.ts b/packages/frontend-plugin-api/src/extensions/createApiExtension.ts index 057addc4a8..f81f07ca72 100644 --- a/packages/frontend-plugin-api/src/extensions/createApiExtension.ts +++ b/packages/frontend-plugin-api/src/extensions/createApiExtension.ts @@ -18,7 +18,7 @@ import { AnyApiFactory, AnyApiRef } from '@backstage/core-plugin-api'; import { PortableSchema } from '../schema'; import { AnyExtensionDataMap, - ExtensionDataValue, + ExtensionDataInputValues, createExtension, coreExtensionData, } from '../wiring'; @@ -33,11 +33,7 @@ export function createApiExtension< api: AnyApiRef; factory: (options: { config: TConfig; - inputs: { - [pointName in keyof TInputs]: ExtensionDataValue< - TInputs[pointName]['extensionData'] - >[]; - }; + inputs: ExtensionDataInputValues; }) => AnyApiFactory; } | { diff --git a/packages/frontend-plugin-api/src/extensions/createPageExtension.test.tsx b/packages/frontend-plugin-api/src/extensions/createPageExtension.test.tsx index e5939d24ea..db389ae4b1 100644 --- a/packages/frontend-plugin-api/src/extensions/createPageExtension.test.tsx +++ b/packages/frontend-plugin-api/src/extensions/createPageExtension.test.tsx @@ -42,6 +42,7 @@ describe('createPageExtension', () => { output: { component: expect.anything(), path: expect.anything(), + routeRef: expect.anything(), }, factory: expect.any(Function), }); @@ -73,6 +74,7 @@ describe('createPageExtension', () => { output: { component: expect.anything(), path: expect.anything(), + routeRef: expect.anything(), }, factory: expect.any(Function), }); @@ -93,6 +95,7 @@ describe('createPageExtension', () => { output: { component: expect.anything(), path: expect.anything(), + routeRef: expect.anything(), }, factory: expect.any(Function), }); diff --git a/packages/frontend-plugin-api/src/extensions/createPageExtension.tsx b/packages/frontend-plugin-api/src/extensions/createPageExtension.tsx index f1d10153b5..167dd397dd 100644 --- a/packages/frontend-plugin-api/src/extensions/createPageExtension.tsx +++ b/packages/frontend-plugin-api/src/extensions/createPageExtension.tsx @@ -23,7 +23,7 @@ import { coreExtensionData, createExtension, Extension, - ExtensionDataValue, + ExtensionDataInputValues, } from '../wiring'; /** @@ -50,11 +50,7 @@ export function createPageExtension< routeRef?: RouteRef; component: (props: { config: TConfig; - inputs: { - [pointName in keyof TInputs]: ExtensionDataValue< - TInputs[pointName]['extensionData'] - >[]; - }; + inputs: ExtensionDataInputValues; }) => Promise; }, ): Extension {