diff --git a/packages/core/src/layout/Breadcrumbs/Breadcrumbs.stories.tsx b/packages/core/src/layout/Breadcrumbs/Breadcrumbs.stories.tsx index f2a6611d03..6f0ef0cb69 100644 --- a/packages/core/src/layout/Breadcrumbs/Breadcrumbs.stories.tsx +++ b/packages/core/src/layout/Breadcrumbs/Breadcrumbs.stories.tsx @@ -13,12 +13,13 @@ * See the License for the specific language governing permissions and * limitations under the License. */ -import { Popover, Typography, Box, List, ListItem } from '@material-ui/core'; -import ExpandMoreIcon from '@material-ui/icons/ExpandMore'; +import { Box, List, ListItem, Popover, Typography } from '@material-ui/core'; import ExpandLessIcon from '@material-ui/icons/ExpandLess'; +import ExpandMoreIcon from '@material-ui/icons/ExpandMore'; import React, { Fragment } from 'react'; import { MemoryRouter } from 'react-router-dom'; import { Breadcrumbs } from '.'; +import { Header, Page } from '..'; import { Link } from '../../components/Link'; export default { @@ -26,7 +27,19 @@ export default { component: Breadcrumbs, }; -// export const InHeader = () => ; +export const InHeader = () => ( + +

Standard breadcrumbs

+

+ Underlined pages are links. This should show a hierarchical relationship. +

+ + +
+ + +); + export const OutsideOfHeader = () => { const [anchorEl, setAnchorEl] = React.useState( null, @@ -47,23 +60,20 @@ export const OutsideOfHeader = () => { the header. In that case, they should be positioned above the title of the page.

+

Standard breadcrumbs

Underlined pages are links. This should show a hierarchical relationship.

- + + + + General Page Second Page Current page - - General Page - Current page - - - Current page -

Hidden breadcrumbs

@@ -71,7 +81,7 @@ export const OutsideOfHeader = () => { ellipses, expand the breadcrumbs out.

- + General Page Second Page Third Page @@ -86,7 +96,7 @@ export const OutsideOfHeader = () => {

- + General Page @@ -102,11 +112,11 @@ export const OutsideOfHeader = () => { anchorEl={anchorEl} anchorOrigin={{ vertical: 'bottom', - horizontal: 'center', + horizontal: 'left', }} transformOrigin={{ vertical: 'top', - horizontal: 'center', + horizontal: 'left', }} > diff --git a/packages/core/src/layout/Breadcrumbs/Breadcrumbs.tsx b/packages/core/src/layout/Breadcrumbs/Breadcrumbs.tsx index 6da9d7ad4d..d8cf88497f 100644 --- a/packages/core/src/layout/Breadcrumbs/Breadcrumbs.tsx +++ b/packages/core/src/layout/Breadcrumbs/Breadcrumbs.tsx @@ -34,12 +34,12 @@ const ClickableText = withStyles({ }, })(Typography); -const StyledBox = withStyles(theme => ({ +const StyledBox = withStyles({ root: { textDecoration: 'underline', - color: theme.palette.text.primary, + color: 'inherit', }, -}))(Box); +})(Box); export const Breadcrumbs = ({ children, ...props }: Props) => { const [anchorEl, setAnchorEl] = React.useState( @@ -71,9 +71,7 @@ export const Breadcrumbs = ({ children, ...props }: Props) => { {hasHiddenBreadcrumbs && ( ... )} - - {currentPage} - + {currentPage} { onClose={handleClose} anchorOrigin={{ vertical: 'bottom', - horizontal: 'center', + horizontal: 'left', }} transformOrigin={{ vertical: 'top', diff --git a/packages/core/src/layout/Header/Header.tsx b/packages/core/src/layout/Header/Header.tsx index 98db36ab14..73fa3066ea 100644 --- a/packages/core/src/layout/Header/Header.tsx +++ b/packages/core/src/layout/Header/Header.tsx @@ -16,15 +16,10 @@ import React, { ReactNode, CSSProperties, PropsWithChildren } from 'react'; import { Helmet } from 'react-helmet'; -import { - Link, - Typography, - Tooltip, - makeStyles, - Breadcrumbs, -} from '@material-ui/core'; -import ChevronRightIcon from '@material-ui/icons/ChevronRight'; +import { Typography, Tooltip, makeStyles } from '@material-ui/core'; import { BackstageTheme } from '@backstage/theme'; +import { Breadcrumbs } from '..'; +import { Link } from '../../components'; const useStyles = makeStyles(theme => ({ header: { @@ -136,15 +131,9 @@ const TypeFragment = ({ } return ( - } - className={classes.breadcrumb} - > - - {type} - - {pageTitle} + + {type} + {pageTitle} ); };