From f9f512559be9764b67e788e8772a8fa218ed5d2a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fredrik=20Adel=C3=B6w?= Date: Thu, 17 Mar 2022 15:28:18 +0100 Subject: [PATCH] fix the secret marker in database config MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Fredrik Adelöw --- .changeset/wicked-feet-clap.md | 5 +++++ packages/backend-common/config.d.ts | 8 ++++---- 2 files changed, 9 insertions(+), 4 deletions(-) create mode 100644 .changeset/wicked-feet-clap.md diff --git a/.changeset/wicked-feet-clap.md b/.changeset/wicked-feet-clap.md new file mode 100644 index 0000000000..e27f641820 --- /dev/null +++ b/.changeset/wicked-feet-clap.md @@ -0,0 +1,5 @@ +--- +'@backstage/backend-common': patch +--- + +Updated the visibility of database connection fields in config to be secret diff --git a/packages/backend-common/config.d.ts b/packages/backend-common/config.d.ts index 058805aa62..6c473af3c0 100644 --- a/packages/backend-common/config.d.ts +++ b/packages/backend-common/config.d.ts @@ -73,7 +73,7 @@ export interface Config { client: 'better-sqlite3' | 'sqlite3' | 'pg'; /** * Base database connection string or Knex object - * @secret + * @visibility secret */ connection: string | object; /** Database name prefix override */ @@ -109,7 +109,7 @@ export interface Config { client?: 'better-sqlite3' | 'sqlite3' | 'pg'; /** * Database connection string or Knex object override - * @secret + * @visibility secret */ connection?: string | object; /** @@ -138,7 +138,7 @@ export interface Config { store: 'redis'; /** * A redis connection string in the form `redis://user:pass@host:port`. - * @secret + * @visibility secret */ connection: string; } @@ -146,7 +146,7 @@ export interface Config { store: 'memcache'; /** * A memcache connection string in the form `user:pass@host:port`. - * @secret + * @visibility secret */ connection: string; };