From f966a8557f7e243c545ec658e2288c239bbc3be8 Mon Sep 17 00:00:00 2001 From: KoB <63000843+kingbj940429@users.noreply.github.com> Date: Tue, 2 Dec 2025 09:34:10 +0900 Subject: [PATCH] feat(kubernetes-plugin): enable a pod terminal at GCP GKE (#31915) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * chore: remove google for enabling pod terminal at gke Signed-off-by: 김병준 * chore: add chageset Signed-off-by: 김병준 * chore: update test code for enabling a pod terminal at gke Signed-off-by: 김병준 --------- Signed-off-by: 김병준 --- .changeset/fifty-coats-feel.md | 5 +++++ .../src/hooks/useIsPodExecTerminalSupported.test.ts | 2 +- .../src/hooks/useIsPodExecTerminalSupported.ts | 4 ++-- 3 files changed, 8 insertions(+), 3 deletions(-) create mode 100644 .changeset/fifty-coats-feel.md diff --git a/.changeset/fifty-coats-feel.md b/.changeset/fifty-coats-feel.md new file mode 100644 index 0000000000..0e3425a505 --- /dev/null +++ b/.changeset/fifty-coats-feel.md @@ -0,0 +1,5 @@ +--- +'@backstage/plugin-kubernetes-react': patch +--- + +Enabled a pod terminal at GKE diff --git a/plugins/kubernetes-react/src/hooks/useIsPodExecTerminalSupported.test.ts b/plugins/kubernetes-react/src/hooks/useIsPodExecTerminalSupported.test.ts index c4df347c6f..26ba8f5e91 100644 --- a/plugins/kubernetes-react/src/hooks/useIsPodExecTerminalSupported.test.ts +++ b/plugins/kubernetes-react/src/hooks/useIsPodExecTerminalSupported.test.ts @@ -55,7 +55,7 @@ describe('useIsPodExecTerminalSupported', () => { }, { condition: 'AuthProvider is google', - returnValue: false, + returnValue: true, testClusters: [{ authProvider: 'google' }], }, { diff --git a/plugins/kubernetes-react/src/hooks/useIsPodExecTerminalSupported.ts b/plugins/kubernetes-react/src/hooks/useIsPodExecTerminalSupported.ts index 5795b900ae..06c1a8808f 100644 --- a/plugins/kubernetes-react/src/hooks/useIsPodExecTerminalSupported.ts +++ b/plugins/kubernetes-react/src/hooks/useIsPodExecTerminalSupported.ts @@ -34,8 +34,8 @@ export const useIsPodExecTerminalSupported = (): AsyncState => { } const { authProvider } = clusters[0]; - const isClientAuthProvider = ['aks', 'google', 'oidc'].some( - authProviderName => authProvider.includes(authProviderName), + const isClientAuthProvider = ['aks', 'oidc'].some(authProviderName => + authProvider.includes(authProviderName), ); return !isClientAuthProvider;