From f955f92ee6e70bff9dd70a7977d8dd094434b8d0 Mon Sep 17 00:00:00 2001 From: Taras Mankovski Date: Thu, 3 Sep 2020 08:06:08 -0400 Subject: [PATCH] Add failed test for coercion of numberic strings --- packages/config/src/reader.test.ts | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/packages/config/src/reader.test.ts b/packages/config/src/reader.test.ts index 41cdc92938..3fa8bb5860 100644 --- a/packages/config/src/reader.test.ts +++ b/packages/config/src/reader.test.ts @@ -35,6 +35,7 @@ const DATA = { strings: ['string1', 'string2'], }, nestlings: [{ boolean: true }, { string: 'string' }, { number: 42 }] as {}[], + port: 'number', }; function expectValidValues(config: ConfigReader) { @@ -580,4 +581,17 @@ describe('ConfigReader.get()', () => { }, }); }); + + it('coerces number strings to numbers', () => { + const config = ConfigReader.fromConfigs([ + { + data: { + port: '123', + }, + context: '1', + }, + ]); + + expect(config.getNumber('port')).toEqual(123); + }); });