From f816f68bbedd568486f9ef46dc4d33e8882aee47 Mon Sep 17 00:00:00 2001 From: Mike Lewis Date: Fri, 12 Nov 2021 12:13:48 +0000 Subject: [PATCH] authz: add PermissionClient TODO for better type-safety Signed-off-by: Mike Lewis --- packages/permission-common/src/PermissionClient.ts | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/packages/permission-common/src/PermissionClient.ts b/packages/permission-common/src/PermissionClient.ts index b8b2a03c44..5c32ecb139 100644 --- a/packages/permission-common/src/PermissionClient.ts +++ b/packages/permission-common/src/PermissionClient.ts @@ -97,6 +97,11 @@ export class PermissionClient { requests: AuthorizeRequest[], options?: AuthorizeRequestOptions, ): Promise { + // TODO(permissions): it would be great to provide some kind of typing guarantee that + // conditional responses will only ever be returned for requests containing a resourceType + // but no resourceRef. That way clients who aren't prepared to handle filtering according + // to conditions can be guaranteed that they won't unexpectedly get a CONDITIONAL response. + const identifiedRequests: Identified[] = requests.map( request => ({ id: uuid.v4(),