From f616d99f6f93cddcd141cf7a9c65122feb83558e Mon Sep 17 00:00:00 2001 From: Manuel Stein Date: Thu, 17 Mar 2022 21:59:09 +0200 Subject: [PATCH] plugin-kubernetes: fix div by zero pod resources When pods have no resources set, currentToDeclaredResourceToPerc would throw div by zero, added check Signed-off-by: Manuel Stein --- .changeset/wicked-beds-return.md | 5 +++++ plugins/kubernetes/src/utils/pod.tsx | 2 ++ 2 files changed, 7 insertions(+) create mode 100644 .changeset/wicked-beds-return.md diff --git a/.changeset/wicked-beds-return.md b/.changeset/wicked-beds-return.md new file mode 100644 index 0000000000..add952ba0a --- /dev/null +++ b/.changeset/wicked-beds-return.md @@ -0,0 +1,5 @@ +--- +'@backstage/plugin-kubernetes': patch +--- + +Fix division by zero in currentToDeclaredResourceToPerc when pod resources weren't set diff --git a/plugins/kubernetes/src/utils/pod.tsx b/plugins/kubernetes/src/utils/pod.tsx index 50cc983b9d..86cf90e54f 100644 --- a/plugins/kubernetes/src/utils/pod.tsx +++ b/plugins/kubernetes/src/utils/pod.tsx @@ -118,6 +118,8 @@ export const currentToDeclaredResourceToPerc = ( current: number | string, resource: number | string, ): string => { + if(Number(resource) == 0) return `0%`; + if (typeof current === 'number' && typeof resource === 'number') { return `${Math.round((current / resource) * 100)}%`; }