From f5da6523c03fbfc8f6de6e72cfbc47de0a4386da Mon Sep 17 00:00:00 2001
From: armandocomellas1 <cgarmando@google.com>
Date: Mon, 15 Jan 2024 18:01:06 -0600
Subject: [PATCH] Change the description header of the changeset and also add a
 unit test for new URL method

Signed-off-by: armandocomellas1 <cgarmando@google.com>
---
 .changeset/thirty-cats-help.md                |  2 +-
 .../modules/core/UrlReaderProcessor.test.ts   | 27 +++++++++++++++++++
 2 files changed, 28 insertions(+), 1 deletion(-)

diff --git a/.changeset/thirty-cats-help.md b/.changeset/thirty-cats-help.md
index bb6011ca9c..9c5d24180d 100644
--- a/.changeset/thirty-cats-help.md
+++ b/.changeset/thirty-cats-help.md
@@ -2,4 +2,4 @@
 '@backstage/plugin-catalog-backend': patch
 ---
 
-Change script in **UrlReaderProcessor.ts** Replacing the line code 127 with method (new URL) to handle URL Reader from GCS with wildcard \*
+Parse the URL using a different method rather than `git-url-parse` to support wildcards for URLs which are not VCS providers
diff --git a/plugins/catalog-backend/src/modules/core/UrlReaderProcessor.test.ts b/plugins/catalog-backend/src/modules/core/UrlReaderProcessor.test.ts
index c9575ce5cd..0a3bec7570 100644
--- a/plugins/catalog-backend/src/modules/core/UrlReaderProcessor.test.ts
+++ b/plugins/catalog-backend/src/modules/core/UrlReaderProcessor.test.ts
@@ -213,4 +213,31 @@ describe('UrlReaderProcessor', () => {
 
     expect(reader.search).toHaveBeenCalledTimes(1);
   });
+
+  it('parser return valid URL with wildcard *', async () => {
+    const logger = getVoidLogger();
+
+    const reader: jest.Mocked<UrlReader> = {
+      readUrl: jest.fn(),
+      readTree: jest.fn(),
+      search: jest.fn().mockImplementation(async () => []),
+    };
+
+    const processor = new UrlReaderProcessor({ reader, logger });
+
+    const emit = jest.fn();
+
+    await processor.readLocation(
+      {
+        type: 'url',
+        target: 'https://storage.cloud.google.com/ah-backstage-poc-catalog/*',
+      },
+      false,
+      emit,
+      defaultEntityDataParser,
+      mockCache,
+    );
+
+    expect(reader.search).toHaveReturned();
+  });
 });