Clean up analyticsApi def in app plugin

Signed-off-by: Eric Peterson <ericpeterson@spotify.com>

plugins/app/src/defaultApis.ts

@@ -68,7 +68,7 @@ import {
   IdentityPermissionApi,
 } from '@backstage/plugin-permission-react';
 import { DefaultDialogApi } from './apis/DefaultDialogApi';
-import { AnalyticsApi } from './extensions/AnalyticsApi';
+import { analyticsApi } from './extensions/AnalyticsApi';
 
 export const apis = [
   ApiBlueprint.make({
@@ -101,7 +101,7 @@ export const apis = [
         factory: () => new AlertApiForwarder(),
       }),
   }),
-  AnalyticsApi,
+  analyticsApi,
   ApiBlueprint.make({
     name: 'error',
     params: defineParams =>

plugins/app/src/extensions/AnalyticsApi.test.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 import { createExtensionTester } from '@backstage/frontend-test-utils';
-import { AnalyticsApi } from './AnalyticsApi';
+import { analyticsApi } from './AnalyticsApi';
 import {
   AnalyticsImplementationBlueprint,
   AnalyticsImplementation,
@@ -24,7 +24,7 @@ import {
   identityApiRef,
 } from '@backstage/frontend-plugin-api';
 
-describe('AnalyticsApi', () => {
+describe('analyticsApi', () => {
   const mockEvent = {
     action: '',
     subject: '',
@@ -73,7 +73,7 @@ describe('AnalyticsApi', () => {
 
   it('wires up a single AnalyticsImplementationFactory', async () => {
     // Given the Analytics API and a single mock implementation
-    const tester = createExtensionTester(AnalyticsApi).add(MockImplementation1);
+    const tester = createExtensionTester(analyticsApi).add(MockImplementation1);
     const apiFactory = tester.get(ApiBlueprint.dataRefs.factory);
 
     // Then the API's deps should contain the mock implementation's deps.
@@ -101,7 +101,7 @@ describe('AnalyticsApi', () => {
 
   it('wires up more than one AnalyticsImplementationFactory', () => {
     // Given the Analytics API and two mock implementations
-    const tester = createExtensionTester(AnalyticsApi)
+    const tester = createExtensionTester(analyticsApi)
       .add(MockImplementation1)
       .add(MockImplementation2);
     const apiFactory = tester.get(ApiBlueprint.dataRefs.factory);
@@ -142,7 +142,7 @@ describe('AnalyticsApi', () => {
 
   it('works fine with no AnalyticsImplementationFactory instances provided', () => {
     // Given the Analytics API and no mock implementations
-    const tester = createExtensionTester(AnalyticsApi);
+    const tester = createExtensionTester(analyticsApi);
     const apiFactory = tester.get(ApiBlueprint.dataRefs.factory);
 
     // Then the API's deps should be empty

plugins/app/src/extensions/AnalyticsApi.ts

@@ -22,7 +22,7 @@ import {
   createExtensionInput,
 } from '@backstage/frontend-plugin-api';
 
-export const AnalyticsApi = ApiBlueprint.makeWithOverrides({
+export const analyticsApi = ApiBlueprint.makeWithOverrides({
   name: 'analytics',
   inputs: {
     implementations: createExtensionInput([