chore: some changeset tweaks a few other changes

Signed-off-by: benjdlambert <ben@blam.sh>

packages/frontend-plugin-api/report.api.md

@@ -374,13 +374,6 @@ export interface ConfigurableExtensionDataRef<
   >;
 }
 
-// @public (undocumented)
-export type CoreErrorDisplayProps = {
-  plugin?: FrontendPlugin;
-  error: Error;
-  resetError: () => void;
-};
-
 // @public (undocumented)
 export const coreExtensionData: {
   reactElement: ConfigurableExtensionDataRef<
@@ -396,14 +389,6 @@ export const coreExtensionData: {
   >;
 };
 
-// @public (undocumented)
-export type CoreNotFoundErrorPageProps = {
-  children?: ReactNode;
-};
-
-// @public (undocumented)
-export type CoreProgressProps = {};
-
 export { createApiFactory };
 
 export { createApiRef };
@@ -872,9 +857,16 @@ export { errorApiRef };
 
 // @public (undocumented)
 export const ErrorDisplay: ((
-  props: CoreErrorDisplayProps,
+  props: ErrorDisplayProps,
 ) => JSX.Element | null) & {
-  ref: SwappableComponentRef<CoreErrorDisplayProps, CoreErrorDisplayProps>;
+  ref: SwappableComponentRef<ErrorDisplayProps, ErrorDisplayProps>;
+};
+
+// @public (undocumented)
+export type ErrorDisplayProps = {
+  plugin?: FrontendPlugin;
+  error: Error;
+  resetError: () => void;
 };
 
 // @public (undocumented)
@@ -1534,12 +1526,14 @@ export const NavItemBlueprint: ExtensionBlueprint<{
 
 // @public (undocumented)
 export const NotFoundErrorPage: ((
-  props: CoreNotFoundErrorPageProps,
+  props: NotFoundErrorPageProps,
 ) => JSX.Element | null) & {
-  ref: SwappableComponentRef<
-    CoreNotFoundErrorPageProps,
-    CoreNotFoundErrorPageProps
-  >;
+  ref: SwappableComponentRef<NotFoundErrorPageProps, NotFoundErrorPageProps>;
+};
+
+// @public (undocumented)
+export type NotFoundErrorPageProps = {
+  children?: ReactNode;
 };
 
 export { OAuthApi };
@@ -1627,10 +1621,13 @@ export { ProfileInfo };
 export { ProfileInfoApi };
 
 // @public (undocumented)
-export const Progress: ((props: CoreProgressProps) => JSX.Element | null) & {
-  ref: SwappableComponentRef<CoreProgressProps, CoreProgressProps>;
+export const Progress: ((props: ProgressProps) => JSX.Element | null) & {
+  ref: SwappableComponentRef<ProgressProps, ProgressProps>;
 };
 
+// @public (undocumented)
+export type ProgressProps = {};
+
 // @public
 export type ResolvedExtensionInput<
   TExtensionInput extends ExtensionInput<any, any>,

packages/frontend-plugin-api/src/components/DefaultSwappableComponents.tsx

@@ -15,16 +15,16 @@
  */
 
 import {
-  CoreErrorDisplayProps,
-  CoreNotFoundErrorPageProps,
-  CoreProgressProps,
+  ErrorDisplayProps,
+  NotFoundErrorPageProps,
+  ProgressProps,
 } from '../types';
 import { createSwappableComponent } from './createSwappableComponent';
 
 /**
  * @public
  */
-export const Progress = createSwappableComponent<CoreProgressProps>({
+export const Progress = createSwappableComponent<ProgressProps>({
   id: 'core.components.progress',
 });
 
@@ -32,14 +32,14 @@ export const Progress = createSwappableComponent<CoreProgressProps>({
  * @public
  */
 export const NotFoundErrorPage =
-  createSwappableComponent<CoreNotFoundErrorPageProps>({
+  createSwappableComponent<NotFoundErrorPageProps>({
     id: 'core.components.notFoundErrorPage',
   });
 
 /**
  * @public
  */
-export const ErrorDisplay = createSwappableComponent<CoreErrorDisplayProps>({
+export const ErrorDisplay = createSwappableComponent<ErrorDisplayProps>({
   id: 'core.components.errorDisplay',
   loader: () => props =>
     <div data-testid="core.components.errorDisplay">{props.error.message}</div>,

packages/frontend-plugin-api/src/index.ts

@@ -32,7 +32,7 @@ export * from './translation';
 export * from './wiring';
 
 export type {
-  CoreProgressProps,
-  CoreNotFoundErrorPageProps,
-  CoreErrorDisplayProps,
+  ProgressProps,
+  NotFoundErrorPageProps,
+  ErrorDisplayProps,
 } from './types';

packages/frontend-plugin-api/src/types.ts

@@ -18,15 +18,15 @@ import { ReactNode } from 'react';
 import { FrontendPlugin } from './wiring';
 
 /** @public */
-export type CoreProgressProps = {};
+export type ProgressProps = {};
 
 /** @public */
-export type CoreNotFoundErrorPageProps = {
+export type NotFoundErrorPageProps = {
   children?: ReactNode;
 };
 
 /** @public */
-export type CoreErrorDisplayProps = {
+export type ErrorDisplayProps = {
   plugin?: FrontendPlugin;
   error: Error;
   resetError: () => void;