From f3c90da8c7960f201e61eb195c76cb7d56e4b1f0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carl-Erik=20Bergstr=C3=B6m?= Date: Mon, 9 Sep 2024 14:53:11 +0200 Subject: [PATCH] fix: prevent 3 React elements from being created for each part of the support title (#26562) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Carl-Erik Bergström --- .changeset/odd-insects-behave.md | 5 +++++ .../src/components/DefaultImportPage/DefaultImportPage.tsx | 7 +++---- 2 files changed, 8 insertions(+), 4 deletions(-) create mode 100644 .changeset/odd-insects-behave.md diff --git a/.changeset/odd-insects-behave.md b/.changeset/odd-insects-behave.md new file mode 100644 index 0000000000..c0e5217a29 --- /dev/null +++ b/.changeset/odd-insects-behave.md @@ -0,0 +1,5 @@ +--- +'@backstage/plugin-catalog-import': patch +--- + +Support button title should be contained in a single menu item diff --git a/plugins/catalog-import/src/components/DefaultImportPage/DefaultImportPage.tsx b/plugins/catalog-import/src/components/DefaultImportPage/DefaultImportPage.tsx index 680ce16ae4..fa89ac2caf 100644 --- a/plugins/catalog-import/src/components/DefaultImportPage/DefaultImportPage.tsx +++ b/plugins/catalog-import/src/components/DefaultImportPage/DefaultImportPage.tsx @@ -40,6 +40,8 @@ export const DefaultImportPage = () => { const isMobile = useMediaQuery(theme.breakpoints.down('sm')); const appTitle = configApi.getOptionalString('app.title') || 'Backstage'; + const supportTitle = `Start tracking your component in ${appTitle} by adding it to the software catalog.`; + const contentItems = [ @@ -55,10 +57,7 @@ export const DefaultImportPage = () => {
- - Start tracking your component in {appTitle} by adding it to the - software catalog. - + {supportTitle}