fix: initial review finding fixes

Signed-off-by: Heikki Hellgren <heikki.hellgren@op.fi>

plugins/signals-node/api-report.md

@@ -13,6 +13,7 @@ import { IdentityApi } from '@backstage/plugin-auth-node';
 import { IncomingMessage } from 'http';
 import { JsonObject } from '@backstage/types';
 import { Logger } from 'winston';
+import { ServiceRef } from '@backstage/backend-plugin-api';
 
 // @public (undocumented)
 export type ServiceOptions = {
@@ -49,5 +50,8 @@ export class SignalService implements EventSubscriber {
   supportsEventTopics(): string[];
 }
 
+// @public (undocumented)
+export const signalService: ServiceRef<SignalService, 'plugin'>;
+
 // (No @packageDocumentation comment for this package)
 ```

plugins/signals-node/package.json

@@ -30,6 +30,7 @@
   ],
   "dependencies": {
     "@backstage/backend-common": "workspace:^",
+    "@backstage/backend-plugin-api": "workspace:^",
     "@backstage/config": "workspace:^",
     "@backstage/plugin-auth-node": "workspace:^",
     "@backstage/plugin-events-node": "workspace:^",

plugins/signals-node/src/index.ts

@@ -14,5 +14,6 @@
  * limitations under the License.
  */
 
+export * from './lib';
 export * from './SignalService';
 export * from './types';

plugins/signals-node/src/lib.ts

@@ -0,0 +1,21 @@
+/*
+ * Copyright 2023 The Backstage Authors
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+import { createServiceRef } from '@backstage/backend-plugin-api';
+
+/** @public */
+export const signalService = createServiceRef<
+  import('./SignalService').SignalService
+>({ id: 'signals.service', scope: 'plugin' });