From f32e13c6c6a01d5339b0cca0b12af6e823b49752 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fredrik=20Adel=C3=B6w?= Date: Sat, 27 Jun 2020 21:26:59 +0200 Subject: [PATCH] Make Tabs supply number instead of Number --- packages/core/src/layout/HeaderTabs/index.tsx | 5 +++-- plugins/catalog/src/components/CatalogPage/CatalogTabs.tsx | 6 +++--- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/packages/core/src/layout/HeaderTabs/index.tsx b/packages/core/src/layout/HeaderTabs/index.tsx index 2617a27aa9..35e952a10e 100644 --- a/packages/core/src/layout/HeaderTabs/index.tsx +++ b/packages/core/src/layout/HeaderTabs/index.tsx @@ -42,16 +42,17 @@ export type Tab = { id: string; label: string; }; + export const HeaderTabs: React.FC<{ tabs: Tab[]; - onChange?: (index: Number) => void; + onChange?: (index: number) => void; }> = ({ tabs, onChange }) => { const [selectedTab, setSelectedTab] = useState(0); const styles = useStyles(); const handleChange = (_: React.ChangeEvent<{}>, index: Number) => { setSelectedTab(index); - if (onChange) onChange(index); + if (onChange) onChange(index.valueOf()); }; return ( diff --git a/plugins/catalog/src/components/CatalogPage/CatalogTabs.tsx b/plugins/catalog/src/components/CatalogPage/CatalogTabs.tsx index 9d07eae62e..cad05c4ef6 100644 --- a/plugins/catalog/src/components/CatalogPage/CatalogTabs.tsx +++ b/plugins/catalog/src/components/CatalogPage/CatalogTabs.tsx @@ -70,10 +70,10 @@ export const CatalogTabs = ({ tabs, onChange }: Props) => { }, [tabs, currentTabIndex]); const switchTab = useCallback( - (index: Number) => { - const tab = tabs[index as number]; + (index: number) => { + const tab = tabs[index]; setSelectedFilters([tab.id]); - setCurrentTabIndex(index as number); + setCurrentTabIndex(index); onChangeRef.current?.(tab); }, [tabs, setSelectedFilters],