From f278c1bd79a76e8a12a717f57708608d184c5e62 Mon Sep 17 00:00:00 2001 From: Damon Kaswell Date: Mon, 5 Dec 2022 08:06:33 -0800 Subject: [PATCH] Fix set bug and use more efficient vars Signed-off-by: Damon Kaswell --- .../IncrementalIngestionDatabaseManager.ts | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/plugins/catalog-backend-module-incremental-ingestion/src/database/IncrementalIngestionDatabaseManager.ts b/plugins/catalog-backend-module-incremental-ingestion/src/database/IncrementalIngestionDatabaseManager.ts index 9b7afd6d9b..9eb52c4558 100644 --- a/plugins/catalog-backend-module-incremental-ingestion/src/database/IncrementalIngestionDatabaseManager.ts +++ b/plugins/catalog-backend-module-incremental-ingestion/src/database/IncrementalIngestionDatabaseManager.ts @@ -563,19 +563,19 @@ export class IncrementalIngestionDatabaseManager { const refs = entities.map(e => stringifyEntityRef(e.entity)); await this.client.transaction(async tx => { - const existingRefs = new Set( - ...( - await tx<{ ref: string }>('ingestion_mark_entities') - .select('ref') - .whereIn('ref', refs) - ).map(e => e.ref), - ); + const existingRefsArray = ( + await tx<{ ref: string }>('ingestion_mark_entities') + .select('ref') + .whereIn('ref', refs) + ).map(e => e.ref); - const newRefs = refs.filter(e => !existingRefs.has(e)); + const existingRefsSet = new Set(existingRefsArray); + + const newRefs = refs.filter(e => !existingRefsSet.has(e)); await tx('ingestion_mark_entities') .update('ingestion_mark_id', markId) - .whereIn('ref', Array.from(existingRefs)); + .whereIn('ref', existingRefsArray); await tx('ingestion_mark_entities').insert( newRefs.map(ref => ({