From f1e0357974538f15835c58b2ca260c2aacbdc3ed Mon Sep 17 00:00:00 2001 From: Sarah Medeiros Date: Fri, 13 Jan 2023 12:55:04 -0500 Subject: [PATCH] Update API report. Simplify picker. Signed-off-by: Sarah Medeiros --- plugins/catalog-react/api-report.md | 9 ++++++++- .../EntityLifecyclePicker/EntityLifecyclePicker.tsx | 4 ++-- .../src/components/EntityLifecyclePicker/index.ts | 5 ++++- 3 files changed, 14 insertions(+), 4 deletions(-) diff --git a/plugins/catalog-react/api-report.md b/plugins/catalog-react/api-report.md index 9528c55326..48153a9c78 100644 --- a/plugins/catalog-react/api-report.md +++ b/plugins/catalog-react/api-report.md @@ -194,7 +194,14 @@ export class EntityLifecycleFilter implements EntityFilter { } // @public (undocumented) -export const EntityLifecyclePicker: () => JSX.Element | null; +export const EntityLifecyclePicker: ( + props: EntityLifecyclePickerProps, +) => JSX.Element | null; + +// @public (undocumented) +export type EntityLifecyclePickerProps = { + initialFilter?: string[]; +}; // @public export const EntityListContext: React_2.Context< diff --git a/plugins/catalog-react/src/components/EntityLifecyclePicker/EntityLifecyclePicker.tsx b/plugins/catalog-react/src/components/EntityLifecyclePicker/EntityLifecyclePicker.tsx index 913e800ec0..3ec0bf8497 100644 --- a/plugins/catalog-react/src/components/EntityLifecyclePicker/EntityLifecyclePicker.tsx +++ b/plugins/catalog-react/src/components/EntityLifecyclePicker/EntityLifecyclePicker.tsx @@ -53,7 +53,7 @@ export type EntityLifecyclePickerProps = { /** @public */ export const EntityLifecyclePicker = (props: EntityLifecyclePickerProps) => { - const { initialFilter } = props; + const { initialFilter = [] } = props; const classes = useStyles(); const { updateFilters, @@ -70,7 +70,7 @@ export const EntityLifecyclePicker = (props: EntityLifecyclePickerProps) => { const [selectedLifecycles, setSelectedLifecycles] = useState( queryParamLifecycles.length ? queryParamLifecycles - : filters.lifecycles?.values ?? (initialFilter || []), + : filters.lifecycles?.values ?? initialFilter, ); // Set selected lifecycles on query parameter updates; this happens at initial page load and from diff --git a/plugins/catalog-react/src/components/EntityLifecyclePicker/index.ts b/plugins/catalog-react/src/components/EntityLifecyclePicker/index.ts index def25eabf4..b1e2d73080 100644 --- a/plugins/catalog-react/src/components/EntityLifecyclePicker/index.ts +++ b/plugins/catalog-react/src/components/EntityLifecyclePicker/index.ts @@ -15,4 +15,7 @@ */ export { EntityLifecyclePicker } from './EntityLifecyclePicker'; -export type { CatalogReactEntityLifecyclePickerClassKey } from './EntityLifecyclePicker'; +export type { + CatalogReactEntityLifecyclePickerClassKey, + EntityLifecyclePickerProps, +} from './EntityLifecyclePicker';