Merge pull request #32516 from backstage/freben/nodecolon

Add a rule for the use of `node:` prefix on native imports

plugins/scaffolder-backend/scripts/build-nunjucks.js

@@ -18,7 +18,7 @@
 /* eslint-disable no-restricted-syntax */
 /* eslint-disable @backstage/no-undeclared-imports */
 
-const path = require('path');
+const path = require('node:path');
 
 const NUNJUCKS_LICENSE = `/**
  * Copyright (c) 2012-2015, James Long

plugins/scaffolder-backend/src/ScaffolderPlugin.test.ts

@@ -13,7 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-import { IncomingMessage } from 'http';
+import { IncomingMessage } from 'node:http';
 import request from 'supertest';
 import waitForExpect from 'wait-for-expect';
 

plugins/scaffolder-backend/src/scaffolder/actions/builtin/catalog/write.examples.test.ts

@@ -22,10 +22,10 @@ const fsMock = fs as jest.Mocked<typeof fs>;
 
 import { createMockActionContext } from '@backstage/plugin-scaffolder-node-test-utils';
 import { createCatalogWriteAction } from './write';
-import { resolve as resolvePath } from 'path';
+import { resolve as resolvePath } from 'node:path';
 import * as yaml from 'yaml';
 import { examples } from './write.examples';
-import os from 'os';
+import os from 'node:os';
 
 describe('catalog:write', () => {
   const action = createCatalogWriteAction();

plugins/scaffolder-backend/src/scaffolder/actions/builtin/catalog/write.test.ts

@@ -20,11 +20,11 @@ jest.mock('fs-extra');
 
 const fsMock = fs as jest.Mocked<typeof fs>;
 
-import os from 'os';
+import os from 'node:os';
 import { createMockActionContext } from '@backstage/plugin-scaffolder-node-test-utils';
 import { ANNOTATION_ORIGIN_LOCATION } from '@backstage/catalog-model';
 import { createCatalogWriteAction } from './write';
-import { resolve as resolvePath } from 'path';
+import { resolve as resolvePath } from 'node:path';
 import * as yaml from 'yaml';
 
 describe('catalog:write', () => {

plugins/scaffolder-backend/src/scaffolder/actions/builtin/debug/log.examples.test.ts

@@ -16,7 +16,7 @@
 
 import { createMockActionContext } from '@backstage/plugin-scaffolder-node-test-utils';
 import { createDebugLogAction } from './log';
-import { join } from 'path';
+import { join } from 'node:path';
 import yaml from 'yaml';
 import { examples } from './log.examples';
 import { createMockDirectory } from '@backstage/backend-test-utils';

plugins/scaffolder-backend/src/scaffolder/actions/builtin/debug/log.test.ts

@@ -17,7 +17,7 @@
 import { createMockActionContext } from '@backstage/plugin-scaffolder-node-test-utils';
 import { Logger } from 'winston';
 import { createDebugLogAction } from './log';
-import { join } from 'path';
+import { join } from 'node:path';
 import yaml from 'yaml';
 import { createMockDirectory } from '@backstage/backend-test-utils';
 import fs from 'fs-extra';

plugins/scaffolder-backend/src/scaffolder/actions/builtin/debug/log.ts

@@ -16,10 +16,10 @@
 
 import { resolveSafeChildPath } from '@backstage/backend-plugin-api';
 import { readdir, stat } from 'fs-extra';
-import { join, relative } from 'path';
+import { join, relative } from 'node:path';
 import { createTemplateAction } from '@backstage/plugin-scaffolder-node';
 import { examples } from './log.examples';
-import fs from 'fs';
+import fs from 'node:fs';
 
 const id = 'debug:log';
 

plugins/scaffolder-backend/src/scaffolder/actions/builtin/fetch/plain.examples.test.ts

@@ -16,7 +16,7 @@
 
 import yaml from 'yaml';
 
-import { resolve as resolvePath } from 'path';
+import { resolve as resolvePath } from 'node:path';
 import { ConfigReader } from '@backstage/config';
 import { ScmIntegrations } from '@backstage/integration';
 import { createFetchPlainAction } from './plain';

plugins/scaffolder-backend/src/scaffolder/actions/builtin/fetch/plain.test.ts

@@ -19,7 +19,7 @@ jest.mock('@backstage/plugin-scaffolder-node', () => {
   return { ...actual, fetchContents: jest.fn() };
 });
 
-import { resolve as resolvePath } from 'path';
+import { resolve as resolvePath } from 'node:path';
 import { createMockActionContext } from '@backstage/plugin-scaffolder-node-test-utils';
 import { ConfigReader } from '@backstage/config';
 import { ScmIntegrations } from '@backstage/integration';

plugins/scaffolder-backend/src/scaffolder/actions/builtin/fetch/plainFile.examples.test.ts

@@ -22,7 +22,7 @@ jest.mock('@backstage/plugin-scaffolder-node', () => {
 });
 
 import yaml from 'yaml';
-import { resolve as resolvePath } from 'path';
+import { resolve as resolvePath } from 'node:path';
 import { ConfigReader } from '@backstage/config';
 import { ScmIntegrations } from '@backstage/integration';
 import { createFetchPlainFileAction } from './plainFile';

plugins/scaffolder-backend/src/scaffolder/actions/builtin/fetch/plainFile.test.ts

@@ -19,7 +19,7 @@ jest.mock('@backstage/plugin-scaffolder-node', () => {
   return { ...actual, fetchFile: jest.fn() };
 });
 
-import { resolve as resolvePath } from 'path';
+import { resolve as resolvePath } from 'node:path';
 import { createMockActionContext } from '@backstage/plugin-scaffolder-node-test-utils';
 import { ConfigReader } from '@backstage/config';
 import { ScmIntegrations } from '@backstage/integration';

plugins/scaffolder-backend/src/scaffolder/actions/builtin/fetch/template.examples.test.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import { join as joinPath, sep as pathSep } from 'path';
+import { join as joinPath, sep as pathSep } from 'node:path';
 import fs from 'fs-extra';
 import { UrlReaderService } from '@backstage/backend-plugin-api';
 import { resolvePackagePath } from '@backstage/backend-plugin-api';

plugins/scaffolder-backend/src/scaffolder/actions/builtin/fetch/template.test.ts

@@ -19,7 +19,7 @@ jest.mock('@backstage/plugin-scaffolder-node', () => {
   return { ...actual, fetchContents: jest.fn() };
 });
 
-import { join as joinPath, sep as pathSep } from 'path';
+import { join as joinPath, sep as pathSep } from 'node:path';
 import fs from 'fs-extra';
 import {
   UrlReaderService,

plugins/scaffolder-backend/src/scaffolder/actions/builtin/fetch/templateActionHandler.ts

@@ -30,7 +30,7 @@ import { isBinaryFile } from 'isbinaryfile';
 import { createDefaultFilters } from '../../../../lib/templating/filters/createDefaultFilters';
 import { convertFiltersToRecord } from '../../../../util/templating';
 import { SecureTemplater } from '../../../../lib/templating/SecureTemplater';
-import { extname } from 'path';
+import { extname } from 'node:path';
 
 export type TemplateActionInput = {
   targetPath?: string;

plugins/scaffolder-backend/src/scaffolder/actions/builtin/fetch/templateFile.examples.test.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import { join as joinPath } from 'path';
+import { join as joinPath } from 'node:path';
 import fs from 'fs-extra';
 import { UrlReaderService } from '@backstage/backend-plugin-api';
 import { ScmIntegrations } from '@backstage/integration';

plugins/scaffolder-backend/src/scaffolder/actions/builtin/fetch/templateFile.test.ts

@@ -19,7 +19,7 @@ jest.mock('@backstage/plugin-scaffolder-node', () => {
   return { ...actual, fetchFile: jest.fn() };
 });
 
-import { join as joinPath } from 'path';
+import { join as joinPath } from 'node:path';
 import fs from 'fs-extra';
 import { UrlReaderService } from '@backstage/backend-plugin-api';
 import { ScmIntegrations } from '@backstage/integration';

plugins/scaffolder-backend/src/scaffolder/actions/builtin/fetch/templateFile.ts

@@ -22,7 +22,7 @@ import {
   TemplateFilter,
   TemplateGlobal,
 } from '@backstage/plugin-scaffolder-node';
-import path from 'path';
+import path from 'node:path';
 import { examples } from './templateFile.examples';
 import { createTemplateFileActionHandler } from './templateFileActionHandler';
 

plugins/scaffolder-backend/src/scaffolder/actions/builtin/fetch/templateFileActionHandler.ts

@@ -23,7 +23,7 @@ import fs from 'fs-extra';
 import { createDefaultFilters } from '../../../../lib/templating/filters/createDefaultFilters';
 import { convertFiltersToRecord } from '../../../../util/templating';
 import { resolveSafeChildPath } from '@backstage/backend-plugin-api';
-import path from 'path';
+import path from 'node:path';
 import { SecureTemplater } from '../../../../lib/templating/SecureTemplater';
 
 export type TemplateFileActionInput = {

plugins/scaffolder-backend/src/scaffolder/actions/builtin/fetch/workspaceTemplate.test.ts

@@ -23,7 +23,7 @@ import {
 } from '@backstage/plugin-scaffolder-node';
 import { createMockActionContext } from '@backstage/plugin-scaffolder-node-test-utils';
 import fs from 'fs-extra';
-import { join as joinPath, sep as pathSep } from 'path';
+import { join as joinPath, sep as pathSep } from 'node:path';
 import { createWorkspaceTemplateAction } from './workspaceTemplate';
 import { TemplateActionInput } from './templateActionHandler';
 

plugins/scaffolder-backend/src/scaffolder/actions/builtin/fetch/workspaceTemplateFile.test.ts

@@ -22,7 +22,7 @@ import {
 } from '@backstage/plugin-scaffolder-node';
 import { createMockActionContext } from '@backstage/plugin-scaffolder-node-test-utils';
 import fs from 'fs-extra';
-import { join as joinPath } from 'path';
+import { join as joinPath } from 'node:path';
 import { createWorkspaceTemplateFileAction } from './workspaceTemplateFile';
 import { TemplateFileActionInput } from './templateFileActionHandler';
 

plugins/scaffolder-backend/src/scaffolder/actions/builtin/filesystem/delete.examples.test.ts

@@ -16,7 +16,7 @@
 
 import { createFilesystemDeleteAction } from './delete';
 import { createMockActionContext } from '@backstage/plugin-scaffolder-node-test-utils';
-import { resolve as resolvePath } from 'path';
+import { resolve as resolvePath } from 'node:path';
 import fs from 'fs-extra';
 import yaml from 'yaml';
 import { examples } from './delete.examples';

plugins/scaffolder-backend/src/scaffolder/actions/builtin/filesystem/delete.test.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import { resolve as resolvePath } from 'path';
+import { resolve as resolvePath } from 'node:path';
 import { createFilesystemDeleteAction } from './delete';
 import { createMockActionContext } from '@backstage/plugin-scaffolder-node-test-utils';
 import fs from 'fs-extra';

plugins/scaffolder-backend/src/scaffolder/actions/builtin/filesystem/read.examples.test.ts

@@ -16,7 +16,7 @@
 
 import { createFilesystemReadDirAction } from './read';
 import { createMockActionContext } from '@backstage/plugin-scaffolder-node-test-utils';
-import { resolve as resolvePath } from 'path';
+import { resolve as resolvePath } from 'node:path';
 import { createMockDirectory } from '@backstage/backend-test-utils';
 import { examples } from './read.examples';
 import yaml from 'yaml';

plugins/scaffolder-backend/src/scaffolder/actions/builtin/filesystem/read.ts

@@ -15,8 +15,8 @@
  */
 import { createTemplateAction } from '@backstage/plugin-scaffolder-node';
 import { resolveSafeChildPath } from '@backstage/backend-plugin-api';
-import fs from 'fs/promises';
-import path from 'path';
+import fs from 'node:fs/promises';
+import path from 'node:path';
 import { z as zod } from 'zod';
 import { examples } from './read.examples';
 

plugins/scaffolder-backend/src/scaffolder/actions/builtin/filesystem/rename.examples.test.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import { resolve as resolvePath } from 'path';
+import { resolve as resolvePath } from 'node:path';
 import { createFilesystemRenameAction } from './rename';
 import { createMockActionContext } from '@backstage/plugin-scaffolder-node-test-utils';
 import fs from 'fs-extra';

plugins/scaffolder-backend/src/scaffolder/actions/builtin/filesystem/rename.test.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import { resolve as resolvePath } from 'path';
+import { resolve as resolvePath } from 'node:path';
 import { createFilesystemRenameAction } from './rename';
 import { createMockActionContext } from '@backstage/plugin-scaffolder-node-test-utils';
 import fs from 'fs-extra';

plugins/scaffolder-backend/src/scaffolder/dryrun/createDryRunner.ts

@@ -39,8 +39,8 @@ import {
 } from '@backstage/plugin-scaffolder-node';
 import { JsonObject } from '@backstage/types';
 import fs from 'fs-extra';
-import path from 'path';
-import { fileURLToPath } from 'url';
+import path from 'node:path';
+import { fileURLToPath } from 'node:url';
 import { v4 as uuid } from 'uuid';
 import { NunjucksWorkflowRunner } from '../tasks/NunjucksWorkflowRunner';
 import { DecoratedActionsRegistry } from './DecoratedActionsRegistry';

plugins/scaffolder-backend/src/scaffolder/tasks/NunjucksWorkflowRunner.ts

@@ -27,7 +27,7 @@ import { metrics } from '@opentelemetry/api';
 import fs from 'fs-extra';
 import { validate as validateJsonSchema } from 'jsonschema';
 import nunjucks from 'nunjucks';
-import path from 'path';
+import path from 'node:path';
 import * as winston from 'winston';
 import {
   SecureTemplater,

plugins/scaffolder-backend/src/scaffolder/tasks/TaskWorker.test.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import os from 'os';
+import os from 'node:os';
 import { DatabaseManager } from '@backstage/backend-defaults/database';
 import { ConfigReader } from '@backstage/config';
 import { DatabaseTaskStore } from './DatabaseTaskStore';

plugins/scaffolder-backend/src/scaffolder/tasks/TaskWorker.ts

@@ -28,7 +28,7 @@ import PQueue from 'p-queue';
 import { TemplateActionRegistry } from '../actions/TemplateActionRegistry';
 import { NunjucksWorkflowRunner } from './NunjucksWorkflowRunner';
 import { WorkflowRunner } from './types';
-import { setTimeout } from 'timers/promises';
+import { setTimeout } from 'node:timers/promises';
 import { JsonObject } from '@backstage/types';
 import { Config } from '@backstage/config';
 

plugins/scaffolder-backend/src/service/helpers.ts

@@ -31,7 +31,7 @@ import { assertError, InputError, NotFoundError } from '@backstage/errors';
 import { CatalogService } from '@backstage/plugin-catalog-node';
 import { TemplateEntityV1beta3 } from '@backstage/plugin-scaffolder-common';
 import fs from 'fs-extra';
-import os from 'os';
+import os from 'node:os';
 
 export async function getWorkingDirectory(
   config: Config,

plugins/scaffolder-backend/src/service/router.ts

@@ -82,7 +82,7 @@ import {
 import { HumanDuration, JsonObject } from '@backstage/types';
 import express from 'express';
 import { Duration } from 'luxon';
-import { pathToFileURL } from 'url';
+import { pathToFileURL } from 'node:url';
 import { v4 as uuid } from 'uuid';
 import { z } from 'zod';
 import {