From f008f26970dfe2722603d01c2ecf5d87d0e68135 Mon Sep 17 00:00:00 2001
From: Eric Peterson <ericpeterson@spotify.com>
Date: Thu, 6 Mar 2025 09:15:57 +0100
Subject: [PATCH] Better option names

Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
---
 .changeset/mira-color-like.md                | 2 +-
 packages/frontend-defaults/report.api.md     | 2 +-
 packages/frontend-defaults/src/createApp.tsx | 2 +-
 packages/frontend-defaults/src/discovery.ts  | 4 ++--
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/.changeset/mira-color-like.md b/.changeset/mira-color-like.md
index fac24490be..45bff186f1 100644
--- a/.changeset/mira-color-like.md
+++ b/.changeset/mira-color-like.md
@@ -1,5 +1,5 @@
 ---
-'@backstage/frontend-defaults': minor
+'@backstage/frontend-defaults': patch
 ---
 
 Feature resolution logic used in `createApp` is now exposed via the `resolveFeatures` function.
diff --git a/packages/frontend-defaults/report.api.md b/packages/frontend-defaults/report.api.md
index 1b8183e7bd..ac9c7a7312 100644
--- a/packages/frontend-defaults/report.api.md
+++ b/packages/frontend-defaults/report.api.md
@@ -48,6 +48,6 @@ export function createPublicSignInApp(options?: CreateAppOptions): {
 // @public (undocumented)
 export function resolveFeatures(options: {
   config: Config;
-  providedFeatures?: (FrontendFeature | CreateAppFeatureLoader)[];
+  features?: (FrontendFeature | CreateAppFeatureLoader)[];
 }): Promise<FrontendFeature[]>;
 ```
diff --git a/packages/frontend-defaults/src/createApp.tsx b/packages/frontend-defaults/src/createApp.tsx
index 0eb4d4a8e8..ae524e93e2 100644
--- a/packages/frontend-defaults/src/createApp.tsx
+++ b/packages/frontend-defaults/src/createApp.tsx
@@ -91,7 +91,7 @@ export function createApp(options?: CreateAppOptions): {
       config,
       features: await resolveFeatures({
         config,
-        providedFeatures: options?.features,
+        features: options?.features,
       }),
       bindRoutes: options?.bindRoutes,
       extensionFactoryMiddleware: options?.extensionFactoryMiddleware,
diff --git a/packages/frontend-defaults/src/discovery.ts b/packages/frontend-defaults/src/discovery.ts
index b80f9a1b39..c71d7d15ea 100644
--- a/packages/frontend-defaults/src/discovery.ts
+++ b/packages/frontend-defaults/src/discovery.ts
@@ -101,11 +101,11 @@ function isBackstageFeature(obj: unknown): obj is FrontendFeature {
 /** @public */
 export async function resolveFeatures(options: {
   config: Config;
-  providedFeatures?: (FrontendFeature | CreateAppFeatureLoader)[];
+  features?: (FrontendFeature | CreateAppFeatureLoader)[];
 }): Promise<FrontendFeature[]> {
   const discoveredFeatures = getAvailableFeatures(options.config);
   const features = [appPlugin, ...discoveredFeatures];
-  for (const entry of options.providedFeatures ?? []) {
+  for (const entry of options.features ?? []) {
     if ('load' in entry) {
       try {
         const result = await entry.load({ config: options.config });