Further review feedback.

Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
This commit is contained in:
Eric Peterson
2022-06-10 11:05:41 +02:00
parent 2dc4818541
commit effb3b27a4
7 changed files with 35 additions and 48 deletions
@@ -317,8 +317,8 @@ describe('SearchBar', () => {
expect(analyticsApiSpy.getEvents()[0]).toEqual({
action: 'search',
context: {
extension: 'App',
pluginId: 'root',
extension: 'SearchBar',
pluginId: 'search',
routeRef: 'unknown',
searchTypes: 'software-catalog,techdocs',
},
@@ -340,8 +340,8 @@ describe('SearchBar', () => {
expect(analyticsApiSpy.getEvents()[1]).toEqual({
action: 'search',
context: {
extension: 'App',
pluginId: 'root',
extension: 'SearchBar',
pluginId: 'search',
routeRef: 'unknown',
searchTypes: 'software-catalog,techdocs',
},
@@ -31,7 +31,11 @@ import {
import SearchIcon from '@material-ui/icons/Search';
import ClearButton from '@material-ui/icons/Clear';
import { configApiRef, useApi } from '@backstage/core-plugin-api';
import {
AnalyticsContext,
configApiRef,
useApi,
} from '@backstage/core-plugin-api';
import {
SearchContextProvider,
@@ -175,5 +179,11 @@ export const SearchBar = ({ onChange, ...props }: SearchBarProps) => {
[onChange, setTerm],
);
return <SearchBarBase value={term} onChange={handleChange} {...props} />;
return (
<AnalyticsContext
attributes={{ pluginId: 'search', extension: 'SearchBar' }}
>
<SearchBarBase value={term} onChange={handleChange} {...props} />
</AnalyticsContext>
);
};
@@ -16,7 +16,6 @@
export { CheckboxFilter, SearchFilter, SelectFilter } from './SearchFilter';
export { AutocompleteFilter } from './SearchFilter.Autocomplete';
export { useAsyncFilterValues, useDefaultFilterValue } from './hooks';
export type {
SearchFilterComponentProps,
SearchFilterWrapperProps,