From 4d23a5c7b240c474e02ea6e60d74941439589815 Mon Sep 17 00:00:00 2001 From: Alex Crome Date: Fri, 28 Oct 2022 08:51:52 +0100 Subject: [PATCH 1/3] Fix casing of EntityNamePicker validation error message The error message for `EntityNamePicker` has two sentences. The first word of the second sentence is capitalised, but the first sentence was not. This fixes the capitalisation of the first sentence. Signed-off-by: Alex Crome --- .../src/components/fields/EntityNamePicker/validation.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/scaffolder/src/components/fields/EntityNamePicker/validation.ts b/plugins/scaffolder/src/components/fields/EntityNamePicker/validation.ts index 7a40a460ba..d116bef228 100644 --- a/plugins/scaffolder/src/components/fields/EntityNamePicker/validation.ts +++ b/plugins/scaffolder/src/components/fields/EntityNamePicker/validation.ts @@ -23,7 +23,7 @@ export const entityNamePickerValidation = ( ) => { if (!KubernetesValidatorFunctions.isValidObjectName(value)) { validation.addError( - 'must start and end with an alphanumeric character, and contain only alphanumeric characters, hyphens, underscores, and periods. Maximum length is 63 characters.', + 'Must start and end with an alphanumeric character, and contain only alphanumeric characters, hyphens, underscores, and periods. Maximum length is 63 characters.', ); } }; From 87840c8c6c019d79a96b4b8023c8a38f134d846c Mon Sep 17 00:00:00 2001 From: Alex Crome Date: Fri, 11 Nov 2022 21:14:21 +0000 Subject: [PATCH 2/3] Add missing changeset Signed-off-by: Alex Crome --- .changeset/good-doors-attend.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/good-doors-attend.md diff --git a/.changeset/good-doors-attend.md b/.changeset/good-doors-attend.md new file mode 100644 index 0000000000..43294b252a --- /dev/null +++ b/.changeset/good-doors-attend.md @@ -0,0 +1,5 @@ +--- +'@backstage/plugin-scaffolder': patch +--- + +Fixed tiny grammar error in EntityNamePicker. The first letter of the description is now capatalised. From 4077ec711e9f945014b9a6880fa41f0b5c325125 Mon Sep 17 00:00:00 2001 From: Patrik Oldsberg Date: Mon, 14 Nov 2022 14:49:24 +0100 Subject: [PATCH 3/3] Update .changeset/good-doors-attend.md Signed-off-by: Patrik Oldsberg --- .changeset/good-doors-attend.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/good-doors-attend.md b/.changeset/good-doors-attend.md index 43294b252a..0f8a5344ee 100644 --- a/.changeset/good-doors-attend.md +++ b/.changeset/good-doors-attend.md @@ -2,4 +2,4 @@ '@backstage/plugin-scaffolder': patch --- -Fixed tiny grammar error in EntityNamePicker. The first letter of the description is now capatalised. +Fixed tiny grammar error in EntityNamePicker. The first letter of the description is now capitalized.