From eef3ef178526d5a09966d61ffa9c84764182e50b Mon Sep 17 00:00:00 2001 From: Patrik Oldsberg Date: Sat, 23 Nov 2024 00:59:54 +0100 Subject: [PATCH] backend-*-api: remove unused express dependencies Signed-off-by: Patrik Oldsberg --- .changeset/forty-apples-complain.md | 6 ++++++ packages/backend-app-api/package.json | 2 -- packages/backend-plugin-api/package.json | 1 - packages/backend-plugin-api/report.api.md | 6 +++--- .../src/services/definitions/HttpAuthService.ts | 2 +- .../src/services/definitions/HttpRouterService.ts | 2 +- .../src/services/definitions/RootHttpRouterService.ts | 2 +- yarn.lock | 3 --- 8 files changed, 12 insertions(+), 12 deletions(-) create mode 100644 .changeset/forty-apples-complain.md diff --git a/.changeset/forty-apples-complain.md b/.changeset/forty-apples-complain.md new file mode 100644 index 0000000000..5aa177a63f --- /dev/null +++ b/.changeset/forty-apples-complain.md @@ -0,0 +1,6 @@ +--- +'@backstage/backend-plugin-api': patch +'@backstage/backend-app-api': patch +--- + +Removed unused `express` dependencies. diff --git a/packages/backend-app-api/package.json b/packages/backend-app-api/package.json index 60fb75170b..68387aa4a1 100644 --- a/packages/backend-app-api/package.json +++ b/packages/backend-app-api/package.json @@ -62,8 +62,6 @@ "compression": "^1.7.4", "cookie": "^0.7.0", "cors": "^2.8.5", - "express": "^4.17.1", - "express-promise-router": "^4.1.0", "helmet": "^6.0.0", "jose": "^5.0.0", "knex": "^3.0.0", diff --git a/packages/backend-plugin-api/package.json b/packages/backend-plugin-api/package.json index 9a978dea02..9b3cc0266b 100644 --- a/packages/backend-plugin-api/package.json +++ b/packages/backend-plugin-api/package.json @@ -61,7 +61,6 @@ "@backstage/types": "workspace:^", "@types/express": "^4.17.6", "@types/luxon": "^3.0.0", - "express": "^4.17.1", "knex": "^3.0.0", "luxon": "^3.0.0" }, diff --git a/packages/backend-plugin-api/report.api.md b/packages/backend-plugin-api/report.api.md index 89dfe40dd9..a886ba4271 100644 --- a/packages/backend-plugin-api/report.api.md +++ b/packages/backend-plugin-api/report.api.md @@ -10,7 +10,7 @@ import { AuthorizePermissionResponse } from '@backstage/plugin-permission-common import { Config } from '@backstage/config'; import { Duration } from 'luxon'; import { EvaluatorRequestOptions } from '@backstage/plugin-permission-common'; -import { Handler } from 'express'; +import type { Handler } from 'express'; import { HumanDuration } from '@backstage/types'; import { isChildPath } from '@backstage/cli-common'; import { JsonObject } from '@backstage/types'; @@ -21,8 +21,8 @@ import { PermissionEvaluator } from '@backstage/plugin-permission-common'; import { QueryPermissionRequest } from '@backstage/plugin-permission-common'; import { QueryPermissionResponse } from '@backstage/plugin-permission-common'; import { Readable } from 'stream'; -import { Request as Request_2 } from 'express'; -import { Response as Response_2 } from 'express'; +import type { Request as Request_2 } from 'express'; +import type { Response as Response_2 } from 'express'; // @public export interface AuthService { diff --git a/packages/backend-plugin-api/src/services/definitions/HttpAuthService.ts b/packages/backend-plugin-api/src/services/definitions/HttpAuthService.ts index 718aa9b532..152bb205de 100644 --- a/packages/backend-plugin-api/src/services/definitions/HttpAuthService.ts +++ b/packages/backend-plugin-api/src/services/definitions/HttpAuthService.ts @@ -14,7 +14,7 @@ * limitations under the License. */ -import { Request, Response } from 'express'; +import type { Request, Response } from 'express'; import { BackstageCredentials, BackstagePrincipalTypes } from './AuthService'; /** diff --git a/packages/backend-plugin-api/src/services/definitions/HttpRouterService.ts b/packages/backend-plugin-api/src/services/definitions/HttpRouterService.ts index 92f7e950f9..529d7481f1 100644 --- a/packages/backend-plugin-api/src/services/definitions/HttpRouterService.ts +++ b/packages/backend-plugin-api/src/services/definitions/HttpRouterService.ts @@ -14,7 +14,7 @@ * limitations under the License. */ -import { Handler } from 'express'; +import type { Handler } from 'express'; /** * Options for {@link HttpRouterService.addAuthPolicy}. diff --git a/packages/backend-plugin-api/src/services/definitions/RootHttpRouterService.ts b/packages/backend-plugin-api/src/services/definitions/RootHttpRouterService.ts index a1006b749b..8bd0cad874 100644 --- a/packages/backend-plugin-api/src/services/definitions/RootHttpRouterService.ts +++ b/packages/backend-plugin-api/src/services/definitions/RootHttpRouterService.ts @@ -14,7 +14,7 @@ * limitations under the License. */ -import { Handler } from 'express'; +import type { Handler } from 'express'; /** * HTTP route registration for root services. diff --git a/yarn.lock b/yarn.lock index 393d278a8d..79bbe98339 100644 --- a/yarn.lock +++ b/yarn.lock @@ -3470,8 +3470,6 @@ __metadata: compression: ^1.7.4 cookie: ^0.7.0 cors: ^2.8.5 - express: ^4.17.1 - express-promise-router: ^4.1.0 helmet: ^6.0.0 http-errors: ^2.0.0 jose: ^5.0.0 @@ -3754,7 +3752,6 @@ __metadata: "@backstage/types": "workspace:^" "@types/express": ^4.17.6 "@types/luxon": ^3.0.0 - express: ^4.17.1 knex: ^3.0.0 luxon: ^3.0.0 languageName: unknown