resolved @Rugvip comments

Signed-off-by: Luka Siric <siric.luka@gmail.com>
This commit is contained in:
Luka Siric
2022-08-30 16:33:47 +02:00
parent 08eb42afdc
commit eef0522644
6 changed files with 43 additions and 37 deletions
+2 -4
View File
@@ -64,12 +64,10 @@ export async function serveBundle(options: ServeOptions) {
https:
url.protocol === 'https:'
? {
cert: options.frontendConfig.getOptionalString(
cert: options.backendConfig.getString(
'app.https.certificate.cert',
),
key: options.backendConfig.getOptionalString(
'app.https.certificate.key',
),
key: options.backendConfig.getString('app.https.certificate.key'),
}
: false,
host,
-1
View File
@@ -32,7 +32,6 @@ export type ServeOptions = BundlingPathsOptions & {
frontendConfig: Config;
frontendAppConfigs: AppConfig[];
backendConfig: Config;
backendAppConfigs: AppConfig[];
};
export type BuildOptions = BundlingPathsOptions & {
+1 -6
View File
@@ -96,11 +96,7 @@ export async function loadCliConfig(options: Options) {
});
const frontendConfig = ConfigReader.fromConfigs(frontendAppConfigs);
const backendAppConfigs = schema.process(appConfigs, {
visibility: ['frontend', 'backend', 'secret'],
withFilteredKeys: options.withFilteredKeys,
withDeprecatedKeys: options.withDeprecatedKeys,
});
const backendAppConfigs = schema.process(appConfigs);
const backendConfig = ConfigReader.fromConfigs(backendAppConfigs);
return {
@@ -108,7 +104,6 @@ export async function loadCliConfig(options: Options) {
appConfigs,
frontendConfig,
frontendAppConfigs,
backendAppConfigs,
backendConfig,
};
} catch (error) {