From 18f17569084c482fc44b8d1e79959d37fa6a7576 Mon Sep 17 00:00:00 2001
From: npiyush97 <npiyush35@gmail.com>
Date: Mon, 25 Sep 2023 16:10:53 +0530
Subject: [PATCH 1/3] added aria label for better a11y score

Signed-off-by: npiyush97 <npiyush35@gmail.com>
---
 .changeset/wet-olives-wave.md                         | 5 +++++
 plugins/api-docs/src/components/ApisCards/presets.tsx | 8 ++++++--
 2 files changed, 11 insertions(+), 2 deletions(-)
 create mode 100644 .changeset/wet-olives-wave.md

diff --git a/.changeset/wet-olives-wave.md b/.changeset/wet-olives-wave.md
new file mode 100644
index 0000000000..5b35e0ad90
--- /dev/null
+++ b/.changeset/wet-olives-wave.md
@@ -0,0 +1,5 @@
+---
+'@backstage/plugin-api-docs': patch
+---
+
+added aria-label on api definition button for better a11y.
diff --git a/plugins/api-docs/src/components/ApisCards/presets.tsx b/plugins/api-docs/src/components/ApisCards/presets.tsx
index b1ef39c113..38f75ecf95 100644
--- a/plugins/api-docs/src/components/ApisCards/presets.tsx
+++ b/plugins/api-docs/src/components/ApisCards/presets.tsx
@@ -33,10 +33,14 @@ export function createSpecApiTypeColumn(): TableColumn<ApiEntity> {
 
 const ApiDefinitionButton = ({ apiEntity }: { apiEntity: ApiEntity }) => {
   const [dialogOpen, setDialogOpen] = useState(false);
-
+  // eslint-disable-next-line no-console
+  console.log('this is the one');
   return (
     <>
-      <ToggleButton onClick={() => setDialogOpen(!dialogOpen)}>
+      <ToggleButton
+        aria-label="Toggle API Defination Dialog"
+        onClick={() => setDialogOpen(!dialogOpen)}
+      >
         <ExtensionIcon />
       </ToggleButton>
       <ApiDefinitionDialog

From 199f54def40350bc7a1b44cbdb37221188c8edcd Mon Sep 17 00:00:00 2001
From: PIYUSH NEGI <43876655+npiyush97@users.noreply.github.com>
Date: Mon, 25 Sep 2023 16:49:24 +0530
Subject: [PATCH 2/3] Update presets.tsx

Signed-off-by: PIYUSH NEGI <43876655+npiyush97@users.noreply.github.com>
---
 plugins/api-docs/src/components/ApisCards/presets.tsx | 2 --
 1 file changed, 2 deletions(-)

diff --git a/plugins/api-docs/src/components/ApisCards/presets.tsx b/plugins/api-docs/src/components/ApisCards/presets.tsx
index 38f75ecf95..d45cf5ea64 100644
--- a/plugins/api-docs/src/components/ApisCards/presets.tsx
+++ b/plugins/api-docs/src/components/ApisCards/presets.tsx
@@ -33,8 +33,6 @@ export function createSpecApiTypeColumn(): TableColumn<ApiEntity> {
 
 const ApiDefinitionButton = ({ apiEntity }: { apiEntity: ApiEntity }) => {
   const [dialogOpen, setDialogOpen] = useState(false);
-  // eslint-disable-next-line no-console
-  console.log('this is the one');
   return (
     <>
       <ToggleButton

From e77ecb6e9d8b5290a9e67266892458db769ab82c Mon Sep 17 00:00:00 2001
From: PIYUSH NEGI <43876655+npiyush97@users.noreply.github.com>
Date: Mon, 25 Sep 2023 17:55:34 +0530
Subject: [PATCH 3/3] Update
 plugins/api-docs/src/components/ApisCards/presets.tsx
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Co-authored-by: Fredrik Adelöw <freben@gmail.com>
Signed-off-by: PIYUSH NEGI <43876655+npiyush97@users.noreply.github.com>
---
 plugins/api-docs/src/components/ApisCards/presets.tsx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/plugins/api-docs/src/components/ApisCards/presets.tsx b/plugins/api-docs/src/components/ApisCards/presets.tsx
index d45cf5ea64..050944b239 100644
--- a/plugins/api-docs/src/components/ApisCards/presets.tsx
+++ b/plugins/api-docs/src/components/ApisCards/presets.tsx
@@ -36,7 +36,7 @@ const ApiDefinitionButton = ({ apiEntity }: { apiEntity: ApiEntity }) => {
   return (
     <>
       <ToggleButton
-        aria-label="Toggle API Defination Dialog"
+        aria-label="Toggle API Definition Dialog"
         onClick={() => setDialogOpen(!dialogOpen)}
       >
         <ExtensionIcon />