From ec794b9e8bf0b035768c306b7c533690fbe36b81 Mon Sep 17 00:00:00 2001
From: Patrik Oldsberg <poldsberg@gmail.com>
Date: Sun, 15 Mar 2026 13:04:02 +0100
Subject: [PATCH] frontend-app-api: fix changed-package lint regressions

Declare the new frontend test dependencies, avoid the finalize options shadowing lint error, and add explicit assertions in frontend-test-utils so the changed-package lint jobs pass again.

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Made-with: Cursor
---
 packages/frontend-defaults/package.json              |  2 ++
 packages/frontend-test-utils/package.json            |  1 +
 .../src/apis/TestApiProvider.test.tsx                | 12 ++++++++++++
 yarn.lock                                            |  3 +++
 4 files changed, 18 insertions(+)

diff --git a/packages/frontend-defaults/package.json b/packages/frontend-defaults/package.json
index 0ff81a490f..622763a6c9 100644
--- a/packages/frontend-defaults/package.json
+++ b/packages/frontend-defaults/package.json
@@ -43,6 +43,8 @@
     "@backstage/cli": "workspace:^",
     "@backstage/core-plugin-api": "workspace:^",
     "@backstage/plugin-app-react": "workspace:^",
+    "@backstage/plugin-permission-common": "workspace:^",
+    "@backstage/plugin-permission-react": "workspace:^",
     "@backstage/test-utils": "workspace:^",
     "@testing-library/jest-dom": "^6.0.0",
     "@testing-library/react": "^16.0.0",
diff --git a/packages/frontend-test-utils/package.json b/packages/frontend-test-utils/package.json
index 13de1ef239..59c5545a81 100644
--- a/packages/frontend-test-utils/package.json
+++ b/packages/frontend-test-utils/package.json
@@ -34,6 +34,7 @@
     "@backstage/config": "workspace:^",
     "@backstage/core-app-api": "workspace:^",
     "@backstage/core-plugin-api": "workspace:^",
+    "@backstage/filter-predicates": "workspace:^",
     "@backstage/frontend-app-api": "workspace:^",
     "@backstage/frontend-plugin-api": "workspace:^",
     "@backstage/plugin-app": "workspace:^",
diff --git a/packages/frontend-test-utils/src/apis/TestApiProvider.test.tsx b/packages/frontend-test-utils/src/apis/TestApiProvider.test.tsx
index 1bb5673751..5d27e3a228 100644
--- a/packages/frontend-test-utils/src/apis/TestApiProvider.test.tsx
+++ b/packages/frontend-test-utils/src/apis/TestApiProvider.test.tsx
@@ -38,6 +38,8 @@ describe('TestApiProvider', () => {
         <div />
       </TestApiProvider>,
     );
+
+    expect(document.body).toBeInTheDocument();
   });
 
   it('should allow partial API implementations', () => {
@@ -46,6 +48,8 @@ describe('TestApiProvider', () => {
         <div />
       </TestApiProvider>,
     );
+
+    expect(document.body).toBeInTheDocument();
   });
 
   it('should reject mismatched types in tuple syntax', () => {
@@ -55,6 +59,8 @@ describe('TestApiProvider', () => {
         <div />
       </TestApiProvider>,
     );
+
+    expect(document.body).toBeInTheDocument();
   });
 
   it('should accept MockWithApiFactory entries', () => {
@@ -63,6 +69,8 @@ describe('TestApiProvider', () => {
         <div />
       </TestApiProvider>,
     );
+
+    expect(document.body).toBeInTheDocument();
   });
 
   it('should accept a mix of tuples and MockWithApiFactory entries', () => {
@@ -71,6 +79,8 @@ describe('TestApiProvider', () => {
         <div />
       </TestApiProvider>,
     );
+
+    expect(document.body).toBeInTheDocument();
   });
 
   it('should allow empty APIs', () => {
@@ -79,6 +89,8 @@ describe('TestApiProvider', () => {
         <div />
       </TestApiProvider>,
     );
+
+    expect(document.body).toBeInTheDocument();
   });
 
   it('should provide APIs at runtime', async () => {
diff --git a/yarn.lock b/yarn.lock
index d9f53d1439..072fb23cee 100644
--- a/yarn.lock
+++ b/yarn.lock
@@ -3670,6 +3670,8 @@ __metadata:
     "@backstage/frontend-plugin-api": "workspace:^"
     "@backstage/plugin-app": "workspace:^"
     "@backstage/plugin-app-react": "workspace:^"
+    "@backstage/plugin-permission-common": "workspace:^"
+    "@backstage/plugin-permission-react": "workspace:^"
     "@backstage/test-utils": "workspace:^"
     "@react-hookz/web": "npm:^24.0.0"
     "@testing-library/jest-dom": "npm:^6.0.0"
@@ -3789,6 +3791,7 @@ __metadata:
     "@backstage/config": "workspace:^"
     "@backstage/core-app-api": "workspace:^"
     "@backstage/core-plugin-api": "workspace:^"
+    "@backstage/filter-predicates": "workspace:^"
     "@backstage/frontend-app-api": "workspace:^"
     "@backstage/frontend-plugin-api": "workspace:^"
     "@backstage/plugin-app": "workspace:^"