paulononato/backstage
1
0
Fork 0
Code Issues Pull Requests Actions 40 Packages Projects Releases Wiki Activity

Merge pull request #20673 from backstage/rugvip/import

Browse Source 
dev-utils,techdocs: use dynamic import instead of require for conditional react-dom
This commit is contained in:
Patrik Oldsberg
2023-10-19 11:27:51 +02:00
committed by GitHub
parent 720656a4a9 67cc85bb14
commit ec21927c0d
3 changed files with 32 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/techdocs/src/reader/transformers/renderReactElement.ts
+12 -8
View File
@@ -14,18 +14,22 @@
* limitations under the License.
*/
let ReactDOM: typeof import('react-dom') | typeof import('react-dom/client');
let ReactDOMPromise: Promise<
typeof import('react-dom') | typeof import('react-dom/client')
>;
if (process.env.HAS_REACT_DOM_CLIENT) {
ReactDOM = require('react-dom/client');
ReactDOMPromise = import('react-dom/client');
} else {
ReactDOM = require('react-dom');
ReactDOMPromise = import('react-dom');
}
/** @internal */
export function renderReactElement(element: JSX.Element, root: HTMLElement) {
if ('createRoot' in ReactDOM) {
ReactDOM.createRoot(root).render(element);
} else {
ReactDOM.render(element, root);
}
ReactDOMPromise.then(ReactDOM => {
if ('createRoot' in ReactDOM) {
ReactDOM.createRoot(root).render(element);
} else {
ReactDOM.render(element, root);
}
});
}