refactor: stop using getVoidLogger in tests

Signed-off-by: Camila Belo <camilaibs@gmail.com>

plugins/proxy-backend/src/service/router.config.test.ts

@@ -14,7 +14,10 @@
  * limitations under the License.
  */
 
-import { getVoidLogger, HostDiscovery } from '@backstage/backend-common';
+import {
+  HostDiscovery,
+  loggerToWinstonLogger,
+} from '@backstage/backend-common';
 import {
   ConfigSources,
   MutableConfigSource,
@@ -25,6 +28,7 @@ import { rest } from 'msw';
 import { setupServer } from 'msw/node';
 import request from 'supertest';
 import { createRouter } from './router';
+import { mockServices } from '@backstage/backend-test-utils';
 
 // this test is stored in its own file to work around the mocked
 // http-proxy-middleware module used in the rest of the tests
@@ -57,7 +61,7 @@ describe('createRouter reloadable configuration', () => {
   afterEach(() => server.resetHandlers());
 
   it('should be able to observe the config', async () => {
-    const logger = getVoidLogger();
+    const logger = loggerToWinstonLogger(mockServices.logger.mock());
 
     // Grab the subscriber function and use mutable config data to mock a config file change
     const mutableConfigSource = MutableConfigSource.create({ data: {} });

plugins/proxy-backend/src/service/router.test.ts

@@ -14,7 +14,10 @@
  * limitations under the License.
  */
 
-import { getVoidLogger, HostDiscovery } from '@backstage/backend-common';
+import {
+  HostDiscovery,
+  loggerToWinstonLogger,
+} from '@backstage/backend-common';
 import { mockServices } from '@backstage/backend-test-utils';
 import { ConfigReader } from '@backstage/config';
 import { Request, Response } from 'express';
@@ -37,7 +40,7 @@ const mockCreateProxyMiddleware = createProxyMiddleware as jest.MockedFunction<
 
 describe('createRouter', () => {
   describe('where all proxy config are valid', () => {
-    const logger = getVoidLogger();
+    const logger = loggerToWinstonLogger(mockServices.logger.mock());
     const config = new ConfigReader({
       backend: {
         baseUrl: 'https://example.com:7007',
@@ -130,7 +133,7 @@ describe('createRouter', () => {
 
   describe('where buildMiddleware would fail', () => {
     it('throws an error if skip failures is not set', async () => {
-      const logger = getVoidLogger();
+      const logger = loggerToWinstonLogger(mockServices.logger.mock());
       logger.warn = jest.fn();
       const config = new ConfigReader({
         backend: {
@@ -165,7 +168,7 @@ describe('createRouter', () => {
     });
 
     it('works if skip failures is set', async () => {
-      const logger = getVoidLogger();
+      const logger = loggerToWinstonLogger(mockServices.logger.mock());
       logger.warn = jest.fn();
       const config = new ConfigReader({
         backend: {
@@ -201,7 +204,7 @@ describe('createRouter', () => {
 });
 
 describe('buildMiddleware', () => {
-  const logger = getVoidLogger();
+  const logger = loggerToWinstonLogger(mockServices.logger.mock());
 
   beforeEach(() => {
     mockCreateProxyMiddleware.mockClear();