refactor: stop using getVoidLogger in tests

Signed-off-by: Camila Belo <camilaibs@gmail.com>
This commit is contained in:
Camila Belo
2024-05-15 09:09:54 +02:00
parent 819754e57e
commit eb34b87d5a
118 changed files with 533 additions and 433 deletions
@@ -15,11 +15,10 @@
*/
import { Knex as KnexType } from 'knex';
import { getVoidLogger } from '@backstage/backend-common';
import { TestDatabases } from '@backstage/backend-test-utils';
import { TestDatabases, mockServices } from '@backstage/backend-test-utils';
import { StaticAssetsStore } from './StaticAssetsStore';
const logger = getVoidLogger();
const logger = mockServices.logger.mock();
function createDatabaseManager(
client: KnexType,
+5 -3
View File
@@ -14,8 +14,10 @@
* limitations under the License.
*/
import { getVoidLogger } from '@backstage/backend-common';
import { createMockDirectory } from '@backstage/backend-test-utils';
import {
createMockDirectory,
mockServices,
} from '@backstage/backend-test-utils';
import { injectConfig } from './config';
describe('injectConfig', () => {
@@ -24,7 +26,7 @@ describe('injectConfig', () => {
const baseOptions = {
appConfigs: [],
staticDir: mockDir.path,
logger: getVoidLogger(),
logger: mockServices.logger.mock(),
};
beforeEach(() => {
@@ -14,7 +14,6 @@
* limitations under the License.
*/
import { getVoidLogger } from '@backstage/backend-common';
import { AppConfig, ConfigReader } from '@backstage/config';
import express from 'express';
import Router from 'express-promise-router';
@@ -22,6 +21,7 @@ import { resolve as resolvePath } from 'path';
import request from 'supertest';
import { createRouter } from './router';
import { loadConfigSchema } from '@backstage/config-loader';
import { mockServices } from '@backstage/backend-test-utils';
jest.mock('../lib/config', () => ({
injectConfig: jest.fn(),
@@ -38,7 +38,7 @@ describe('createRouter', () => {
beforeAll(async () => {
const router = await createRouter({
logger: getVoidLogger(),
logger: mockServices.logger.mock(),
config: new ConfigReader({}),
appPackageName: 'example-app',
});
@@ -96,7 +96,7 @@ describe('createRouter with static fallback handler', () => {
});
const router = await createRouter({
logger: getVoidLogger(),
logger: mockServices.logger.mock(),
config: new ConfigReader({}),
appPackageName: 'example-app',
staticFallbackHandler,
@@ -129,7 +129,7 @@ describe('createRouter config schema test', () => {
it('uses an external schema', async () => {
await createRouter({
logger: getVoidLogger(),
logger: mockServices.logger.mock(),
config: new ConfigReader({
test: 'value',
}),
@@ -170,7 +170,7 @@ describe('createRouter config schema test', () => {
it('uses no external schema', async () => {
await createRouter({
logger: getVoidLogger(),
logger: mockServices.logger.mock(),
config: new ConfigReader({
test: 'value',
}),