From ea3970a51d5a4e4c7c802baf8b1a22d41a8365b1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Sofia=20Sj=C3=B6blad?= <ssjoblad@spotify.com>
Date: Tue, 7 Oct 2025 10:35:01 +0200
Subject: [PATCH] add mandatory href for tabs in header component
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Sofia Sjöblad <ssjoblad@spotify.com>
---
 packages/ui/src/components/Header/types.ts                   | 2 +-
 packages/ui/src/components/HeaderPage/HeaderPage.stories.tsx | 5 +++++
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/packages/ui/src/components/Header/types.ts b/packages/ui/src/components/Header/types.ts
index 41bc437a18..c7c602abfc 100644
--- a/packages/ui/src/components/Header/types.ts
+++ b/packages/ui/src/components/Header/types.ts
@@ -39,7 +39,7 @@ export interface HeaderProps {
 export interface HeaderTab {
   id: string;
   label: string;
-  href?: string;
+  href: string;
   /**
    * Strategy for matching the current route to determine if this tab should be active.
    * - 'exact': Tab href must exactly match the current pathname (default)
diff --git a/packages/ui/src/components/HeaderPage/HeaderPage.stories.tsx b/packages/ui/src/components/HeaderPage/HeaderPage.stories.tsx
index c4849ddc20..385ff0b10d 100644
--- a/packages/ui/src/components/HeaderPage/HeaderPage.stories.tsx
+++ b/packages/ui/src/components/HeaderPage/HeaderPage.stories.tsx
@@ -44,22 +44,27 @@ const tabs: HeaderTab[] = [
   {
     id: 'overview',
     label: 'Overview',
+    href: '/overview',
   },
   {
     id: 'checks',
     label: 'Checks',
+    href: '/checks',
   },
   {
     id: 'tracks',
     label: 'Tracks',
+    href: '/tracks',
   },
   {
     id: 'campaigns',
     label: 'Campaigns',
+    href: '/campaigns',
   },
   {
     id: 'integrations',
     label: 'Integrations',
+    href: '/integrations',
   },
 ];