From ea1cfdff516925f36252ca72ffefefda2d719db5 Mon Sep 17 00:00:00 2001
From: Samira Mokaram <samiram@spotify.com>
Date: Tue, 29 Sep 2020 14:10:03 +0200
Subject: [PATCH] resolve comments

---
 .../EmptyState/EmptyState.stories.tsx         | 20 +++++++++----------
 .../components/EmptyState/EmptyState.test.tsx |  2 +-
 .../src/components/EmptyState/EmptyState.tsx  | 10 +++++-----
 .../components/EmptyState/EmptyStateImage.tsx | 14 ++++++-------
 4 files changed, 23 insertions(+), 23 deletions(-)

diff --git a/packages/core/src/components/EmptyState/EmptyState.stories.tsx b/packages/core/src/components/EmptyState/EmptyState.stories.tsx
index e3902fbd17..f3e40bd31c 100644
--- a/packages/core/src/components/EmptyState/EmptyState.stories.tsx
+++ b/packages/core/src/components/EmptyState/EmptyState.stories.tsx
@@ -1,4 +1,3 @@
-import { Button } from '@material-ui/core';
 /*
  * Copyright 2020 Spotify AB
  *
@@ -17,6 +16,7 @@ import { Button } from '@material-ui/core';
 
 import React from 'react';
 import { EmptyState } from './EmptyState';
+import { Button } from '@material-ui/core';
 
 export default {
   title: 'EmptyState',
@@ -28,9 +28,9 @@ const containerStyle = { width: '100%', height: '100vh' };
 export const MissingAnnotation = () => (
   <div style={containerStyle}>
     <EmptyState
-      type="missingAnnotation"
+      missing="field"
       title="Your plugin is missing an annotation"
-      description="Add a descripton here."
+      description="Add a description here."
     />
   </div>
 );
@@ -38,9 +38,9 @@ export const MissingAnnotation = () => (
 export const NoInformation = () => (
   <div style={containerStyle}>
     <EmptyState
-      type="noInformation"
+      missing="info"
       title="No information to display"
-      description="Add a descripton here."
+      description="Add a description here."
     />
   </div>
 );
@@ -48,9 +48,9 @@ export const NoInformation = () => (
 export const CreateComponent = () => (
   <div style={containerStyle}>
     <EmptyState
-      type="createComponent"
+      missing="content"
       title="Create a component"
-      description="Add a descripton here."
+      description="Add a description here."
     />
   </div>
 );
@@ -58,9 +58,9 @@ export const CreateComponent = () => (
 export const NoBuild = () => (
   <div style={containerStyle}>
     <EmptyState
-      type="noBuild"
+      missing="data"
       title="No builds to show"
-      description="Add a descripton here."
+      description="Add a description here."
     />
   </div>
 );
@@ -68,7 +68,7 @@ export const NoBuild = () => (
 export const WithAction = () => (
   <div style={containerStyle}>
     <EmptyState
-      type="missingAnnotation"
+      missing="field"
       title="Your plugin is missing an annotation"
       description="Click the docs to learn more."
       action={
diff --git a/packages/core/src/components/EmptyState/EmptyState.test.tsx b/packages/core/src/components/EmptyState/EmptyState.test.tsx
index 2053af8ba6..c5bc7a9876 100644
--- a/packages/core/src/components/EmptyState/EmptyState.test.tsx
+++ b/packages/core/src/components/EmptyState/EmptyState.test.tsx
@@ -24,7 +24,7 @@ describe('<EmptyState />', () => {
     const rendered = await renderWithEffects(
       wrapInTestApp(
         <EmptyState
-          type="missingAnnotation"
+          missing="field"
           title="Your plugin is missing an annotation"
           action={<Button aria-label="button">DOCS</Button>}
         />,
diff --git a/packages/core/src/components/EmptyState/EmptyState.tsx b/packages/core/src/components/EmptyState/EmptyState.tsx
index f28c8521b0..88becc7c90 100644
--- a/packages/core/src/components/EmptyState/EmptyState.tsx
+++ b/packages/core/src/components/EmptyState/EmptyState.tsx
@@ -27,7 +27,7 @@ const useStyles = makeStyles(theme => ({
   action: {
     marginTop: theme.spacing(2),
   },
-  imgPlacholder: {
+  imageContainer: {
     position: 'relative',
   },
   backgroundImage: {
@@ -39,11 +39,11 @@ const useStyles = makeStyles(theme => ({
 type Props = {
   title: string;
   description?: string;
-  type: 'missingAnnotation' | 'noInformation' | 'createComponent' | 'noBuild';
+  missing: 'field' | 'info' | 'content' | 'data';
   action?: JSX.Element;
 };
 
-export const EmptyState = ({ title, description, type, action }: Props) => {
+export const EmptyState = ({ title, description, missing, action }: Props) => {
   const classes = useStyles();
   return (
     <Grid
@@ -65,13 +65,13 @@ export const EmptyState = ({ title, description, type, action }: Props) => {
           {action}
         </Grid>
       </Grid>
-      <Grid item xs={12} md={6} className={classes.imgPlacholder}>
+      <Grid item xs={12} md={6} className={classes.imageContainer}>
         <img
           src={Background}
           className={classes.backgroundImage}
           alt="background"
         />
-        <EmptyStateImage type={type} />
+        <EmptyStateImage missing={missing} />
       </Grid>
     </Grid>
   );
diff --git a/packages/core/src/components/EmptyState/EmptyStateImage.tsx b/packages/core/src/components/EmptyState/EmptyStateImage.tsx
index 082ea8c581..49598ae6db 100644
--- a/packages/core/src/components/EmptyState/EmptyStateImage.tsx
+++ b/packages/core/src/components/EmptyState/EmptyStateImage.tsx
@@ -22,7 +22,7 @@ import noBuild from './assets/noBuild.svg';
 import { makeStyles } from '@material-ui/core';
 
 type Props = {
-  type: 'missingAnnotation' | 'noInformation' | 'createComponent' | 'noBuild';
+  missing: 'field' | 'info' | 'content' | 'data';
 };
 
 const useStyles = makeStyles({
@@ -36,10 +36,10 @@ const useStyles = makeStyles({
   },
 });
 
-export const EmptyStateImage = ({ type }: Props) => {
+export const EmptyStateImage = ({ missing }: Props) => {
   const classes = useStyles();
-  switch (type) {
-    case 'missingAnnotation':
+  switch (missing) {
+    case 'field':
       return (
         <img
           src={missingAnnotation}
@@ -48,7 +48,7 @@ export const EmptyStateImage = ({ type }: Props) => {
           data-testid="missingAnnotation"
         />
       );
-    case 'noInformation':
+    case 'info':
       return (
         <img
           src={noInformation}
@@ -56,7 +56,7 @@ export const EmptyStateImage = ({ type }: Props) => {
           className={classes.generalImg}
         />
       );
-    case 'createComponent':
+    case 'content':
       return (
         <img
           src={createComponent}
@@ -64,7 +64,7 @@ export const EmptyStateImage = ({ type }: Props) => {
           className={classes.generalImg}
         />
       );
-    case 'noBuild':
+    case 'data':
       return (
         <img src={noBuild} alt="no Build" className={classes.generalImg} />
       );