From 28adfd3c4c36ecb1f92b4a64970c9fb44b9aee05 Mon Sep 17 00:00:00 2001
From: Andrew Thauer <6507159+andrewthauer@users.noreply.github.com>
Date: Wed, 24 Feb 2021 10:12:49 -0500
Subject: [PATCH] fix: test failures & warnings

---
 packages/app/src/App.test.tsx                    | 5 ++++-
 packages/dev-utils/src/devApp/render.test.tsx    | 2 +-
 plugins/proxy-backend/src/service/router.test.ts | 6 +++---
 3 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/packages/app/src/App.test.tsx b/packages/app/src/App.test.tsx
index 40c49416bf..cf70a7be27 100644
--- a/packages/app/src/App.test.tsx
+++ b/packages/app/src/App.test.tsx
@@ -25,7 +25,10 @@ describe('App', () => {
       value: [
         {
           data: {
-            app: { title: 'Test' },
+            app: {
+              title: 'Test',
+              support: { url: 'http://localhost:7000/support' },
+            },
             backend: { baseUrl: 'http://localhost:7000' },
             lighthouse: {
               baseUrl: 'http://localhost:3003',
diff --git a/packages/dev-utils/src/devApp/render.test.tsx b/packages/dev-utils/src/devApp/render.test.tsx
index fbebf2039b..9cb680c53b 100644
--- a/packages/dev-utils/src/devApp/render.test.tsx
+++ b/packages/dev-utils/src/devApp/render.test.tsx
@@ -33,7 +33,7 @@ describe('DevAppBuilder', () => {
     };
 
     const DevApp = createDevApp()
-      .addRootChild(<MyComponent />)
+      .addRootChild(<MyComponent key="test-key" />)
       .build();
 
     const rendered = render(<DevApp />);
diff --git a/plugins/proxy-backend/src/service/router.test.ts b/plugins/proxy-backend/src/service/router.test.ts
index 32e7a4d49d..d0eca55ee0 100644
--- a/plugins/proxy-backend/src/service/router.test.ts
+++ b/plugins/proxy-backend/src/service/router.test.ts
@@ -15,8 +15,8 @@
  */
 
 import { buildMiddleware, createRouter } from './router';
-import * as winston from 'winston';
 import {
+  getVoidLogger,
   loadBackendConfig,
   SingleHostDiscovery,
 } from '@backstage/backend-common';
@@ -40,7 +40,7 @@ const mockCreateProxyMiddleware = createProxyMiddleware as jest.MockedFunction<
 
 describe('createRouter', () => {
   it('works', async () => {
-    const logger = winston.createLogger();
+    const logger = getVoidLogger();
     const config = await loadBackendConfig({ logger, argv: [] });
     const discovery = SingleHostDiscovery.fromConfig(config);
     const router = await createRouter({
@@ -53,7 +53,7 @@ describe('createRouter', () => {
 });
 
 describe('buildMiddleware', () => {
-  const logger = winston.createLogger();
+  const logger = getVoidLogger();
 
   beforeEach(() => {
     mockCreateProxyMiddleware.mockClear();