Remove unnecessary NFS page component exports
Page components without props don't need to be exported from the package API surface. Import directly from the component file in the alpha entry points instead. Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com> Made-with: Cursor
This commit is contained in:
@@ -167,8 +167,8 @@ const _default: OverridableFrontendPlugin<
|
||||
direction?: 'TB' | 'BT' | 'LR' | 'RL' | undefined;
|
||||
zoom?: 'disabled' | 'enabled' | 'enable-on-click' | undefined;
|
||||
relations?: string[] | undefined;
|
||||
maxDepth?: number | undefined;
|
||||
rootEntityRefs?: string[] | undefined;
|
||||
maxDepth?: number | undefined;
|
||||
kinds?: string[] | undefined;
|
||||
mergeRelations?: boolean | undefined;
|
||||
relationPairs?: [string, string][] | undefined;
|
||||
|
||||
@@ -80,7 +80,7 @@ const CatalogGraphPage = PageBlueprint.makeWithOverrides({
|
||||
path: '/catalog-graph',
|
||||
routeRef: catalogGraphRouteRef,
|
||||
loader: () =>
|
||||
import('./components/CatalogGraphPage').then(m => (
|
||||
import('./components/CatalogGraphPage/CatalogGraphPage').then(m => (
|
||||
<m.NfsCatalogGraphPage {...config} />
|
||||
)),
|
||||
});
|
||||
|
||||
@@ -13,7 +13,7 @@
|
||||
* See the License for the specific language governing permissions and
|
||||
* limitations under the License.
|
||||
*/
|
||||
export { CatalogGraphPage, NfsCatalogGraphPage } from './CatalogGraphPage';
|
||||
export { CatalogGraphPage } from './CatalogGraphPage';
|
||||
export type { CatalogGraphPageClassKey } from './CatalogGraphPage';
|
||||
export type { MaxDepthFilterClassKey } from './MaxDepthFilter';
|
||||
export type { SelectedKindsFilterClassKey } from './SelectedKindsFilter';
|
||||
|
||||
@@ -11,8 +11,7 @@ import { ExtensionBlueprintParams } from '@backstage/frontend-plugin-api';
|
||||
import { ExtensionDataRef } from '@backstage/frontend-plugin-api';
|
||||
import { ExtensionInput } from '@backstage/frontend-plugin-api';
|
||||
import { IconElement } from '@backstage/frontend-plugin-api';
|
||||
import { JSX as JSX_2 } from 'react/jsx-runtime';
|
||||
import { JSX as JSX_3 } from 'react';
|
||||
import { JSX as JSX_2 } from 'react';
|
||||
import { OverridableExtensionDefinition } from '@backstage/frontend-plugin-api';
|
||||
import { OverridableFrontendPlugin } from '@backstage/frontend-plugin-api';
|
||||
import { RouteRef } from '@backstage/core-plugin-api';
|
||||
@@ -134,7 +133,7 @@ const _default: OverridableFrontendPlugin<
|
||||
optional: true;
|
||||
}
|
||||
>
|
||||
| ExtensionDataRef<JSX_3.Element, 'core.reactElement', {}>
|
||||
| ExtensionDataRef<JSX_2.Element, 'core.reactElement', {}>
|
||||
| ExtensionDataRef<
|
||||
string,
|
||||
'core.title',
|
||||
@@ -151,7 +150,7 @@ const _default: OverridableFrontendPlugin<
|
||||
>;
|
||||
inputs: {
|
||||
pages: ExtensionInput<
|
||||
| ConfigurableExtensionDataRef<JSX_3.Element, 'core.reactElement', {}>
|
||||
| ConfigurableExtensionDataRef<JSX_2.Element, 'core.reactElement', {}>
|
||||
| ConfigurableExtensionDataRef<string, 'core.routing.path', {}>
|
||||
| ConfigurableExtensionDataRef<
|
||||
RouteRef_2<AnyRouteRefParams>,
|
||||
@@ -185,7 +184,7 @@ const _default: OverridableFrontendPlugin<
|
||||
path: string;
|
||||
title?: string;
|
||||
icon?: IconElement;
|
||||
loader?: () => Promise<JSX_3.Element>;
|
||||
loader?: () => Promise<JSX_2.Element>;
|
||||
routeRef?: RouteRef_2;
|
||||
noHeader?: boolean;
|
||||
};
|
||||
@@ -194,8 +193,5 @@ const _default: OverridableFrontendPlugin<
|
||||
>;
|
||||
export default _default;
|
||||
|
||||
// @alpha (undocumented)
|
||||
export const DefaultImportPage: () => JSX_2.Element;
|
||||
|
||||
// (No @packageDocumentation comment for this package)
|
||||
```
|
||||
|
||||
@@ -44,8 +44,6 @@ import { catalogImportTranslationRef as _catalogImportTranslationRef } from './t
|
||||
*/
|
||||
export const catalogImportTranslationRef = _catalogImportTranslationRef;
|
||||
|
||||
export { NfsDefaultImportPage as DefaultImportPage } from './components/DefaultImportPage/DefaultImportPage';
|
||||
|
||||
// TODO: It's currently possible to override the import page with a custom one. We need to decide
|
||||
// whether this type of override is typically done with an input or by overriding the entire extension.
|
||||
const catalogImportPage = PageBlueprint.make({
|
||||
|
||||
@@ -81,9 +81,6 @@ export const DefaultImportPage = () => {
|
||||
);
|
||||
};
|
||||
|
||||
/**
|
||||
* @alpha
|
||||
*/
|
||||
export const NfsDefaultImportPage = () => {
|
||||
const { t } = useTranslationRef(catalogImportTranslationRef);
|
||||
const configApi = useApi(configApiRef);
|
||||
|
||||
Reference in New Issue
Block a user